hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-27 19:24:08 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

fix: code smell

Browse source
This commit is contained in:
xiaoyifang 2023-04-22 12:33:11 +08:00
parent 11ea4bc799
commit 084175f56f
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/headwordsmodel.cc
View file

@ -124,16 +124,16 @@ int HeadwordListModel::wordCount() const
QVariant HeadwordListModel::data( const QModelIndex & index, int role ) const QVariant HeadwordListModel::data( const QModelIndex & index, int role ) const
{ {
if( !index.isValid() ) if( !index.isValid() )
return QVariant(); return {};
if( index.row() >= totalSize || index.row() < 0 || index.row() >= words.size() ) if( index.row() >= totalSize || index.row() < 0 || index.row() >= words.size() )
return QVariant(); return {};
if( role == Qt::DisplayRole ) if( role == Qt::DisplayRole )
{ {
return words.at( index.row() ); return words.at( index.row() );
} }
return QVariant(); return {};
} }
bool HeadwordListModel::canFetchMore( const QModelIndex & parent ) const bool HeadwordListModel::canFetchMore( const QModelIndex & parent ) const
@ -174,7 +174,7 @@ void HeadwordListModel::fetchMore( const QModelIndex & parent )
emit numberPopulated( words.size() ); emit numberPopulated( words.size() );
} }
int HeadwordListModel::getCurrentIndex() int HeadwordListModel::getCurrentIndex() const
{ {
return index; return index;
} }

2
src/headwordsmodel.hh
View file

@ -22,7 +22,7 @@ public:
void setFilter( QRegularExpression ); void setFilter( QRegularExpression );
void appendWord( const QString & word ); void appendWord( const QString & word );
void addMatches( QStringList matches ); void addMatches( QStringList matches );
int getCurrentIndex(); int getCurrentIndex() const;
bool containWord( const QString & word ); bool containWord( const QString & word );
QSet< QString > getRemainRows( int & nodeIndex ); QSet< QString > getRemainRows( int & nodeIndex );
signals: signals: