From 1a3bae332942248823b112d36181b061f6e39bb0 Mon Sep 17 00:00:00 2001
From: shenleban tongying <shenlebantongying@gmail.com>
Date: Thu, 20 Apr 2023 05:49:05 -0400
Subject: [PATCH] cleanup(css): remove 1x1 pixel <img> hack

When the code was written, there is no way to specify img's src, so
the 1x1 blank.png is a dummy img to be replaced.
---
 icons/blank.png                                   | Bin 293 -> 0 bytes
 resources.qrc                                     |   1 -
 src/article_maker.cc                              |   2 +-
 src/stylesheets/article-style-st-babylon.css      |   8 ++++----
 src/stylesheets/article-style-st-classic.css      |   4 ++--
 src/stylesheets/article-style-st-lingoes-blue.css |   8 ++++----
 src/stylesheets/article-style-st-lingoes.css      |   8 ++++----
 src/stylesheets/article-style-st-modern.css       |   8 ++++----
 src/stylesheets/article-style.css                 |   4 ++--
 9 files changed, 21 insertions(+), 22 deletions(-)
 delete mode 100644 icons/blank.png

diff --git a/icons/blank.png b/icons/blank.png
deleted file mode 100644
index d0d70b876a31f4a3821e53e18a0f6c644f2c2136..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 293
zcmeAS@N?(olHy`uVBq!ia0vp^j35jm7|ip2ssJgLbVpxD28NCO+<y{TfqaEzk04(L
zhAK4%hK3dfhF?ITh8GMBr3MTPuM!v-tY$DUh!@P+6=(yLU@8gn3ua&_n|#&+#7pva
zcVS?>+a<gN$m1;Vh%9Dc;5!1sj8nDwq=AC$C7!;n?9W)F`P2oE?3(=tD8%LI;uykl
zJvjl$W@2D`q`1cz$WkqFjVMV;EJ?LWE=mPb3`Pb<hPno3x<-Z}hDKH<W<aEEU|?ln
z5N(v=kD?(rKP5A*5~RUM*T6*A$UMZ*#LC#*%G4O5;mn>1|A879JYD@<);T3K0RY~%
BMfLyy

diff --git a/resources.qrc b/resources.qrc
index 71aea13f..afd12cd0 100644
--- a/resources.qrc
+++ b/resources.qrc
@@ -31,7 +31,6 @@
         <file>icons/icon32_lingoes.png</file>
         <file>icons/mdict.png</file>
         <file>icons/downarrow.png</file>
-        <file>icons/blank.png</file>
         <file>icons/expand_article_hovered.png</file>
         <file>icons/expand_article.png</file>
         <file>icons/collapse_article_hovered.png</file>
diff --git a/src/article_maker.cc b/src/article_maker.cc
index 19653b1e..57ef22d5 100644
--- a/src/article_maker.cc
+++ b/src/article_maker.cc
@@ -667,7 +667,7 @@ void ArticleRequest::bodyFinished()
                       <span class="gddicticon"><img src="gico://%1/dicticon.png"></span>
                       <span class="gdfromprefix">%4</span>
                       <span class="gddicttitle">%5</span>
-                      <span class="collapse_expand_area"><img src="qrc:///icons/blank.png" class="%6" id="expandicon-%1" title="%7" ></span>
+                      <span class="collapse_expand_area"><img class="%6" id="expandicon-%1" title="%7" ></span>
                      </div>)" )
                   .arg( dictId.c_str(),
                         collapse ? R"(style="cursor:pointer;")" : "",
diff --git a/src/stylesheets/article-style-st-babylon.css b/src/stylesheets/article-style-st-babylon.css
index b09425f6..3dd0c05d 100644
--- a/src/stylesheets/article-style-st-babylon.css
+++ b/src/stylesheets/article-style-st-babylon.css
@@ -73,19 +73,19 @@ h3 {
 }
 
 .gdexpandicon {
-    background-image: url('qrc:///icons/expand_article.png');
+	content:url('qrc:///icons/expand_article.png');
 }
 
 .gdexpandicon:hover {
-    background-image: url('qrc:///icons/expand_article_hovered.png');
+	content:url('qrc:///icons/expand_article_hovered.png');
 }
 
 .gdcollapseicon {
-    background-image: url('qrc:///icons/collapse_article.png');
+	content:url('qrc:///icons/collapse_article.png');
 }
 
 .gdcollapseicon:hover {
-    background-image: url('qrc:///icons/collapse_article_hovered.png');
+	content:url('qrc:///icons/collapse_article_hovered.png');
 }
 
 .bglpos { color: black; font-weight: bold; font-size: 11px; background: #F0EDED; display: inline; }
diff --git a/src/stylesheets/article-style-st-classic.css b/src/stylesheets/article-style-st-classic.css
index ed885a97..53f6ac8c 100644
--- a/src/stylesheets/article-style-st-classic.css
+++ b/src/stylesheets/article-style-st-classic.css
@@ -2909,7 +2909,7 @@ in bg url to hide it from iemac */
     width:16px;
     height:16px;
     vertical-align: text-bottom;
-    background-image:url('qrc:///icons/old-arrow.png');
+    content:url('qrc:///icons/old-arrow.png');
 }
 
 .gdcollapseicon {
@@ -2917,7 +2917,7 @@ in bg url to hide it from iemac */
     width:16px;
     height:16px;
     vertical-align: text-bottom;
-    background-image:url('qrc:///icons/old-downarrow.png');
+    content:url('qrc:///icons/old-downarrow.png');
 }
 
 /********** Slob dictionaries ***********/
diff --git a/src/stylesheets/article-style-st-lingoes-blue.css b/src/stylesheets/article-style-st-lingoes-blue.css
index 6789aaee..0246604f 100644
--- a/src/stylesheets/article-style-st-lingoes-blue.css
+++ b/src/stylesheets/article-style-st-lingoes-blue.css
@@ -107,19 +107,19 @@ a:hover {
 }
 
 .gdexpandicon {
-    background-image: url('qrc:///icons/expand_article.png');
+	content:url('qrc:///icons/expand_article.png');
 }
 
 .gdexpandicon:hover {
-    background-image: url('qrc:///icons/expand_article_hovered.png');
+	content:url('qrc:///icons/expand_article_hovered.png');
 }
 
 .gdcollapseicon {
-    background-image: url('qrc:///icons/collapse_article.png');
+	content:url('qrc:///icons/collapse_article.png');
 }
 
 .gdcollapseicon:hover {
-    background-image: url('qrc:///icons/collapse_article_hovered.png');
+	content:url('qrc:///icons/collapse_article_hovered.png');
 }
 
 .gdarticleseparator {
diff --git a/src/stylesheets/article-style-st-lingoes.css b/src/stylesheets/article-style-st-lingoes.css
index 2f7ab6ca..d3facc54 100644
--- a/src/stylesheets/article-style-st-lingoes.css
+++ b/src/stylesheets/article-style-st-lingoes.css
@@ -78,19 +78,19 @@ body
 
 
 .gdexpandicon {
-  background-image: url('qrc:///icons/expand_article.png');
+  content:url('qrc:///icons/expand_article.png');
 }
 
 .gdexpandicon:hover {
-  background-image: url('qrc:///icons/expand_article_hovered.png');
+  content:url('qrc:///icons/expand_article_hovered.png');
 }
 
 .gdcollapseicon {
-  background-image: url('qrc:///icons/collapse_article.png');
+  content:url('qrc:///icons/collapse_article.png');
 }
 
 .gdcollapseicon:hover {
-  background-image: url('qrc:///icons/collapse_article_hovered.png');
+  content:url('qrc:///icons/collapse_article_hovered.png');
 }
 
 .gddictnamebodyseparator
diff --git a/src/stylesheets/article-style-st-modern.css b/src/stylesheets/article-style-st-modern.css
index f64c73e8..678fdb6b 100644
--- a/src/stylesheets/article-style-st-modern.css
+++ b/src/stylesheets/article-style-st-modern.css
@@ -137,19 +137,19 @@ a:hover
 }
 
 .gdexpandicon {
-    background-image: url('qrc:///icons/expand_article.png');
+  content:url('qrc:///icons/expand_article.png');
 }
 
 .gdexpandicon:hover {
-    background-image: url('qrc:///icons/expand_article_hovered.png');
+  content:url('qrc:///icons/expand_article_hovered.png');
 }
 
 .gdcollapseicon {
-    background-image: url('qrc:///icons/collapse_article.png');
+  content:url('qrc:///icons/collapse_article.png');
 }
 
 .gdcollapseicon:hover {
-    background-image: url('qrc:///icons/collapse_article_hovered.png');
+  content:url('qrc:///icons/collapse_article_hovered.png');
 }
 
 /* The first headword in a (possibly) multi-headword DSL article */
diff --git a/src/stylesheets/article-style.css b/src/stylesheets/article-style.css
index 3f27f2d8..e3b054c5 100644
--- a/src/stylesheets/article-style.css
+++ b/src/stylesheets/article-style.css
@@ -2935,7 +2935,7 @@ in bg url to hide it from iemac */
     height:16px;
     vertical-align: text-bottom;
     background-size: contain;
-    background-image:url('qrc://localhost/icons/arrow.png');
+    content:url('qrc://localhost/icons/arrow.png');
 }
 
 .gdcollapseicon {
@@ -2944,7 +2944,7 @@ in bg url to hide it from iemac */
     height:16px;
     vertical-align: text-bottom;
     background-size: contain;
-    background-image:url('qrc://localhost/icons/downarrow.png');
+    content:url('qrc://localhost/icons/downarrow.png');
 }
 
 /********** Slob dictionaries ***********/