From 1fa077171647cedbd960319ec02404b5d1bd7cfd Mon Sep 17 00:00:00 2001
From: shenleban tongying <shenlebantongying@gmail.com>
Date: Mon, 18 Nov 2024 21:35:15 -0500
Subject: [PATCH] fix: local audio files without extension are not added to
 dictAudioMap

---
 src/common/utils.hh    | 9 +++++++--
 src/pronounceengine.cc | 4 ++--
 src/pronounceengine.hh | 2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/common/utils.hh b/src/common/utils.hh
index 6722ddbe..78087314 100644
--- a/src/common/utils.hh
+++ b/src/common/utils.hh
@@ -257,9 +257,14 @@ inline bool isAudioUrl( QUrl const & url )
 {
   if ( !url.isValid() )
     return false;
-  // Note: we check for forvo sound links explicitly, as they don't have extensions
 
-  return ( url.scheme() == "http" || url.scheme() == "https" || url.scheme() == "gdau" )
+  // gdau links are known to be audios, (sometimes they may not have file extension).
+  if ( url.scheme() == "gdau" ) {
+    return true;
+  }
+
+  // Note: we check for forvo sound links explicitly, as they don't have extensions
+  return ( url.scheme() == "http" || url.scheme() == "https" )
     && ( Filetype::isNameOfSound( url.path().toUtf8().data() ) || url.host() == "apifree.forvo.com" );
 }
 
diff --git a/src/pronounceengine.cc b/src/pronounceengine.cc
index 1391de7c..14bd3f2a 100644
--- a/src/pronounceengine.cc
+++ b/src/pronounceengine.cc
@@ -17,7 +17,7 @@ void PronounceEngine::reset()
 }
 
 
-void PronounceEngine::sendAudio( std::string dictId, QString audioLink )
+void PronounceEngine::sendAudio( const std::string & dictId, const QString & audioLink )
 {
   if ( state == PronounceState::OCCUPIED ) {
     return;
@@ -29,7 +29,7 @@ void PronounceEngine::sendAudio( std::string dictId, QString audioLink )
 
   QMutexLocker _( &mutex );
 
-  dictAudioMap.operator[]( dictId ).push_back( audioLink );
+  dictAudioMap[ dictId ].append( audioLink );
 }
 
 void PronounceEngine::finishDictionary( std::string dictId )
diff --git a/src/pronounceengine.hh b/src/pronounceengine.hh
index 2b28b34d..1541ab4e 100644
--- a/src/pronounceengine.hh
+++ b/src/pronounceengine.hh
@@ -21,7 +21,7 @@ class PronounceEngine: public QObject
 public:
   explicit PronounceEngine( QObject * parent = nullptr );
   void reset();
-  void sendAudio( std::string dictId, QString audioLink );
+  void sendAudio( const std::string & dictId, const QString & audioLink );
   void finishDictionary( std::string dictId );
 signals:
   void emitAudio( QString audioLink );