hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-27 19:24:08 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

*! Minimize the number of realloc()s done when reading zip cdir.

Browse source 
This should presumably make reading of large zip archives much faster.
This commit is contained in:
Konstantin Isakov 2009-05-28 12:26:16 +00:00
parent 8a2cf34051
commit 2b2de01e95
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/libzip/zip_open.c
View file

@ -232,14 +232,16 @@ _zip_readcdir(FILE *fp, unsigned char *buf, unsigned char *eocd, int buflen,
}
// Instead of using nentry, just read all entries until one can't be read.
// And we're not gonna use
int allocated = nentry;
for (i=0; ; i++)
{
if ( i >= nentry )
if ( i >= allocated )
{
// The original array won't hold -- reallocate
cd->entry = realloc( cd->entry, ( i + 1 ) * sizeof(*(cd->entry)) );
allocated += 65536;
cd->entry = realloc( cd->entry, allocated * sizeof(*(cd->entry)) );
}
if ((_zip_dirent_read(cd->entry+i, fp, bufp, eocd-cdp, 0,
@ -248,6 +250,11 @@ _zip_readcdir(FILE *fp, unsigned char *buf, unsigned char *eocd, int buflen,
}
}
// Deallocate the unneeded memory
if ( allocated != i )
cd->entry = realloc( cd->entry, i * sizeof(*(cd->entry)) );
cd->nentry = i;
return cd;