hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-23 20:14:05 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

Merge pull request #1723 from xiaoyifang/fix/file-close

Browse source 
fix: close file when return error
This commit is contained in:
xiaoyifang 2024-08-10 14:52:49 +08:00 committed by GitHub
parent 65ae8f5030 6b4936ade4
commit 2dcf2a3bad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/dictzip.c
View file

@ -416,8 +416,9 @@ static enum DZ_ERRORS dict_read_header( const char * filename, dictData * header
if ( ftell( str ) != header->headerLength + 1 ) { if ( ftell( str ) != header->headerLength + 1 ) {
err_internal( __func__, "File position (%lu) != header length + 1 (%d)\n", ftell( str ), header->headerLength + 1 ); err_internal( __func__, "File position (%lu) != header length + 1 (%d)\n", ftell( str ), header->headerLength + 1 );
fclose( str ); fclose( str );
if ( header->chunks ) if ( header->chunks ) {
free( header->chunks ); free( header->chunks );
}
return DZ_ERR_INVALID_FORMAT; return DZ_ERR_INVALID_FORMAT;
} }
@ -435,8 +436,10 @@ static enum DZ_ERRORS dict_read_header( const char * filename, dictData * header
/* Compute offsets */ /* Compute offsets */
header->offsets = xmalloc( sizeof( header->offsets[ 0 ] ) * header->chunkCount ); header->offsets = xmalloc( sizeof( header->offsets[ 0 ] ) * header->chunkCount );
if ( header->offsets == 0 ) { if ( header->offsets == 0 ) {
if ( header->chunks ) if ( header->chunks ) {
free( header->chunks ); free( header->chunks );
}
fclose( str );
return DZ_ERR_NOMEMORY; return DZ_ERR_NOMEMORY;
} }