hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-23 20:14:05 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

opt: move auto release guard to the variable

Browse source 
by this way, developer will have a more clear view about what will happen when released
This commit is contained in:
YiFang Xiao 2023-05-12 08:12:46 +08:00 committed by xiaoyifang
parent be8331afa8
commit 301db81bd4
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/main.cc
View file

@ -206,15 +206,6 @@ void processCommandLine( QCoreApplication * app, GDOptions * result)
}
}
class LogFilePtrGuard
{
QFile logFile;
Q_DISABLE_COPY( LogFilePtrGuard )
public:
LogFilePtrGuard() { logFilePtr = &logFile; }
~LogFilePtrGuard() { logFilePtr = 0; }
};
int main( int argc, char ** argv )
{
#ifdef Q_OS_UNIX
@ -304,7 +295,15 @@ int main( int argc, char ** argv )
QWebEngineUrlScheme::registerScheme(webUiScheme);
}
LogFilePtrGuard logFilePtrGuard;
QFile file;
logFilePtr = &file;
auto guard = qScopeGuard( [ &file ]() {
logFilePtr = nullptr;
file.close();
} );
Q_UNUSED( guard )
if ( app.isRunning() )
{