hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-23 16:04:06 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

refactor: change DEF_EX macro's underlying implementation to template

Browse source
This commit is contained in:
shenleban tongying 2024-11-11 23:10:53 -05:00
parent 608016208b
commit 4758f9e972
2 changed files with 44 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.clang-tidy
View file

@ -17,7 +17,6 @@ Checks: >
portability-*,
readability-*,
-bugprone-easily-swappable-parameters,
-bugprone-reserved-identifier,
-cppcoreguidelines-owning-memory,
-cppcoreguidelines-prefer-member-initializer,
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
@ -44,5 +43,11 @@ CheckOptions:
value: 1
- key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
value: 1
- key: modernize-avoid-c-arrays.AllowStringArrays
value: 1
- key: cppcoreguidelines-avoid-c-arrays.AllowStringArrays
value: 1
- key: hicpp-avoid-c-arrays.AllowStringArrays
value: 1
...

61
src/common/ex.hh
View file

@ -4,22 +4,17 @@
#pragma once
#include <string>
#include <fmt/format.h>
// clang-format off
/// A way to declare an exception class fast
/// Do like this:
/// DEF_EX( exErrorInFoo, "An error in foo encountered", std::exception )
/// DEF_EX( exFooNotFound, "Foo was not found", exErrorInFoo )
#define DEF_EX( exName, exDescription, exParent ) \
class exName: public exParent \
{ \
public: \
virtual const char * what() const noexcept \
{ \
return ( exDescription ); \
} \
virtual ~exName() noexcept {} \
};
constexpr static char ExStr_## exName[] = exDescription; \
using exName = defineEx< exParent, ExStr_## exName >;
/// Same as DEF_EX, but takes a runtime string argument, which gets concatenated
/// with the description.
@ -29,20 +24,36 @@
/// throw exCantOpen( "example.txt" );
///
/// what() would return "can't open file example.txt"
///
#define DEF_EX_STR( exName, exDescription, exParent ) \
class exName: public exParent \
{ \
std::string value; \
\
public: \
explicit exName( std::string const & value_ ): \
value( std::string( exDescription ) + " " + value_ ) \
{ \
} \
virtual const char * what() const noexcept \
{ \
return value.c_str(); \
} \
virtual ~exName() noexcept {} \
constexpr static char ExStr_## exName[] = exDescription; \
using exName = defineExStr< exParent, ExStr_## exName >;
// clang-format on
template< typename ParentEx, const char * description >
class defineEx: public ParentEx
{
public:
virtual const char * what() const noexcept
{
return description;
}
};
template< typename ParentEx, const char * description >
class defineExStr: public ParentEx
{
public:
explicit defineExStr( std::string const & message_ ):
message( fmt::format( "{} {}", description, message_ ) )
{
}
virtual const char * what() const noexcept
{
return message.c_str();
}
private:
std::string message;
};