hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-27 15:24:05 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

fix:code smell

Browse source
This commit is contained in:
Xiao YiFang 2023-04-10 22:12:54 +08:00 committed by xiaoyifang
parent 6dee7cf1e9
commit 54a4a052a5
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
scanpopup.cc
View file

@ -712,7 +712,7 @@ vector< sptr< Dictionary::Class > > const & ScanPopup::getActiveDicts()
Config::MutedDictionaries const * mutedDictionaries = dictionaryBar.getMutedDictionaries();
if ( !dictionaryBar.toggleViewAction()->isChecked() || mutedDictionaries == 0 ){
if ( !dictionaryBar.toggleViewAction()->isChecked() || mutedDictionaries == nullptr ){
return groups[current].dictionaries;
}
@ -751,18 +751,15 @@ void ScanPopup::typingEvent( QString const & t )
bool ScanPopup::eventFilter( QObject * watched, QEvent * event )
{
if ( watched == ui.translateBox->translateLine() )
if ( watched == ui.translateBox->translateLine() && event->type() == QEvent::FocusIn )
{
if ( event->type() == QEvent::FocusIn )
{
QFocusEvent * focusEvent = static_cast< QFocusEvent * >( event );
const QFocusEvent * focusEvent = static_cast< QFocusEvent * >( event );
// select all on mouse click
if ( focusEvent->reason() == Qt::MouseFocusReason ) {
QTimer::singleShot( 0, this, &ScanPopup::focusTranslateLine );
}
return false;
// select all on mouse click
if ( focusEvent->reason() == Qt::MouseFocusReason ) {
QTimer::singleShot( 0, this, &ScanPopup::focusTranslateLine );
}
return false;
}
if ( mouseIntercepted )
@ -771,7 +768,6 @@ bool ScanPopup::eventFilter( QObject * watched, QEvent * event )
if ( event->type() == QEvent::MouseMove )
{
// GD_DPRINTF( "Object: %s\n", watched->objectName().toUtf8().data() );
QMouseEvent * mouseEvent = ( QMouseEvent * ) event;
reactOnMouseMove( mouseEvent->globalPos() );
}