diff --git a/src/ui/articleview.cc b/src/ui/articleview.cc index 8ad840e6..048fcc5a 100644 --- a/src/ui/articleview.cc +++ b/src/ui/articleview.cc @@ -1610,32 +1610,34 @@ void ArticleView::contextMenuRequested( QPoint const & pos ) unsigned refsAdded = 0; bool maxDictionaryRefsReached = false; - for ( QStringList::const_iterator i = ids.constBegin(); i != ids.constEnd(); ++i, ++refsAdded ) { - // Find this dictionary + if ( cfg.preferences.maxDictionaryRefsInContextMenu > 0 ) { + for ( QStringList::const_iterator i = ids.constBegin(); i != ids.constEnd(); ++i, ++refsAdded ) { + // Find this dictionary - auto dictionary = dictionaryGroup->getDictionaryById( i->toUtf8().data() ); - if ( dictionary ) { - QAction * action = nullptr; - if ( refsAdded == cfg.preferences.maxDictionaryRefsInContextMenu ) { - // Enough! Or the menu would become too large. - maxDictionaryRefsAction = new QAction( ".........", &menu ); - action = maxDictionaryRefsAction; - maxDictionaryRefsReached = true; - } - else { - action = new QAction( dictionary->getIcon(), QString::fromUtf8( dictionary->getName().c_str() ), &menu ); - // Force icons in menu on all platforms, - // since without them it will be much harder - // to find things. - action->setIconVisibleInMenu( true ); - } - menu.addAction( action ); + auto dictionary = dictionaryGroup->getDictionaryById( i->toUtf8().data() ); + if ( dictionary ) { + QAction * action = nullptr; + if ( refsAdded == cfg.preferences.maxDictionaryRefsInContextMenu ) { + // Enough! Or the menu would become too large. + maxDictionaryRefsAction = new QAction( ".........", &menu ); + action = maxDictionaryRefsAction; + maxDictionaryRefsReached = true; + } + else { + action = new QAction( dictionary->getIcon(), QString::fromUtf8( dictionary->getName().c_str() ), &menu ); + // Force icons in menu on all platforms, + // since without them it will be much harder + // to find things. + action->setIconVisibleInMenu( true ); + } + menu.addAction( action ); - tableOfContents[ action ] = *i; + tableOfContents[ action ] = *i; + } + + if ( maxDictionaryRefsReached ) + break; } - - if ( maxDictionaryRefsReached ) - break; } menu.addSeparator();