hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-27 15:24:05 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

fix regression: select translation line text when got focused (#841)

Browse source 
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
This commit is contained in:
xiaoyifang 2023-06-10 10:36:59 +08:00 committed by GitHub
parent fe1c609b49
commit 9c1a77a3f8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/ui/mainwindow.cc
View file

@ -2507,6 +2507,15 @@ bool MainWindow::eventFilter( QObject * obj, QEvent * ev )
}
}
if ( ev->type() == QEvent::FocusIn ) {
// select all on mouse click
if ( const auto focusEvent = dynamic_cast< QFocusEvent * >( ev ); focusEvent->reason() == Qt::MouseFocusReason ) {
QTimer::singleShot( 0, this, SLOT( focusTranslateLine() ) );
}
return false;
}
if ( ev->type() == QEvent::Resize ) {
QResizeEvent * resizeEvent = static_cast< QResizeEvent * >( ev );
groupList->setFixedHeight( resizeEvent->size().height() );

10
src/ui/translatebox.cc
View file

@ -12,6 +12,7 @@
#include <QScrollBar>
#include <QStyle>
#include <QStringListModel>
#include <QTimer>
TranslateBox::TranslateBox( QWidget * parent ):
QWidget( parent ),
@ -49,9 +50,12 @@ TranslateBox::TranslateBox( QWidget * parent ):
completer->setCompletionMode( QCompleter::UnfilteredPopupCompletion );
completer->setMaxVisibleItems( 16 );
connect( completer, QOverload< const QString & >::of( &QCompleter::activated ), this, [ = ]( const QString & text ) {
emit translate_line->returnPressed();
} );
connect( completer,
QOverload< const QString & >::of( &QCompleter::activated ),
translate_line,
[ & ]( const QString & ) {
emit translate_line->returnPressed();
} );
}
void TranslateBox::setText( const QString & text, bool showPopup )