hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-24 08:34:08 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

Don't append duplicates to openedInspectors

Browse source 
There is no benefit in storing the same pointer multiple times in
openedInspectors. This occurred when an article inspector window was
closed then shown again. When the tab corresponding to the duplicated
article inspector pointer was closed, ArticleInspector::beforeClosed()
erased only one pointer from openedInspectors. This left dangling
duplicate pointer(s) in the list and eventually caused a crash when
another inspector's showEvent() accessed a dangling pointer at
openedInspectors.front().
This commit is contained in:
Igor Kushnir 2022-10-29 13:32:17 +03:00 committed by Abs62
parent 9330c89e4b
commit cf84f57632
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
articleinspector.cc
View file

@ -47,7 +47,8 @@ void ArticleInspector::showEvent( QShowEvent * event )
setGeometry( p->geometry() );
}
openedInspectors.push_back( this );
if( std::find( openedInspectors.begin(), openedInspectors.end(), this ) == openedInspectors.end() )
openedInspectors.push_back( this );
QWebInspector::showEvent( event );
}