From d22a360d9f94e490e119bd022f4fa4b81ad7fdb2 Mon Sep 17 00:00:00 2001
From: shenleban tongying <shenlebantongying@gmail.com>
Date: Sat, 12 Oct 2024 09:41:03 -0400
Subject: [PATCH] fix: wrong lifetime of the `connection` between
 searchInPageAction <> openSearch

---
 .github/workflows/PR-check-cmake.yml | 5 ++---
 src/ui/mainwindow.cc                 | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/PR-check-cmake.yml b/.github/workflows/PR-check-cmake.yml
index f4237ae3..dd3432aa 100644
--- a/.github/workflows/PR-check-cmake.yml
+++ b/.github/workflows/PR-check-cmake.yml
@@ -17,6 +17,8 @@ jobs:
     steps:             
       - name: Install dependencies
         run: |
+          sudo apt-get update
+
           sudo apt-get install build-essential ninja-build \
           libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \
           libxtst-dev liblzo2-dev libbz2-dev \
@@ -34,7 +36,6 @@ jobs:
           qt6-webengine-dev
       - uses: actions/checkout@v4
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: false
       - name: Run build
         run: |
@@ -49,7 +50,6 @@ jobs:
     steps:             
       - uses: actions/checkout@v4
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: false
       - name: Install dependencies
         run: |
@@ -92,7 +92,6 @@ jobs:
           setup-python: 'false'
       - uses: actions/checkout@v4
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
           submodules: true
       - name: Run build
         run: |
diff --git a/src/ui/mainwindow.cc b/src/ui/mainwindow.cc
index d9aa581d..833c3ad5 100644
--- a/src/ui/mainwindow.cc
+++ b/src/ui/mainwindow.cc
@@ -1800,7 +1800,7 @@ ArticleView * MainWindow::createNewTab( bool switchToIt, QString const & name )
   connect( view, &ArticleView::zoomOut, this, &MainWindow::zoomout );
   connect( view, &ArticleView::saveBookmarkSignal, this, &MainWindow::addBookmarkToFavorite );
 
-  connect( ui.searchInPageAction, &QAction::triggered, this, [ this, view ]() {
+  connect( ui.searchInPageAction, &QAction::triggered, view, [ this, view ]() {
 #ifdef Q_OS_MACOS
     //workaround to fix macos popup page search Ctrl + F
     if ( scanPopup && scanPopup->isActiveWindow() ) {