hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-27 19:24:08 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

fix: terminator handler does not work as expected

Browse source 
fix #887
This commit is contained in:
YiFang Xiao 2023-07-08 21:57:21 +08:00
parent f52e998524
commit e85609ce42
2 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/speechclient.cc
View file

@ -19,7 +19,7 @@ SpeechClient::Engines SpeechClient::availableEngines()
const auto sp = new QTextToSpeech( engine_name );
#if ( QT_VERSION >= QT_VERSION_CHECK( 6, 0, 0 ) )
if ( !sp || sp->state() == QTextToSpeech::Error )
if ( sp->state() == QTextToSpeech::Error )
continue;
#else
if ( !sp || sp->state() == QTextToSpeech::BackendError )

19
src/termination.cc
View file

@ -9,26 +9,7 @@
static void termHandler()
{
// Trick: In c++17, there is no standardized way to know the exception name/type inside terminate_handler
// So, we just get the exception and throw it again, so that we can call the std::exception::what :)
// This trick can be removed/improved if something similar to
// boost::current_exception_diagnostic_information got standardized,
std::exception_ptr curException = std::current_exception();
try {
if ( curException != nullptr ) {
std::rethrow_exception( curException );
}
else {
qDebug() << "GoldenDict has crashed unexpectedly.\n\n";
}
}
catch ( const std::exception & e ) {
qDebug() << "GoldenDict has crashed with exception: " << e.what() ;
}
if( logFilePtr && logFilePtr->isOpen() )
logFilePtr->close();