From eec796c6e3a0d85eb9447a1629bcc6179b8bee13 Mon Sep 17 00:00:00 2001 From: Igor Kushnir Date: Wed, 18 Apr 2018 22:06:45 +0300 Subject: [PATCH] Eliminate a redundant makeScanPopup() call Destroying and creating a scan popup instance twice in MainWindow::editPreferences() is wasteful. 2b9dd558046670f566cb78e9536b4d5556c3af48 added the unconditional second makeScanPopup() call below but didn't remove the existing call, probably by mistake. --- mainwindow.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/mainwindow.cc b/mainwindow.cc index 9ac1e3e4..fd99542b 100644 --- a/mainwindow.cc +++ b/mainwindow.cc @@ -2109,7 +2109,6 @@ void MainWindow::editPreferences() updateTrayIcon(); applyProxySettings(); applyWebSettings(); - makeScanPopup(); ui.tabWidget->setHideSingleTab(cfg.preferences.hideSingleTab);