hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-23 20:14:05 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

fix: wrong lifetime of the connection between searchInPageAction <> openSearch
Some checks are pending
SonarCloud / Build and analyze (push) Waiting to run
Details

Browse source
This commit is contained in:
shenleban tongying 2024-10-12 09:41:03 -04:00 committed by GitHub
parent 9010262801
commit ef57526762
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.github/workflows/PR-check-cmake.yml vendored
View file

@ -17,6 +17,8 @@ jobs:
steps: steps:
- name: Install dependencies - name: Install dependencies
run: | run: |
sudo apt-get update
sudo apt-get install build-essential ninja-build \ sudo apt-get install build-essential ninja-build \
libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \ libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \
libxtst-dev liblzo2-dev libbz2-dev \ libxtst-dev liblzo2-dev libbz2-dev \
@ -34,7 +36,6 @@ jobs:
qt6-webengine-dev qt6-webengine-dev
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
submodules: false submodules: false
- name: Run build - name: Run build
run: | run: |
@ -49,7 +50,6 @@ jobs:
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
submodules: false submodules: false
- name: Install dependencies - name: Install dependencies
run: | run: |
@ -92,7 +92,6 @@ jobs:
setup-python: 'false' setup-python: 'false'
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
submodules: true submodules: true
- name: Run build - name: Run build
run: | run: |

2
src/ui/mainwindow.cc
View file

@ -1851,7 +1851,7 @@ ArticleView * MainWindow::createNewTab( bool switchToIt, QString const & name )
connect( view, &ArticleView::zoomOut, this, &MainWindow::zoomout ); connect( view, &ArticleView::zoomOut, this, &MainWindow::zoomout );
connect( view, &ArticleView::saveBookmarkSignal, this, &MainWindow::addBookmarkToFavorite ); connect( view, &ArticleView::saveBookmarkSignal, this, &MainWindow::addBookmarkToFavorite );
connect( ui.searchInPageAction, &QAction::triggered, this, [ this, view ]() { connect( ui.searchInPageAction, &QAction::triggered, view, [ this, view ]() {
#ifdef Q_OS_MACOS #ifdef Q_OS_MACOS
//workaround to fix macos popup page search Ctrl + F //workaround to fix macos popup page search Ctrl + F
if ( scanPopup && scanPopup->isActiveWindow() ) { if ( scanPopup && scanPopup->isActiveWindow() ) {