mirror of
https://github.com/xiaoyifang/goldendict-ng.git
synced 2024-11-27 15:24:05 +00:00
fix: wrong lifetime of the connection
between searchInPageAction <> openSearch
Some checks are pending
SonarCloud / Build and analyze (push) Waiting to run
Some checks are pending
SonarCloud / Build and analyze (push) Waiting to run
This commit is contained in:
parent
9010262801
commit
ef57526762
5
.github/workflows/PR-check-cmake.yml
vendored
5
.github/workflows/PR-check-cmake.yml
vendored
|
@ -17,6 +17,8 @@ jobs:
|
|||
steps:
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
sudo apt-get update
|
||||
|
||||
sudo apt-get install build-essential ninja-build \
|
||||
libvorbis-dev zlib1g-dev libhunspell-dev x11proto-record-dev \
|
||||
libxtst-dev liblzo2-dev libbz2-dev \
|
||||
|
@ -34,7 +36,6 @@ jobs:
|
|||
qt6-webengine-dev
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
|
||||
submodules: false
|
||||
- name: Run build
|
||||
run: |
|
||||
|
@ -49,7 +50,6 @@ jobs:
|
|||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
|
||||
submodules: false
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
|
@ -92,7 +92,6 @@ jobs:
|
|||
setup-python: 'false'
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
|
||||
submodules: true
|
||||
- name: Run build
|
||||
run: |
|
||||
|
|
|
@ -1851,7 +1851,7 @@ ArticleView * MainWindow::createNewTab( bool switchToIt, QString const & name )
|
|||
connect( view, &ArticleView::zoomOut, this, &MainWindow::zoomout );
|
||||
connect( view, &ArticleView::saveBookmarkSignal, this, &MainWindow::addBookmarkToFavorite );
|
||||
|
||||
connect( ui.searchInPageAction, &QAction::triggered, this, [ this, view ]() {
|
||||
connect( ui.searchInPageAction, &QAction::triggered, view, [ this, view ]() {
|
||||
#ifdef Q_OS_MACOS
|
||||
//workaround to fix macos popup page search Ctrl + F
|
||||
if ( scanPopup && scanPopup->isActiveWindow() ) {
|
||||
|
|
Loading…
Reference in a new issue