hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-25 01:14:07 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity
3910 commits 16 branches 629 tags 255 MiB
Commit graph

488 commits

Author SHA1 Message Date
Xiao YiFang e241cbef33 fix merge conflict 
when merge the changes introduced by pull #77
 2022-05-25 23:54:45 +08:00
Igor Kushnir c770e9688e Don't update state prematurely in showTranslationFor() 
MainWindow::showTranslationFor() overloads disable the "Pronounce Word"
action, then call ArticleView::showDefinition(). And then immediately
update pronounce availability, Found in Dictionaries list, Back and
Forward buttons. Since ArticleView::showDefinition() loads the requested
page asynchronously, the previous page is still current. Therefore the
"Pronounce Word" action is immediately re-enabled (if the still-current
article has sounds), the other state updates have no effect whatsoever.
Once the new page is loaded, the state is updated again in
MainWindow::pageLoaded() - this time with the desired effect.

So the only effect of the state updates in
MainWindow::showTranslationFor() is to revert the intentional disabling
of the "Pronounce Word" action. Plus waste some CPU time. The
pronunciation-disabling behavior looks better to me and is consistent
with the scan popup's behavior (which immediately hides the
"Pronounce Word" button).
 2022-05-25 18:27:18 +03:00
Xiao YiFang de11e573d3 fix:quit application failed 
when the inspector windows is show
 2022-05-23 23:38:04 +08:00
Xiao YiFang fe1fd6b933 fix: webengineview font lose affect after restart the application 2022-05-23 20:14:26 +08:00
Xiao YiFang a7ba9e4b36 opt:use acceptNavigationRequest instead of weburlinterceptor 2022-05-20 18:01:41 +08:00
Xiao YiFang 459b684e5b opt: make the inspect window's instance to exactly only one. 2022-05-20 17:31:47 +08:00
Xiao YiFang e6ab87ca73 fix:add ifr local scheme 
due to iframe security policy and x-frame-option .
the website online dictionary can not work in qt 5.15.2+ version.
this is a workaround to pass through the restriction.
 2022-05-15 22:54:26 +08:00
Xiao YiFang 9c402d986e opt: add dictionary fallback font family settings 2022-05-08 16:44:09 +08:00
xiaoyifang 5a0a6c6491 feature:add ignore punctuaion option 2022-04-23 16:15:23 +08:00
xiaoyifang eaf76fbcb6 clean code:remove useless code 
the maximumwindowssize was only set value in the ~MainWindows() which means
it can not be saved into the config file.
 2022-04-19 22:22:03 +08:00
xiaoyifang 8b9544bc17 fix:currentIndexChanged slot does not match 2022-04-01 23:32:11 +08:00
xiaoyifang 228d7001e5
Merge pull request #35 from ngn999/bugfix/Macbook_scroll_issue 
disable macOS trackpad zoom; fix a deadlock
 2022-03-31 00:10:37 +08:00
ngn999 6d0c7b0fec reindent MainWindow::on_saveArticle_triggered 2022-03-31 00:03:42 +08:00
ngn999 b187c0ef41 fix code review indent issue 2022-03-30 23:08:24 +08:00
xiaoyifang 19e738becc optimize: print preview dialog set zoom factor to 100% 2022-03-30 17:19:08 +08:00
xiaoyifang 88a69d1976 fix:revert deferredInit 2022-03-30 15:34:59 +08:00
xiaoyifang 3ea8fd78ef print preview blurry 2022-03-29 20:47:41 +08:00
ngn999 188f67556c no memory problem 2022-03-28 11:24:27 +08:00
ngn999 748bafd43b fix save file progress dialog never close bug 2022-03-28 11:09:33 +08:00
ngn999 e45f466a9d make toHtml async 2022-03-28 10:30:23 +08:00
ngn999 05bbf54330 rewrite lambda capture list 2022-03-27 23:36:14 +08:00
ngn999 6c310b41af make isFramedArticle async, and remvoe runJavaScriptSync() 2022-03-27 23:05:45 +08:00
ngn999 95be606a9e make ArticleView::hasSound() async 2022-03-27 22:22:42 +08:00
xiaoyifang 9836e8d529 ui: update icon 2022-03-27 18:12:33 +08:00
xiaoyifang c5fae8de1b fix:edit dictionaries 2022-03-22 20:20:48 +08:00
xiaoyifang fa2aae908b toolbar icon size 2022-03-15 22:26:24 +08:00
xiaoyifang 0560785a65 replace dictionary vector with QMap 
remove signal DictGroupWidget::showDictionaryInfo
 2022-03-14 08:22:31 +08:00
xiaoyifang c664ac315c dictionary group ,id match performance improve . 
use qmap to replace the double for loop check.
 2022-03-14 00:17:34 +08:00
xiaoyifang ab1b525f12 printreviewdialog change default printer 2022-03-12 18:31:21 +08:00
xiaoyifang 5d8b410a8b fix: exception with PopupFocusReason 2022-03-11 22:26:38 +08:00
yifang fb2eac9b5e upgrade to 6.2,linux compile 2022-03-11 22:14:40 +08:00
xiaoyifang 23d833fbb8 6.2: currentIndexChanged signal is changed. 2022-03-11 22:00:53 +08:00
xiaoyifang 7b5511a7bd upgrade to qt6.2 2022-03-11 22:00:45 +08:00
xiaoyifang 3a092947da fix:popup javascript windows 2022-03-11 00:41:35 +08:00
yifang 4a96067e86 fix:large memory consumption when edit dictionaries through right menu context 2022-03-03 23:59:42 +08:00
yifang f16b25737d optimize: hide sources when edit dictionaries with specific groupid 2022-03-03 23:45:35 +08:00
yifang 0040724b6f Revert "fix:edit dictionaries dialog ,memory consume too much" 
This reverts commit c9d053d227.
 2022-03-03 23:13:04 +08:00
yifang c9d053d227 fix:edit dictionaries dialog ,memory consume too much 2022-02-28 21:21:34 +08:00
xiaoyifang d607079ffb fix: double click to translation should stop audio first. 
there are cases when the audio is too long (in wiki).
when double click occured .the audio is still playing.
 2022-02-25 23:33:34 +08:00
xiaoyifang 448f8f80a5 clean:remove hotkey dll handler 2022-02-25 23:01:54 +08:00
xiaoyifang 434dbd6e45 fix:Win+Up Win+Down to restore and save geometry 
the above shortkey can not restore geometry after resize the window
clean code .
 2022-02-25 22:54:34 +08:00
xiaoyifang aeee511859 fix:Win+Up Win+Down to restore and save geometry 
the above shortkey can not restore geometry after resize the window
 2022-02-25 22:51:39 +08:00
yifang 7e2231805f optimize: float number compare precision 
optimize: float number compare precision
 2022-02-19 01:08:20 +08:00
yifang 835e376b16 fix: typo 2022-02-18 20:43:07 +08:00
yifang cc9b64876f fix: try to fix macos close to tray issue 
can not be sure .
though the code will have not side effect.
 2022-02-18 20:22:56 +08:00
xiaoyifang 6fbadad807 clean:open dictionary folder in windows 
make windows's logic same as linux
 2022-02-16 23:00:20 +08:00
xiaoyifang 570c75e920 performance: Prefer prefix ++/-- operators for non-primitive types. 
more detail check https://hownot2code.com/2016/06/30/use-a-prefix-increment-operator-i-in-iterators-instead-of-a-postfix-i-operator/
 2022-02-16 22:08:32 +08:00
xiaoyifang 9ecc10ed50 performance: Prefer prefix ++/-- operators for non-primitive types. 
more detail check https://hownot2code.com/2016/06/30/use-a-prefix-increment-operator-i-in-iterators-instead-of-a-postfix-i-operator/
 2022-02-16 21:47:03 +08:00
yifang bd01dad108 clean: Condition '!explorerLaunched' is always true 
fixes #13
 2022-02-16 08:18:14 +08:00
yifang 23c41789de fix: popup link clicked 2022-02-15 20:22:43 +08:00
xiaoyifang 84175279ab fix: link click in popup windows ,translation should be in popup dialog too 2022-02-14 23:48:05 +08:00
xiaoyifang c329430a7b fix:warning qt-style-st-lingoes.css the file was missing 2022-02-13 17:01:17 +03:00
xiaoyifang d167cf1d49 fix:warning qt-style-st-lingoes.css the file was missing 2022-02-13 20:57:39 +08:00
yifang 0b29b65aca add useragent goldendict for compatible reason 2022-02-08 12:59:41 +08:00
xiaoyifang 0c94406e2a fix merge conflict with feature/deprecated 2022-02-03 17:50:47 +08:00
xiaoyifang c96a83f5d2 imp. remove mouseover32 2022-02-03 16:55:10 +08:00
yifang c810b7849d Merge remote-tracking branch 'origin/feature/highdpi-icon' into dev 2022-01-30 09:10:20 +08:00
xiaoyifang 291d6c6804 high dpi:replace menu button 2022-01-29 13:26:25 +08:00
yifang 0eb49e4a6b Merge remote-tracking branch 'origin/feature/highdpi-icon' into branch-qt-5.15 2022-01-28 20:06:25 +08:00
yifang eddc813aef high dpi:replace gnome image icon 2022-01-28 08:30:01 +08:00
yifang f1337862f1 Merge branch 'branch-qt-5.15' into dev 2022-01-27 08:24:21 +08:00
yifang 1d32ec4609 Merge branch 'feature/highdpi-icon' into dev 2022-01-27 08:24:16 +08:00
yifang d38daedc99
high dpi:remove coresponding png files with same name with svg 
close https://github.com/goldendict/goldendict/issues/1441
 2022-01-27 08:23:57 +08:00
yifang 2e5ca5f70f
fix:print preview resolution is too low 2022-01-27 00:47:27 +08:00
yifang e0e03cc6af Merge branch 'feature/highdpi-icon' into dev 2022-01-26 23:57:51 +08:00
yifang df6f51c011
high dpi: change right context menu on tab ,'close current tab' icon 2022-01-26 07:36:14 +08:00
xiaoyifang 5f184a8b3c Merge branch 'feature/highdpi-icon' into dev 2022-01-25 23:58:14 +08:00
xiaoyifang 9c5d7acc5a high dpi:change icon 2022-01-25 22:54:17 +08:00
xiaoyifang aa12bbe167 Merge branch 'branch-qt-5.15' into dev 2022-01-24 22:27:04 +08:00
xiaoyifang 23e148a345 Merge branch 'feature/highdpi-icon' into dev 2022-01-24 22:26:00 +08:00
xiaoyifang 9cf5ee8443 high dpi:change icon reference in code from png to svg. 2022-01-24 22:23:38 +08:00
yifang a0014cf668
dictionary bar icon size does not display correctly 2022-01-23 19:41:50 +08:00
xiaoyifang d310ee849a fix: click in dictionary panel not working . 2022-01-23 14:19:20 +08:00
yifang 5c76bc746c fix:right context menu ,select current article 2022-01-19 20:16:45 +08:00
xiaoyifang 4e7fe7dd6d improvement: make tab title does not show url . 2022-01-18 22:26:52 +08:00
yifang 0ba2cacc29
improvement:remove gdCurrentArticle js variable 2022-01-17 21:50:54 +08:00
yifang 63626bde13 improvement: refactor code,move ignoreKeyEvent method to utils. 2022-01-14 22:58:19 +08:00
yifang 9a4b119976 improvement:refactor code ,ignore key event extract to method 2022-01-13 20:39:58 +08:00
xiaoyifang 13fdf08450 improve:foundDictsPane refresh logic 2022-01-09 12:54:50 +08:00
xiaoyifang bd6cc8b9c9 fix: resource scheme handler received finished signal twice,more likely to crash the webengine. 2022-01-09 09:52:40 +08:00
xiaoyifang 3b4c105655 improve:Win Specific, replace deprecated method 2022-01-08 22:26:21 +08:00
yifang 46b4151cc4 improve: replace all the deprecated method before 5.15 2022-01-08 22:08:23 +08:00
yifang 8fc762a57b fix:add "gdprg","gdvideo","gdpicture","gdtts" scheme 2021-12-31 23:48:21 +08:00
xiaoyifang 0ed7c1cc1d
Merge branch 'goldendict:master' into branch-qt-5.15 2021-12-31 09:31:29 +08:00
yifang 3ebe5c9b23 fix: translateLine text disappeared after main windows hide and show up again. 2021-12-30 21:19:50 +08:00
yifang a1c0cfa042 single click to open external link in external browser 2021-12-29 23:28:26 +08:00
yifang 09063ecc5a clean code: 
QString::SkipEmptyParts=>Qt::SkipEmptyParts
 2021-12-29 22:29:06 +08:00
yifang e7218fc12b open link content duplicated in all the tabs. 2021-12-28 21:49:32 +08:00
yifang 5860e81ff3 typingEvent fix,double characters when focus 2021-12-18 18:08:45 +08:00
yifang de3d7b8b19 clean code:remove QT_VERSION check 2021-12-16 19:59:00 +08:00
xiaoyifang e04aa50a99 fix issue mentioned in https://github.com/goldendict/goldendict/issues/1393#issuecomment-993716654 2021-12-15 23:43:03 +08:00
xiaoyifang cb5ac438fe bword link in Hunspell dictionary. 2021-12-13 22:46:02 +08:00
yifang 98ca729446 remove qt_version_check macro 2021-12-13 22:45:57 +08:00
xiaoyifang 303179b410 clean code: 
remove qt version check
save geometry
 2021-12-13 22:45:35 +08:00
xiaoyifang 5eac08c97a rename qt4x5.hh to utils.hh 
the filename qt4x5 is not proper now,for the qt4 version can never meet.and the qt5 is actually mean qt>5 .
 2021-12-13 22:45:35 +08:00
yifang.xiao 0365015ac6 clean code: 
remove "#if QT_VERSION >= QT_VERSION_CHECK( 5, 0, 0 )" check ,the check should always be true based on current situation.
 2021-12-13 22:45:33 +08:00
yifang.xiao ab358fb3a5 remove old qt(<5) code. 2021-12-13 22:43:43 +08:00
Igor Kushnir 8260ac87ba Linux-specific: Don't ignore main window close event 
If GoldenDict's option "Close to system tray" is checked and
GoldenDict's main window is visible when the user logs out, the logout
is canceled in latest stable versions of KDE Plasma and Xfce desktop
environments (probably in other GNU/Linux desktop environments too, but
they weren't tested). The cause of this unintended and pointless logout
cancellation is ignoring the close event.

Close events are accepted by default. main() calls
`app.setQuitOnLastWindowClosed( false );`. Thus, if the close event is
not touched, the main window is hidden as before this change.
GoldenDict's configuration, history and favorites are still committed
and saved in both KDE Plasma and Xfce when logging out first
closes/hides the main window, then quits GoldenDict.

The change is limited to GNU/Linux because @Abs62 pointed out that
closing the main window breaks global hotkeys on Windows. I have
verified that closing the main window does not break global hotkeys on
GNU/Linux with Qt5 or Qt4. No one has volunteered to test whether the
change is needed on macOS, so it is safer not to apply it there.

Closes #1421.
 2021-11-29 11:25:39 +02:00
xiaoyifang 9857ed0559 use char32_t as the inner string unit. 2021-10-20 23:02:37 +08:00
xiaoyifang bdb9561ec9 rename scheme handler 2021-10-02 20:48:49 +08:00