Commit graph

4014 commits

Author SHA1 Message Date
Xiao YiFang c478065f53 goldendict ,fix QT_PLUGIN_PATH variable 2022-11-05 14:52:50 +08:00
xiaoyifang 652f1b25d3
Update README.md 2022-11-05 10:46:52 +08:00
xiaoyifang 08ca40bd06
Update README.md 2022-11-05 10:44:28 +08:00
Xiao YiFang f486cd8a69 Merge remote-tracking branch 'gd/master' into staged 2022-11-05 10:01:00 +08:00
Xiao YiFang 450115c108 Merge commit '1d6b5efe' into staged 2022-11-05 10:00:52 +08:00
Xiao YiFang cbf62a4dbe Merge commit '98b37fea' into staged 2022-11-05 10:00:44 +08:00
Igor Kushnir fc9a48a113 Demote missing favorites file message from warning to debug
This file is never created if the Favorites feature is not used.

Fix a typo along the way: "favorities" => "favorites".
2022-11-04 21:03:48 +03:00
Igor Kushnir 1d6b5efeac Disable GD_DPRINTF() output in Release builds on all systems
Messages printed with GD_DPRINTF() are clearly debug messages. They
flood GoldenDict's output with lines like these:
    some body finished
    one finished.
    erasing..
    erase done..
    one not finished.
    ====reading 16384 bytes

Messages printed to stderr with GD_FDPRINTF() are more important and
less frequent => leave them in Release builds.
2022-11-04 21:01:52 +03:00
Igor Kushnir 98b37feac2 Print debug output with gdDebug() instead of av_log()
Users can enable or disable av_log() output only by inserting a call to
av_log_set_level() and recompiling GoldenDict. Blink browser engine
shipped with Qt WebEngine sets the log level to AV_LOG_QUIET in
chromium/media/base/media.cc and thus disables all output. So
GoldenDict's custom AV_LOG_INFO messages are always printed in the Qt
WebKit version and never in the Qt WebEngine version.

In contrast, users have many ways to enable or disable QDebug output
without recompilation since Qt 5. Furthermore, GoldenDict's command line
option --log-to-file allows to redirect gdDebug() output to a log file.

The two messages printed via av_log() are clearly debug messages,
because they are printed each time a word or a phrase is pronounced.
2022-11-04 19:52:39 +03:00
Xiao YiFang 6d9a6c3d6b fix:return directly when the searched word is empty 2022-11-04 21:25:55 +08:00
Xiao YiFang 208cd50979 fix: when history forward/back ,the founded dictionary does not change
fixed #184
2022-11-04 21:23:42 +08:00
Xiao YiFang c8f445f165 Merge remote-tracking branch 'gd/master' into staged 2022-11-04 20:44:11 +08:00
Igor Kushnir a27a29aca3 Linux-specific: don't open File menu after showing main window
Unfortunately the X11 focus workaround that opens the File menu cannot
be simply removed. Without this workaround, when KDE Plasma's Focus
stealing prevention level is set to Low (which is the default) or
higher, launching a second GoldenDict instance doesn't give focus to the
already running instance unless that instance's main window is currently
hidden into system tray or minimized. A workaround of hiding then
showing the main window makes the window flicker. Suggesting GoldenDict
users to set the focus stealing prevention level to None is not right,
because this setting is global and affects all applications.

Emulate a left mouse button click at position (0, 0) instead of (1, 1)
in order to waste 1 rather than 2 pixels to the left of the menu bar.

Introduce a new macro X11_MAIN_WINDOW_FOCUS_WORKAROUNDS to link the X11
focus workaround to the File menu workaround introduced in this commit.
This simplifies disabling all related workarounds at once. When the
focus workaround is replaced with a proper solution, the developer won't
forget to remove all obsolete workarounds if they are linked together.

Fixes #781.
2022-11-03 19:25:32 +03:00
Igor Kushnir 6dc74a7c7b Assign correct values to XButtonEvent::[xy]_root
The signature is: QPoint QWidget::mapToGlobal(const QPoint &) const;
2022-11-03 19:25:32 +03:00
Igor Kushnir 307fe2ba16 Download and open an image double-clicked in scan popup
Now double-clicking an image has the same effect in the main window and
in the scan popup. This consistency in no way prevents or hinders using
the popup window as designed (for fast lookup in a small group of
dictionaries), because a user is unlikely to double-click an image
accidentally.

Without this commit, when "Double-click translates the word clicked"
option is on, double-clicking an image in the scan popup translates
currently selected text if the selection is not empty.

Fixes #1279.
2022-11-02 22:22:59 +03:00
Igor Kushnir cf84f57632 Don't append duplicates to openedInspectors
There is no benefit in storing the same pointer multiple times in
openedInspectors. This occurred when an article inspector window was
closed then shown again. When the tab corresponding to the duplicated
article inspector pointer was closed, ArticleInspector::beforeClosed()
erased only one pointer from openedInspectors. This left dangling
duplicate pointer(s) in the list and eventually caused a crash when
another inspector's showEvent() accessed a dangling pointer at
openedInspectors.front().
2022-11-02 22:22:16 +03:00
Igor Kushnir 9330c89e4b Don't attempt to translate empty or whitespace-only text
Silently ignore empty or whitespace-only translation requests. It should
be clear to most users why GoldenDict ignores them.

The translated word ends up as the "word" URL query item value, which is
trimmed in ArticleNetworkAccessManager::getResource(). So the added
trimming in MainWindow::translateInputFinished() should be fine.

When a trimmed translated word was empty, InputPhrase::isValid()
returned false, ArticleNetworkAccessManager::getResource() returned a
null pointer and ArticleNetworkAccessManager::createRequest() fell back
to QNetworkAccessManager::createRequest(), which:
* failed silently in the Qt 4 version;
* displayed the
    Protocol "gdlookup" is unknown
    Failed to load URL gdlookup://localhost?word= &group=4.
    QtNetwork Error 301
error page in the Qt 5 version.

Fixes #1179.
2022-11-02 19:16:33 +03:00
Igor Kushnir c7c8b6f632 git clone URL in README: git:// => https:// scheme
An attempt to clone the git:// URL fails on my Manjaro GNU/Linux system
and produces the following output:
    $ git clone git://github.com/goldendict/goldendict.git
    Cloning into 'goldendict'...
    fatal: unable to connect to github.com:
    github.com[0: 140.82.121.4]: errno=Connection timed out

    128✗

The GitHub UI offers the replacement https:// URL when the green Code
button in the GoldenDict repository is clicked.

Fixes #1561.
2022-11-02 18:05:24 +03:00
Xiao YiFang 59ec8c4a48 [clean code]: remove macos lionsupport check
this macos version is too old .
2022-11-02 20:42:39 +08:00
Xiao YiFang 10972abcf4 [clean] remove code in dictionarybar eventfilter 2022-11-01 20:21:30 +08:00
xiaoyifang e66380763f Revert "fix possible crash in archlinux"
This reverts commit 9719091776.

Revert "fix crash on archlinux"

This reverts commit 0dc2b4d416.
2022-11-01 17:40:20 +08:00
xiaoyifang 35141a5334
Merge pull request #182 from xiaoyifang/opt/clang-format-new
clang format style changes
2022-10-30 17:56:26 +08:00
Xiao YiFang 988951aa6c [reg]: unicode-bidi cause the welcome title aligned left 2022-10-29 13:23:17 +08:00
Xiao YiFang afdaf19ef9 [action] disable macos6.4.0 homebrew action 2022-10-28 19:46:26 +08:00
xiaoyifang a24a0a713f change msvc lib readme 2022-10-28 14:34:09 +08:00
xiaoyifang f503fe586b add new clang format style 2022-10-28 10:51:18 +08:00
xiaoyifang 83ae19e7eb
Merge pull request #181 from xiaoyifang/feature/ubuntu6.2
linux appimage build with qt6.x
2022-10-28 07:39:07 +08:00
Xiao YiFang b23e57d08c fix:rtl display in Arabic/Persian language
fix goldendict#1565
2022-10-27 21:30:06 +08:00
Xiao YiFang 286c3682ec linux appimage build with qt6.x 2022-10-27 17:12:14 +08:00
Xiao YiFang 408f994779 revert gico format from webp to png 2022-10-26 21:00:04 +08:00
xiaoyifang 9719091776 fix possible crash in archlinux 2022-10-26 16:17:28 +08:00
Xiao YiFang 6d8779442c change qt version to qt6.3.2
qt6.4.0 is buggy
2022-10-25 19:46:07 +08:00
Xiao YiFang 6742321aa1 add xapian to the about dialog 2022-10-24 20:14:53 +08:00
Xiao YiFang 0dc2b4d416 fix crash on archlinux
I guess the issue #173 may be  rooted in here
2022-10-22 19:27:43 +08:00
Xiao YiFang 7adfc523a2 clear dictionary outside of the loop 2022-10-22 19:12:55 +08:00
Xiao YiFang c743a31dca fix: windeployqt bug 2022-10-22 14:53:14 +08:00
Xiao YiFang f8f42092d3 fix:remove comment 2022-10-22 13:43:53 +08:00
Xiao YiFang fcaa00c5c2 opt: debug log 2022-10-22 13:42:17 +08:00
Xiao YiFang 3561f80430 [mac specific] popup dialog stay on top 2022-10-19 20:28:41 +08:00
Xiao YiFang 02445aafa1 Revert "[mac specific]:update ffmpeg package"
This reverts commit d97e062772.
2022-10-16 17:32:39 +08:00
Xiao YiFang e8412eb820 opt: new release check logic changed to this very repository. 2022-10-15 17:28:55 +08:00
Xiao YiFang 4eedefc585 opt: function refract 2022-10-15 13:58:24 +08:00
xiaoyifang 2619e7be97
Merge pull request #167 from xiaoyifang/fix/f12-crash-2
inspect element crash on the first time
2022-10-14 14:15:38 +08:00
Xiao YiFang ead9e6132f inspect element crash on the first time 2022-10-14 10:52:09 +08:00
xiaoyifang e4a083cccc
Update windows-publish.ps1 2022-10-14 10:47:30 +08:00
Xiao YiFang 1077ccb82b [github] bump qt version to 6.4.0 2022-10-13 20:17:24 +08:00
xiaoyifang 145a1d39a8
Update README.md 2022-10-13 09:39:06 +08:00
xiaoyifang 1da84b315d
Update README.md 2022-10-13 09:26:20 +08:00
Xiao YiFang bd5a765a37 [Win Specific] update dependency build instructions on Windows 2022-10-12 21:08:24 +08:00
xiaoyifang 9f7570b560
Merge pull request #166 from xiaoyifang/tmp/ffmpeg
[mac] add macos speex support
2022-10-12 20:56:20 +08:00