Commit graph

366 commits

Author SHA1 Message Date
shenleban tongying a11c9e3aec clean: mass apply clang-tidy's readability-braces-around-statements 2024-10-10 03:21:27 -04:00
shenleban tongying da34da69b6
clean: delete or rewrite weird things in history.cc (#1815) 2024-10-10 07:00:13 +00:00
shenleban tongying 3c2e36d040 delete MainWindow::fillWordListFromHistory which is unused 2024-10-10 00:03:14 -04:00
xiaoyifang d5037ded24
feature: rename the [Enable Scanning] to a more accurate tooltip (#1810)
Some checks failed
SonarCloud / Build and analyze (push) Waiting to run
deploy_website / deploy (push) Has been cancelled
* feature: rename the [Enable Scanning] to a more accurate tooltip

* change [Scan Popup] to popup

* i18n: [scan popup] to popup in ts files

* update popup related strings

* Update popup doc

* update popup doc 2

* Update ui_popup.md

* -t popup explanation in command line

---------

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2024-10-10 02:19:33 +00:00
shenleban tongying 7f497b0cdf fix: set scanPopup flags to what's is needed instead of Qt::Popup
Some checks failed
SonarCloud / Build and analyze (push) Has been cancelled
2024-10-07 06:25:53 -04:00
shenleban tongying 90d55d7392 clean: deprecated QVariant::type 2024-10-06 17:24:36 -04:00
shenleban tongying 96ada0737c
clean: purge undocumented and useless editDictionaryCommandLine (#1794)
Some checks failed
SonarCloud / Build and analyze (push) Has been cancelled
2024-09-30 20:02:20 -04:00
Konstantin 4a0124de3b
feature: add Large toolbar icons support (#1789)
Some checks are pending
SonarCloud / Build and analyze (push) Waiting to run
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
Co-authored-by: hashirama <noroi_harau@tutanota.com>
2024-09-30 04:36:27 +00:00
Xiao Yi Fang 0bf8a4a3fd opt: some entries do not need to be translated
Some checks failed
SonarCloud / Build and analyze (push) Waiting to run
deploy_website / deploy (push) Has been cancelled
2024-09-11 20:54:12 -04:00
shenleban tongying 5e62b1c567
fix: consider devicePixelRatio when scaling icons (#1751) 2024-09-09 20:19:56 +00:00
Konstantin aaaeb585b6
feature: High-quality dictionary icons in toolbar (#1750)
* better procedure of image scaling and size choosing
* allow user to set toolbar icon size via qt style sheet

---------

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-09 14:48:33 -04:00
shenleban tongying 3273f39dd7 clean: replace removed Qt5/QList and QPair 2024-09-01 19:45:06 -04:00
Xiao Yi Fang 51701ce4aa opt: double click in welcome page 2024-08-20 10:48:31 +08:00
Xiao Yi Fang dc4647069d opt: webview history navigation 2024-08-12 16:53:47 +08:00
xiaoyifang 3279fe8b07
opt: fulltext next navigation optimization (#1718)
* opt: fulltext dialog navigation optimization.

The fulltext dialog navigation (next,previous) use webview's findText,try to find the longest word for navigation
2024-08-09 11:47:46 +08:00
xiaoyifang b0bea92106
opt: remove outdated fulltext temp index (#1717)
* opt: remove outdated fulltext temp index

* opt: remove outdated fulltext temp index
2024-08-09 09:37:57 +08:00
Xiao Yi Fang ec63fa550d fix: popup dialog , switch groups should use articleview's word 2024-08-08 17:47:40 +08:00
Xiao Yi Fang b8f49ec3dc opt:mark.js only highlight exact words 2024-08-06 10:34:02 +08:00
xiaoyifang cd58059695
fix:QCheckBox signal (#1705)
* fix:QCheckBox signal

* fix:QCheckBox signal
2024-07-23 17:57:57 +08:00
xiaoyifang 06d4b62b67
opt: findtext casesensitivity (#1698)
* opt: reset the selection results

* opt: remove the existed highlight when no match

* [autofix.ci] apply automated fixes

* opt: remove the existed highlight when no match

* opt: remove the existed highlight when no match

* opt: code minor optimization

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-18 13:33:49 +08:00
xiaoyifang 521c359b24
opt: do not need to reload webview when initialize dictionaries (#1690)
* opt: do not need to reload webview when initialize dictionaries

During this phase ,the webview has not existed yet
2024-07-17 00:38:27 +00:00
xiaoyifang 029c09633b
Merge pull request #1667 from xiaoyifang/opt/zoomfactor-range
opt: valid zoomfactor range from 0.25 to 5
2024-07-10 18:02:59 +08:00
xiaoyifang dfbdb7cb5f
Merge pull request #1668 from xiaoyifang/opt/remove-xapian-enable-position-option
opt: remove unused option
2024-07-10 18:02:08 +08:00
Xiao Yi Fang 3a0311ad7d opt: remove unused option 2024-07-10 17:27:29 +08:00
Xiao Yi Fang d2f82e9350 opt: valid zoomfactor range from 0.25 to 5 2024-07-10 17:13:12 +08:00
xiaoyifang 0c4483ae02
Revert "opt: remove wasMaximized logic of mainwindow" (#1664)
* Revert "opt: remove wasMaximized logic of mainwindow"

This reverts commit 99c221c854.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-10 16:28:28 +08:00
xiaoyifang 7669316bcd
opt: do not show dictionary menu when set the dictionary count=0 (#1652)
* opt: do not show dictionary menu when set the dictionary count=0

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-08 17:51:51 +08:00
xiaoyifang c4fa9b44e5
fix: set shortcut context (#1644)
* fix: work around to fix ctrl+F in macos popup
2024-07-06 21:57:18 +08:00
xiaoyifang 5780bdbbb1
fix: status bar position (#1643)
* fix: statusbar rarely will be blocked by the webview.
---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-06 13:23:22 +08:00
xiaoyifang 297795a654
fix: refresh webview when changed darkreader mode (#1641)
* fix: refresh webview when changed darkreader mode

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-05 10:55:08 +08:00
xiaoyifang 922b7c39c6
opt: popup focus (#1635)
* opt: windows title

* opt: popup focus

* opt: windows title

* [autofix.ci] apply automated fixes

* opt: popup articleview setting

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-05 08:44:36 +08:00
xiaoyifang 7252e7b86e
fix: darkreader mode refresh (#1638)
* fix: refresh webview when changed darkreader mode
2024-07-05 08:44:03 +08:00
xiaoyifang 932b88f743
opt: dictionarygroup refactor in articleview (#1625)
* opt: refactor dictionary logic to seperate class


---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-03 15:16:53 +08:00
Xiao Yi Fang b0fb5d2f87 remove debug log 2024-07-03 11:29:29 +08:00
Xiao Yi Fang 89daa70b6b Revert "clean: remove useless code and refactor"
This reverts commit 3a46dd290b.

the changes is not exactly the same.
close the last tab will cause the windows to create a new blank tab which will fall into infinite loop
2024-07-03 11:29:29 +08:00
xiaoyifang ddb9203e34
fix: full text search navigation panel (#1623)
* fix: full text search navigation panel

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-07-01 22:51:57 +08:00
xiaoyifang d30de48fa8
opt: suppress url title (#1619)
* opt: suppress url title

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-06-27 18:01:15 +08:00
xiaoyifang 585866f92a
fix: fts search ,highlight mark (#1621)
* fix:mark the searched terms

* fix:mark the searched terms

* fix:mark the searched terms
2024-06-27 18:00:06 +08:00
xiaoyifang 15cb327bbd
opt: rewrite keymodifier (#1614)
* opt: rewrite keyboardstate.cc


---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-06-26 15:58:42 +08:00
xiaoyifang c4caec7d68
opt: headwords dialog (#1600)
* opt: headword dialog optimization

Changes:

- when the headword count < 500000(arbitrary number) ,load all at once.
- opt: remove unused signal
-  headword dialog ui add max filter results


---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-06-25 15:24:33 +08:00
YiFang Xiao 2b9d17251b fix: articleview mainwindow ,fulltextsearch remove QRegExp 2024-06-23 12:47:41 +08:00
YiFang Xiao 76f9e82a31 fix: dictheadword remove QRegExp 2024-06-23 12:47:41 +08:00
Xiao Yi Fang a33dbc422e opt: remove webkit specific code 2024-06-21 10:00:52 +08:00
YiFang Xiao 0a8ff8b27b fix: Ctrl+F does not work in scanpopup dialog 2024-06-20 21:27:03 +08:00
shenleban tongying 5c9f67b09c
opt: port away QRegExp in langcoder.cc 2024-06-19 02:10:17 -04:00
shenleban tongying 3a0880fa81 clean: rename LangCoder::findIdsForFilename/findIdsForName/exists 2024-06-18 21:19:18 -04:00
YiFang Xiao 99c221c854 opt: remove wasMaximized logic of mainwindow 2024-06-15 23:09:35 +08:00
xiaoyifang 296251afad
fix: links in webview got focused on default. (#1589)
* fix: links in webview got focused on default.

fix #1581

* fix: links in webview got focused on default.

fix #1581
2024-06-15 21:20:23 +08:00
xiaoyifang ed680f54b3
Merge pull request #1578 from xiaoyifang/opt/page-search-remove-highlight
opt: Ctrl+F page search remove highlight checkbox
2024-06-15 21:19:48 +08:00
xiaoyifang 96f5686173
Merge pull request #1582 from xiaoyifang/opt/activate-windows
opt: remove deprecated method setActiveWindow()
2024-06-15 21:19:30 +08:00
xiaoyifang ac8c459e01
Merge pull request #1583 from xiaoyifang/opt/clang-tidy-issues
opt: clean clang tidy issues
2024-06-14 22:53:26 +08:00
YiFang Xiao fb0023abfc opt: clean clang tidy issues 2024-06-14 22:05:14 +08:00
YiFang Xiao 6848ebfe45 opt: remove deprecated method setActivateWindow() 2024-06-14 21:48:29 +08:00
YiFang Xiao 710c07f05f fix: auto pronounce audio does not play 2024-06-14 21:38:51 +08:00
YiFang Xiao 1374905b30 opt: searchPanel hide at start 2024-06-14 20:20:02 +08:00
Xiao Yi Fang 3478c2fe1f opt: fts search dialog does not use caseSensitive option currently 2024-06-14 17:38:46 +08:00
Xiao Yi Fang 585d547d28 opt: erase the need to use extra variable to hold the ftsSearchPanel state 2024-06-14 17:36:05 +08:00
Xiao Yi Fang 39b207fa78 opt: erase the need to use extra variable to hold the searchPanel state 2024-06-14 17:32:16 +08:00
Xiao Yi Fang 3b2de95ff7 opt: remove Control property [noResult] 2024-06-14 17:12:43 +08:00
Xiao Yi Fang 642f3c6ac8 opt: string empty check 2024-06-14 17:03:24 +08:00
Xiao Yi Fang d9b9493b2f opt: remove useless paramater [restart] 2024-06-14 16:52:13 +08:00
Xiao Yi Fang 0f3ce0ec4d opt: remove fts search related selected text 2024-06-14 16:44:51 +08:00
Xiao Yi Fang 4bb4ff38c9 opt: Ctrl+F page search remove highlight checkbox 2024-06-14 16:33:39 +08:00
Xiao Yi Fang 9141a8f780 opt: remove currentGroup qt style property 2024-06-14 08:31:02 +08:00
YiFang Xiao 70d31a8f4b opt: tab icon change logic rewrite
fix #1554
2024-06-13 16:51:03 +08:00
Xiao Yi Fang 3a46dd290b clean: remove useless code and refactor 2024-06-13 08:53:02 +08:00
YiFang Xiao 14e2f8661d fix: Scrollbar does not remember position
fix #1555
2024-06-12 22:20:41 +08:00
xiaoyifang 9f09b55327
Merge pull request #1558 from xiaoyifang/opt/tab-position
fix: when tab changes ,the tab page position reset to the start
2024-06-12 20:12:24 +08:00
xiaoyifang 7bbab2a759
Merge pull request #1559 from xiaoyifang/opt/articleview-group
opt: remove the argument which pass the GroupComboBox to the ArticleV…
2024-06-12 20:11:45 +08:00
xiaoyifang 26bdf52c5e
Update src/ui/articleview.cc
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2024-06-12 13:35:19 +08:00
xiaoyifang 998a97a031
Update src/ui/articleview.cc
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2024-06-12 13:35:02 +08:00
Xiao Yi Fang 0b5e2f140d code smell: remove warning 2024-06-12 10:13:29 +08:00
autofix-ci[bot] 5cdd5f6e2a
[autofix.ci] apply automated fixes 2024-06-12 01:34:42 +00:00
Xiao Yi Fang 93b0da83fc opt: remove the argument which pass the GroupComboBox to the ArticleView class 2024-06-12 09:32:04 +08:00
YiFang Xiao 0c6d6f6c25 fix: when tab changes ,the tab page position reset to the start 2024-06-12 08:28:25 +08:00
shenleban tongying 05d9a398a0
fix: tray icon <-> toggleMainWindow connected twice (#1535) 2024-05-27 23:06:58 -04:00
shenleban tongying e7c59679ce
fix: disable Qt6.7's dark mode and force Fusion style no matter what (#1512) 2024-05-13 09:22:57 -04:00
shenleban tongying 3187fdeb64 clean: utilize QSaveFile and improve config/favorite/history file saving 2024-03-25 21:46:17 -04:00
shenleban tongying 57a5c52620 clean: remove unnecessary passing of openSearchAction to ArticleView's ctor 2024-03-21 19:09:05 -04:00
xiaoyifang 728fa4850c
Merge pull request #1425 from shenlebantongying/fix/mac-open-in-systemviewer
fix: "Open Image in System Viewer" doesn't work on macOS
2024-03-20 13:19:03 +08:00
shenleban tongying 0b61888bc7 fix: Open Image in System Viewer doesn't work on macOS 2024-03-20 00:46:40 -04:00
shenleban tongying 483381414f
clean: remove macOS unused code related to gestures (#1421)
* clean: remove macOS unused code related to gestures

We prefer native gestures and disabled gesture.cc long time ago, those are unused

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-03-20 11:11:35 +08:00
shenleban tongying b9e14f806c
fix: CMake problems found by the openBSD package (#1422)
* fix: CMake problems found by openBSD package

* remove unused WITH_XAPIAN option
* don't link Qt TTS if not requested

* fix: address CMake problems found by openBSD package

* remove unused WITH_XAPIAN option
* don't link Qt TTS if not requested
* Disable some code when TTS is not requested

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-03-20 11:08:17 +08:00
shenleban tongying dd95690940
clean: simplify tabbar double click detect via qt's built-in methods (#1419)
* clean: simplify tabbar double click detect via qt's built-in methods

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-03-18 17:45:06 +08:00
shenleban tongying 32391bda43
fix: reduce darkreader mode white flash further by using QWebEnginePage::setBackgroundColor() (for Qt6.6.3+) (#1406)
* fix: reduce darkreader mode white flash further by using
QWebEnginePage::setBackgroundColor() (for Qt6.6.3+)

In previous Qt6.x versions, this function only set background once and
become invalidated if reload a page.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-02-27 18:07:00 +08:00
xiaoyifang 69191e4387
Merge pull request #1386 from xiaoyifang/fix/addon-style
fix: possible crash on macos
2024-01-27 10:34:28 +08:00
YiFang Xiao 54808cd03f fix: ctrl+v in Welcome page will result a wrong search 2024-01-26 16:52:27 +08:00
YiFang Xiao 0596ed5e45 opt: remove debug info 2024-01-26 15:50:01 +08:00
YiFang Xiao e312545204 fix: possible crash on macos 2024-01-24 22:55:34 +08:00
xiaoyifang c15cbbf607
opt: support UP/Down arrow key in headword UI (#1358)
* opt:refactor the code

* opt: headwords dialog response to the Up/Down Key

* opt: when the headword come from headword dialog ,not focus

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-01-22 17:04:30 +08:00
YiFang Xiao 97e495613b fix: auto audio pronunciation does not work properly 2024-01-21 13:48:07 +08:00
xiaoyifang a06a372314
Merge pull request #1371 from xiaoyifang/fix/group-crash
fix: groups widget crash on macos occasionly
2024-01-21 12:53:24 +08:00
YiFang Xiao 3e87990ec5 fix: groups widget crash on macos occasionly 2024-01-21 12:42:34 +08:00
YiFang Xiao 85ac0b0e60 opt: refactor the code 2024-01-20 11:19:35 +08:00
YiFang Xiao 11af19de3b fix: critial error throw. 2024-01-10 09:57:31 +08:00
xiaoyifang 804aa29788
Merge pull request #1356 from xiaoyifang/fix/middle-button
fix: middle button does not work
2024-01-04 20:39:56 +08:00
YiFang Xiao c2a6b9b7d9 fix: validate the dictionary when push it into the variable 2024-01-04 20:23:05 +08:00
YiFang Xiao 7420944b9d fix: middle button does not work 2024-01-04 20:17:51 +08:00
xiaoyifang fc62d115f3
Merge pull request #1311 from xiaoyifang/opt/highlight-term
opt: mark exact word
2023-12-06 15:23:30 +08:00
YiFang Xiao 923a46217b opt: mark exact word 2023-12-06 14:29:59 +08:00