Commit graph

4140 commits

Author SHA1 Message Date
shenleban tongying f22769c73b Fix translations accidentally install at /local 2022-11-21 00:14:53 -05:00
xiaoyifang 75a83b0f81
Merge pull request #207 from shenlebantongying/fix-popup
Overhaul ScanPopup
2022-11-20 19:42:23 +08:00
shenleban tongying 664a1e87e4 Remove ScanPopup Alt mode ("Keys may also be pressed afterwards").
The functionality of "select then press a key to get popup " has equivalent of using Ctrl+C+C on Hotkeys.
2022-11-20 04:12:58 -05:00
shenlebantongying 451fdb5c21 Fix win build with HAVE_X11 2022-11-20 01:51:23 -05:00
shenleban tongying 6e0a6cfa42 refactor & simplify ScanFlag:
All slots of ScanFlag are used just as functions calls.
2022-11-20 01:19:27 -05:00
shenleban tongying 79f8b05d40 Add showScanFlag condition to mainWindow's clipboardChange 2022-11-20 00:39:41 -05:00
shenleban tongying c2cc848cc7 remove forcePopup from showScanFlag signal
That flag isn't use in any of the slots
2022-11-20 00:14:36 -05:00
shenleban tongying 4dc040f11c Remove clipboardChanged connect in scanpopup.cc blindly 2022-11-20 00:02:12 -05:00
shenlebantongying e0c193bcb6 Let scanPopup always constructed
Before: Construst Scanpopup only when both enableClipboardHotkey and enableScanPopup are true

Now: Always construct ScanPopup so that users can freely enable Copy->ScanPopup through navbar or tray
2022-11-19 22:35:06 -05:00
shenlebantongying 8232bc208d scan popup: Fix windows build 2022-11-19 21:54:22 -05:00
shenleban tongying 0d186dc33d fix: modifier keys should only affect Selection 2022-11-19 21:15:23 -05:00
shenleban tongying 06a296c99f Put conditions on the ClipboardChange for X11 2022-11-19 13:48:26 -05:00
shenleban tongying e6b9810cc7 Group Selection related Settings together 2022-11-19 12:28:11 -05:00
shenleban tongying a4359bef3c Only process clipboard change when scanning enabled 2022-11-19 12:08:57 -05:00
shenleban tongying 20b435053f X11: Add two Preferences to optional tracking clipboard or selection tracking 2022-11-19 11:35:25 -05:00
shenleban tongying 9d9ad3ecc9 rename enableScanPopupAction to enableScanningAction which now governs both popup and sendToMainWindow kinds of scanning 2022-11-19 10:40:57 -05:00
shenleban tongying b3b740854a Unify trackClipboardChanges and enableScanPopupAction
* There is no difference between those two on Windows and MacOS which only support clipboard (Ctrl+C) scanning

* Q_WS_X11 was defined on Qt4, and it causes the super weird trackClipboardChanges to occur on Windows
2022-11-19 10:30:31 -05:00
shenleban tongying aa3778bb64 Remove enableScanPopup: Complete. Remove from config file and ui file
At here, all code working exactly same as before
The only change is that ScanPopup always enabled for all users
2022-11-19 09:50:20 -05:00
shenleban tongying eb5806503a Remove enableScanPopup: Respect navBar toggling more
* Always construct Scan Popup object regardless of the setting
2022-11-19 09:30:58 -05:00
shenleban tongying edbc4d32cd Remove enableScanPopup: Let Scan popup's 💡 on navBar always visible 2022-11-19 09:25:53 -05:00
shenleban tongying 92bdec7119 Rename QAction * enableScanPopup
There is a var named exactly the same used in the same file!
2022-11-19 09:04:04 -05:00
Xiao YiFang dc29111e88 [win] remove multimedia plugin manual copy. qt6.4.1 has fixed this qt6.4.0 bug 2022-11-19 20:19:47 +08:00
Xiao YiFang 2b614d53ee [mac] add ffmpeg build script 2022-11-19 20:14:45 +08:00
Xiao YiFang aec6cf7c5a add zh_CN translation of About dialog 2022-11-19 19:31:10 +08:00
xiaoyifang 892dab0410
Merge pull request #205 from shenlebantongying/staged
Add two basic "copy info" buttons to about dialog for easier bug reporting
2022-11-19 18:53:37 +08:00
shenleban tongying c08d584233 About copy version info: fix styles 2022-11-19 05:17:34 -05:00
xiaoyifang 276056c9e1
Merge pull request #206 from xiaoyifang/fix/zim
fix: zim dictionary auto refresh logic
2022-11-19 17:46:46 +08:00
Xiao YiFang c75c9cc74b zim: move regex to globalregex 2022-11-19 16:39:41 +08:00
Xiao YiFang 9f6ed1eec2 zim img src link replace regex changes 2022-11-19 16:23:43 +08:00
shenlebantongying b7e1648356
Merge branch 'xiaoyifang:staged' into staged 2022-11-19 03:20:16 -05:00
Xiao YiFang f730a4aabc fix: zim dictionary auto refresh logic
fix <meta http-equiv="Refresh"
2022-11-19 15:23:22 +08:00
Xiao YiFang 3b05f3b4e9 fix scanpopup dialog popup condition check 2022-11-19 14:52:20 +08:00
Xiao YiFang b02b6f9bcb [action] bump qt version from 6.3.2 to 6.4.1 2022-11-18 20:28:26 +08:00
Xiao YiFang 0d2e2bb6a3 Merge remote-tracking branch 'gd/master' into staged 2022-11-18 20:23:43 +08:00
Xiao YiFang 3653b616cf Merge commit '83d71daf03e468f784e41e834dc32c67fe2a5870' into staged 2022-11-18 20:23:32 +08:00
Xiao YiFang cdc0fe07e0 fix: forvo has no free plan now fix the apikey tooltip
in order to use forvo pronounciation ,an api key has to be aquired.
2022-11-18 20:13:24 +08:00
Xiao YiFang 3b96b468a9 add zh_CN translation 2022-11-18 19:57:20 +08:00
Igor Kushnir 3aaaf15e0a Save&restore the geometry of Print Preview dialog
Calling dialog.showMaximized() before dialog.exec() doesn't work as
intended under KDE Plasma and Xfce. In both desktop environments the
Print Preview dialog ends up modeless - the user can interact with the
main window while the dialog is visible. Such a behavior is surprising
to developers, because QDialog::exec() should show the dialog as modal.
In addition, under Xfce the dialog is not maximized, but very small and
also frameless => neither movable nor resizable.

b13b808edf inserted the line
`dialog.showMaximized();` to work around tiny print preview window,
which confirms that the side effects described above are unintentional.

These maximizing issues could be fixed by passing
Qt::CustomizeWindowHint | Qt::WindowMaximizeButtonHint | Qt::WindowCloseButtonHint
as window flags to QPrintPreviewDialog's constructor and replacing the
line `dialog.showMaximized();` with
`dialog.setWindowState( dialog.windowState() | Qt::WindowMaximized );`.
However, saving and restoring the dialog's geometry allows customization
and thus improves usability. This is how more frequently used dialogs
behave in GoldenDict.

Customize the dialog's window flags to show a maximize button.
Maximizing could be useful on a small screen. This also makes restoring
the old appearance on systems, where it worked correctly, easy to the
user: maximize the dialog once and it appears maximized henceforth
(until the user unmaximizes it back). Use the same window flags as in
EditDictionaries dialog - I haven't noticed any complaints since they
were introduced more than a year ago.
2022-11-17 18:36:58 +03:00
shenleban tongying 8d3b4165da Add "copy info" buttons to about dialog 2022-11-17 05:14:18 -05:00
xiaoyifang 4f10a55f95
Merge pull request #204 from xiaoyifang/fix/issue203
fix revert c5035d87fc  conflict
2022-11-17 17:22:58 +08:00
xiaoyifang ea21eba386 fix revert c5035d87fc conflict
related to the issue #203
2022-11-17 16:43:42 +08:00
xiaoyifang df91a5b7bd add spx extenstion to the QFileDialog save path 2022-11-17 14:09:11 +08:00
Igor Kushnir 83d71daf03 Don't reset FTS Ignore* options on Preferences change
Accepting changes in Preferences dialog no longer disables two options
"Ignore words order" and "Ignore diacritics", which are configurable in
Full-text search dialog.
2022-11-16 18:51:26 +03:00
Igor Kushnir c087d60165 Set article background to white while printing
cb6b00d85e set .gdarticle background to
`#fefdeb` in article-style.css, but failed to override it in
article-style-print.css.

Set html background to white as well in order to prevent a thin border
around articles' contents if non-printing article styles set html
background to a color other than white.

Printing color background makes little sense and is wasteful. Users who
prefer the old behavior can override the background color in
<Configuration Folder>/article-style-print.css.

Use `background` rather than `background-color` CSS property in order to
overwrite any background image set by non-printing article styles.
2022-11-16 18:51:01 +03:00
Xiao YiFang 67485fd875 [action] enable macos homebrew action 2022-11-16 21:10:45 +08:00
Xiao YiFang 66ec6b6d63 fix: mdx headword total count is incorrect 2022-11-16 21:09:30 +08:00
xiaoyifang 7215a34dd9
Merge pull request #192 from xiaoyifang/feature/homebrew-ffmpeg
github action: homebrew ffmpeg
2022-11-15 21:15:00 +08:00
Xiao YiFang 12acff095c ffmpeg convert the the audio to raw format 2022-11-15 21:14:34 +08:00
Xiao YiFang edea394892 [macos] add speex support 2022-11-15 21:14:34 +08:00
Xiao YiFang 6c72f650fe Merge remote-tracking branch 'gd/master' into staged 2022-11-15 20:02:24 +08:00