Commit graph

298 commits

Author SHA1 Message Date
Xiao YiFang 7d43aea9b2 opt: right context menu ,remove non-sense characters
like punctuation and space and symbols
2022-05-29 16:00:29 +08:00
Xiao YiFang c45b4cc255 fix: invalid gdlookup url should be forbidden. 2022-05-28 10:41:28 +08:00
Xiao YiFang f98ac1b588 clean code:remove useless code 2022-05-27 21:54:30 +08:00
Xiao YiFang f1bcb37e76 fix upstream merge conflict 2022-05-25 08:00:58 +08:00
Igor Kushnir 201f11e656 Set current article at most once in loadFinished()
When the current article is set and the user expands or collapses
optional parts (e.g. via the Ctrl+* shortcut),
ArticleView::setCurrentArticle() is called twice from
ArticleView::loadFinished(). Furthermore, the window scroll position is
restored before the second jump. This is wasteful. Move the
higher-priority setCurrentArticle() call up and, if it succeeds, skip
the other call and the scrolling.

I have measured the time spent running the affected code fragment on my
GNU/Linux system before and at this commit. When the loaded articles are
not very large, the performance gain of this commit is only about 1 ms.
However, when one of the displayed articles was huge (the
"United States" English Wikipedia article), the time went from 120 ms to
5 ms.
2022-05-24 21:02:20 +03:00
Xiao YiFang 1f01e545d1 disable print background 2022-05-24 21:40:53 +08:00
Xiao YiFang c6811db3a0 fix: merge conflict from upstream 2022-05-24 20:25:09 +08:00
Igor Kushnir b87b023db0 Optimize highlighting FTS matches in articles
The wall time of calls to ArticleView::highlightAllFtsOccurences() on my
GNU/Linux system before and at this commit:
allMatches.size()   uniqueMatches.size()    before(ms)  at(ms)
79                  1                       277         4
98                  1                       380         4
267                 1                       16803       65
2022-05-23 16:05:36 +03:00
Igor Kushnir bd5b36cac7 Extract ArticleView::highlightAllFtsOccurences()
Extracting this function allows to simplify the code and facilitates
optimizing it in the next commit.

Remove `#if QT_VERSION >= 0x040600` along the way as GoldenDict does not
support Qt versions older than 4.6 for several years now.
2022-05-23 16:02:01 +03:00
Xiao YiFang 55fee75acd fix: a bug with send to anki 2022-05-22 10:05:22 +08:00
Xiao YiFang 0a2661f986 add 'send to anki' function
users can configure the ankiconnect to use together with anki
2022-05-21 17:34:22 +08:00
Xiao YiFang a7ba9e4b36 opt:use acceptNavigationRequest instead of weburlinterceptor 2022-05-20 18:01:41 +08:00
Xiao YiFang 459b684e5b opt: make the inspect window's instance to exactly only one. 2022-05-20 17:31:47 +08:00
Xiao YiFang c0e3767f83 opt: format code and remove default constructor 2022-05-19 20:37:11 +08:00
Xiao YiFang 15d9104f2c fix : fulltext search will crash
close issue #69
2022-05-19 20:28:52 +08:00
Xiao YiFang a1ef0313ab opt : set webengine font family
make it take effect immediately
2022-05-17 21:24:30 +08:00
Xiao YiFang eda434f38e opt: rename emitDicts signal to dictionaryChanges 2022-05-15 22:48:22 +08:00
Xiao YiFang 20f51fc7f2 fix: double click image will clear translate input line 2022-05-08 21:02:23 +08:00
Xiao YiFang 9c402d986e opt: add dictionary fallback font family settings 2022-05-08 16:44:09 +08:00
Yifang Xiao 289b0be594 fix:archlinux variant version ,mouse back button 2022-05-05 21:37:23 +08:00
xiaoyifang 60a4853e51
Merge pull request #57 from xiaoyifang/opt/blank-page
remove blank page load
2022-04-26 20:38:56 +08:00
YiFang Xiao 75b6788937 opt: add javascript clipboard support 2022-04-26 20:21:45 +08:00
xiaoyifang ab2c1db889 remove blank page load 2022-04-22 20:24:45 +08:00
xiaoyifang e679463dc0 fix:merge compile lamda error 2022-03-31 08:54:06 +08:00
xiaoyifang 228d7001e5
Merge pull request #35 from ngn999/bugfix/Macbook_scroll_issue
disable macOS trackpad zoom; fix a deadlock
2022-03-31 00:10:37 +08:00
ngn999 13dfd39e69 fix more indent issue 2022-03-30 23:10:37 +08:00
ngn999 b187c0ef41 fix code review indent issue 2022-03-30 23:08:24 +08:00
xiaoyifang 03653925be optimize: double click send select text to tranlateline box. 2022-03-30 15:21:16 +08:00
xiaoyifang 913e4128ca fix:qt6.2 print preview 2022-03-29 20:34:55 +08:00
ngn999 32fcd38dc0 make getWebPageText async 2022-03-28 17:29:00 +08:00
ngn999 e45f466a9d make toHtml async 2022-03-28 10:30:23 +08:00
ngn999 05bbf54330 rewrite lambda capture list 2022-03-27 23:36:14 +08:00
ngn999 6c310b41af make isFramedArticle async, and remvoe runJavaScriptSync() 2022-03-27 23:05:45 +08:00
ngn999 95be606a9e make ArticleView::hasSound() async 2022-03-27 22:22:42 +08:00
xiaoyifang 9ebf38f888 F12 and right context menu inspect element
when trigger inspectelement through contextmenu , should navigate to the very element in devtool.
2022-03-26 10:44:23 +08:00
YiFang Xiao 75e0dfdec7 fix: fix todo when upgrade to 6.2 2022-03-20 19:27:35 +08:00
xiaoyifang 2851533645 clean code: remove useless method
this methods related to win32 getText which has been removed
2022-03-18 22:22:48 +08:00
xiaoyifang f18e8f8960 fix:gdau link show blocked in devtool network 2022-03-16 22:29:04 +08:00
xiaoyifang 61fb1020b8 add QWebEngineSettings::UnknownUrlSchemePolicy to qwebenginesettings 2022-03-14 23:24:53 +08:00
xiaoyifang 156eca87d5 fix:qt6.2 printer preview 2022-03-12 18:12:17 +08:00
yifang fb2eac9b5e upgrade to 6.2,linux compile 2022-03-11 22:14:40 +08:00
xiaoyifang 6b01cba709 modify webenginesettings to support qt6.2 2022-03-11 22:14:16 +08:00
xiaoyifang 7b5511a7bd upgrade to qt6.2 2022-03-11 22:00:45 +08:00
xiaoyifang 3a092947da fix:popup javascript windows 2022-03-11 00:41:35 +08:00
yifang edf8c8d4f3 optimize:rename inspector class 2022-03-05 19:34:49 +08:00
yifang ae8c2df4a8 optimize: F12 improve
when close inspected windows,the inspect is still working .
2022-03-04 23:27:34 +08:00
yifang 269a7bcf48 fix:middle mouse click open in new tab 2022-03-04 00:17:21 +08:00
xiaoyifang d607079ffb fix: double click to translation should stop audio first.
there are cases when the audio is too long (in wiki).
when double click occured .the audio is still playing.
2022-02-25 23:33:34 +08:00
xiaoyifang 70e7a49db8 fix: scroll to current article 2022-02-25 22:48:43 +08:00
xiaoyifang d341a64569 fix:scrollIntoView,set the html active style. 2022-02-25 07:47:20 +08:00