Commit graph

53 commits

Author SHA1 Message Date
xiaoyifang 7bbab2a759
Merge pull request #1559 from xiaoyifang/opt/articleview-group
opt: remove the argument which pass the GroupComboBox to the ArticleV…
2024-06-12 20:11:45 +08:00
xiaoyifang 26bdf52c5e
Update src/ui/articleview.cc
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2024-06-12 13:35:19 +08:00
xiaoyifang 998a97a031
Update src/ui/articleview.cc
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2024-06-12 13:35:02 +08:00
Xiao Yi Fang 0b5e2f140d code smell: remove warning 2024-06-12 10:13:29 +08:00
Xiao Yi Fang 93b0da83fc opt: remove the argument which pass the GroupComboBox to the ArticleView class 2024-06-12 09:32:04 +08:00
shenleban tongying 57a5c52620 clean: remove unnecessary passing of openSearchAction to ArticleView's ctor 2024-03-21 19:09:05 -04:00
xiaoyifang 728fa4850c
Merge pull request #1425 from shenlebantongying/fix/mac-open-in-systemviewer
fix: "Open Image in System Viewer" doesn't work on macOS
2024-03-20 13:19:03 +08:00
shenleban tongying 0b61888bc7 fix: Open Image in System Viewer doesn't work on macOS 2024-03-20 00:46:40 -04:00
shenleban tongying 483381414f
clean: remove macOS unused code related to gestures (#1421)
* clean: remove macOS unused code related to gestures

We prefer native gestures and disabled gesture.cc long time ago, those are unused

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-03-20 11:11:35 +08:00
shenleban tongying b9e14f806c
fix: CMake problems found by the openBSD package (#1422)
* fix: CMake problems found by openBSD package

* remove unused WITH_XAPIAN option
* don't link Qt TTS if not requested

* fix: address CMake problems found by openBSD package

* remove unused WITH_XAPIAN option
* don't link Qt TTS if not requested
* Disable some code when TTS is not requested

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-03-20 11:08:17 +08:00
shenleban tongying 32391bda43
fix: reduce darkreader mode white flash further by using QWebEnginePage::setBackgroundColor() (for Qt6.6.3+) (#1406)
* fix: reduce darkreader mode white flash further by using
QWebEnginePage::setBackgroundColor() (for Qt6.6.3+)

In previous Qt6.x versions, this function only set background once and
become invalidated if reload a page.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-02-27 18:07:00 +08:00
YiFang Xiao 54808cd03f fix: ctrl+v in Welcome page will result a wrong search 2024-01-26 16:52:27 +08:00
YiFang Xiao 11af19de3b fix: critial error throw. 2024-01-10 09:57:31 +08:00
xiaoyifang fc62d115f3
Merge pull request #1311 from xiaoyifang/opt/highlight-term
opt: mark exact word
2023-12-06 15:23:30 +08:00
YiFang Xiao 923a46217b opt: mark exact word 2023-12-06 14:29:59 +08:00
YiFang Xiao d15cafed49 fix: image temp path 2023-12-06 11:16:35 +08:00
xiaoyifang 9c5e25971b
opt: support to open image in system viewer (#1309)
* opt: open image in external

fix have to wait the resource downloaded

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-12-06 09:44:17 +08:00
xiaoyifang 64f69d2235
opt: open image in external tool (#1308)
* opt: open image in external tool

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-12-05 14:59:45 +08:00
YiFang Xiao 439b780db5 opt: use a new way to handle the highlight matched terms in the fulltext search view page. 2023-11-25 17:13:33 +08:00
xiaoyifang fb85f68b21
fix: js undefined error (#1298)
* fix: js undefined error

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-11-23 22:00:19 +08:00
xiaoyifang 78bd94f965
fix: mouse xbutton1(&2) back and forward event (#1258)
* fix: mouse xbutton1(&2) back and forward event

* [autofix.ci] apply automated fixes

* fix: mouse xbutton1&2 back and forward triggered twice.

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-10-27 07:51:34 +08:00
xiaoyifang 0be3afa90a
opt: history addItem logic optimization (#1224)
* opt: history addItem logic optimization

* opt: move history logic after url load

* opt: move history logic after url load

* opt: remove Item from history

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-10-10 22:57:26 +08:00
YiFang Xiao b4cbf24570 fix: scanpopup flash content
[autofix.ci] apply automated fixes
2023-10-10 21:29:11 +08:00
xiaoyifang b1781b63d6
opt: remove gdpicture & maxPictureWidth which has not been used at all. (#1220)
* opt: remove gdpicture protocol which has lost effect for a long time

* opt: remove maxPictureWidth which has no place to configure this variable value

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-10-09 19:58:16 +08:00
xiaoyifang aebf85ef4a
opt: refactor the code to show untitle & welcome page (#1203)
* opt: refactor the code to show untitle & welcome page

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-10-07 20:49:38 +08:00
xiaoyifang 5c9beab96c
fix: search in the current page does not clear found dictionary panel (#1123)
* fix: search in the current page does not clear found dictionary panel

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-09-05 00:06:03 +08:00
YiFang Xiao 1285cbf68f fix: code smells 2023-09-02 11:45:47 +08:00
YiFang Xiao 74a21e7e26 fix: epwing dictionary reference navigation restrict to certain dictionary 2023-09-02 11:33:53 +08:00
YiFang Xiao 0683afa2b0 opt: add Ctrl+Shift+S to stop the current playing sound
[autofix.ci] apply automated fixes
2023-08-25 08:44:21 +08:00
YiFang Xiao 5db4491505 fix: simultaneous playing sound in wikipedia
click the audio link repeatly in wikipedia will cuase the sound to play simultaneously

[autofix.ci] apply automated fixes
2023-07-27 11:29:20 +08:00
autofix-ci[bot] 1502dc318a
[autofix.ci] apply automated fixes 2023-07-27 00:29:51 +00:00
YiFang Xiao 0ed2f697cd fix: alt+down/alt+up navigation through dictionary 2023-07-27 08:27:46 +08:00
xiaoyifang d3e6018401
fix: wikipedia open blank page in edge browser (#1003)
* fix: wikipedia open blank page in edge browser

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-25 23:55:41 +08:00
xiaoyifang df4bc68248
fix: [regression]scanpopup right context menu lost dictionary list (#989)
* fix: [regression]scanpopup right context menu lost dictionary list

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-20 22:49:37 +08:00
shenleban tongying b5349478cf
clean: reformat everything
The next commit will add `.git-blame-ignore-revs`

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
2023-07-20 04:02:22 -04:00
xiaoyifang ec06124acb
feat: sync group widget with tab (one group per tab) (#976)
* feat: sync group widget with tab

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-17 08:24:02 +08:00
xiaoyifang 2ed7990531
opt: pronounce audio rewrite (#922)
* opt: pronounce audio rewrite

* 🎨 apply clang-format changes

* fix:use javscript Map to hold the dictionary audio url

* Update mainwindow.cc

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-07-13 14:49:41 +08:00
YiFang Xiao 568efee4c7 fix: unicode regex option support 2023-07-09 18:10:30 +08:00
YiFang Xiao 92fa182643 fix: save audio, add opus extension 2023-07-07 20:26:40 +08:00
xiaoyifang 8b88ea544e
opt: add fullindex position (#916)
* opt: enable fulltext with position info

* opt: add fulltext position support

* 🎨 apply clang-format changes

* i18n: update translation entries

* opt: default enablePosition=false

* opt: fulltext search highlight

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-07-01 22:39:43 +08:00
shenleban tongying 35f39ea7a0
clean: convert a few trivial old SIGNAL/SLOT to new syntax 2023-06-11 11:27:49 -04:00
xiaoyifang 5899aa7c94
fix: highlight fts search result (#792)
* fix: highlight fts search result

* 🎨 apply clang-format changes

* remove accent/diacritic handler used in fts search

* header file adjustment

* fix: qt5.15 compile

* fix: code smell

use const reference variable

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smells

🎨 apply clang-format changes

* opt: fix code smells

remove unused parameters from function `ftsIndexIsOldOrBad`

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 08:29:19 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
2023-05-30 20:59:51 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736)
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
2023-05-29 00:01:54 +08:00
xiaoyifang 69ff9b1177
opt: remove DiacriticFolding.txt (#713)
* opt: remove DiacriticFolding.txt

* 🎨 apply clang-format changes

* fix: remove foldedDiacritic method

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-20 10:28:43 +08:00
xiaoyifang d08d5fe576
opt: let qt handle the language direction (#709)
* opt: let qt handle the language direction

* 🎨 apply clang-format changes

* action: modify auto clang format action

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-19 19:41:27 +08:00
YiFang Xiao 837f8bcaf8 fix: code smell 2023-05-13 12:39:36 +08:00
YiFang Xiao 60d26e0e0f fix: the scanpopup found dictionaries mixed with mainwindows
fix #677
2023-05-13 12:39:36 +08:00
Xiao YiFang c2f856c074 opt: Sorting through the use of strings
there are many string conversion in the system .some of them can be avoided .
2023-04-24 15:11:40 +08:00
Xiao YiFang 14c4366839 fix: when input word in translateline and press Enter
can not type word directly again.

fix:#185
2023-04-18 16:08:32 +08:00