shenleban tongying
10a79372f8
fix: better QObject hierarchy
...
* set scanpopup's parent to null because it is a top level window.
* set macClipboard as a child of the mainWindow
2023-03-09 14:14:18 +08:00
shenleban tongying
9079e2125d
fix: move enableScanningAction code after scanPopup's initialization
2023-03-07 17:46:52 +08:00
xiaoyifang
afa77a8f31
fix: remove unused code
2023-03-07 17:46:37 +08:00
xiaoyifang
84798c56ea
fix:check scanPopup existence
2023-03-07 10:09:18 +08:00
shenleban tongying
4f2c8d55aa
refactor: port away from extlineedit
...
* the main feature of extlineedit.cc was having icons on left and right side which is already provided by QLineEdit::addAction after Qt5.2
2023-03-06 09:46:32 +08:00
xiaoyifang
9b7b64e174
Merge pull request #368 from shenlebantongying/qrcx_to_qrc
...
cleanup: Replace all usages of qrcx://localhost with qrc://
2023-03-06 07:33:21 +08:00
shenleban tongying
540dda26ed
cleanup: Replace all usages of qrcx://localhost with qrc://
...
The replacement command:
git grep -l 'qrcx://localhost' | xargs sed -i 's/qrcx:\/\/localhost/qrc:\/\//g'
The qrcx:// URL scheme was introduced in 2009 or earlier - it is present
in the first commit in GoldenDict's git history. Back then GoldenDict
supported Qt versions earlier than 4.6, in which
QWebSecurityOrigin::addLocalScheme() was introduced. Adding the qrc URL
scheme as local obsoletes the qrcx URL scheme. GoldenDict does not
compile against Qt versions earlier than 4.6, so there is no reason to
use this custom URL scheme anymore.
Co-authored-by: Igor Kushnir <igorkuo@gmail.com>
2023-03-05 15:20:05 -05:00
xiaoyifang
2404a5d341
Merge pull request #366 from shenlebantongying/staged
...
fix: enabled scanpopup at startup doesn't work
2023-03-04 16:58:38 +08:00
xiaoyifang
e407a7b1ab
Merge pull request #364 from bershanskiy/darkreader
...
Add DarkReader.setFetchMethod()
2023-03-04 15:23:42 +08:00
shenleban tongying
a0e32fdfa7
fix: enabled scanpopup at startup doesn't work
...
* also merge clipboard monitoring code with toolbar scanning action icon changing code together
2023-03-04 01:59:37 -05:00
xiaoyifang
7273f84682
Merge pull request #365 from xiaoyifang/fix/wiki-request
...
fix:wikipedia url request
2023-03-02 21:52:10 +08:00
Xiao YiFang
6151c914f5
fix:wikipedia url request
2023-03-02 21:23:35 +08:00
Anton Bershanskiy
68908c1d39
Add DarkReader.setFetchMethod()
2023-03-02 11:29:12 +00:00
xiaoyifang
5aa4102796
update Belarusian ts
...
changes from @antikruk at #362
2023-03-02 16:49:22 +08:00
Abs62
d424f25fb6
Set "https" scheme instead of "http" for some wiki resources
2023-03-02 00:46:00 +03:00
xiaoyifang
51864e7e62
Merge pull request #360 from shenlebantongying/staged
...
fix: set initial background as black for dark reader mode
2023-03-01 08:59:35 +08:00
shenlebantongying
a674a5cab7
fix: set initial background as black for dark reader mode
2023-02-28 13:31:58 -05:00
xiaoyifang
eb1206945b
Merge pull request #358 from xiaoyifang/fix/ubuntu-action
...
action: bump python
2023-02-26 19:57:14 +08:00
Xiao YiFang
656cd3734c
action: bump python
2023-02-26 18:29:46 +08:00
xiaoyifang
27766d4e22
Merge pull request #356 from xiaoyifang/goldendict-master
...
upstream:save/restore scanpopup position
2023-02-26 15:37:46 +08:00
Xiao YiFang
346986a3cd
fix: fix conflict when merge upstream changes
2023-02-26 09:26:58 +08:00
xiaoyifang
e1324448c5
Delete codeql.yml
2023-02-24 15:52:24 +08:00
xiaoyifang
340814e0f6
Create codeql.yml
2023-02-24 14:56:29 +08:00
xiaoyifang
f6096c1b01
Merge pull request #351 from shenlebantongying/staged
...
elimate makeScanPopup()
2023-02-24 09:49:41 +08:00
xiaoyifang
b913a38e1f
fix: ensure #translateLine always have left border ( #352 )
...
Before:
After:
2023-02-23 17:44:35 +08:00
shenleban tongying
b1802e254e
fix: ensure #translateLine always have left border
2023-02-22 21:09:46 -05:00
shenleban tongying
b3aac01f41
refactor: elimate makeScanPopup()
...
* Old code keep destory the scanpopup, then recreate it whenever the dict list or group list changed.
* New code keep a single instance of scanpopup, and only update necessary info.
2023-02-22 20:09:26 -05:00
xiaoyifang
67d5799708
refactor: convert scanflag.ui to plain code ( #350 )
...
The .ui file only contains a single widget. The overhead is unnecessary.
| Before: There is a weird top edge. | After |
|-----------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------|
|
|
|
Slightly related to
https://github.com/xiaoyifang/goldendict/issues/349#issuecomment-1439224644 ,
we may use a similar flag later.
2023-02-22 10:03:01 +08:00
shenleban tongying
38956589a2
refactor: convert scanflag.ui to plain code
2023-02-21 19:56:12 -05:00
xiaoyifang
a7c1589149
Merge pull request #348 from shenlebantongying/staged
...
Use alternative clipboard change monitor on macOS
2023-02-18 11:49:46 +08:00
shenleban tongying
497ecf3719
fix: use alternative clipboard change monitor on macOS
...
QClipboard cannot monitor data changes on mac unless an application is focused
2023-02-17 22:02:52 -05:00
xiaoyifang
737d4421f5
Merge pull request #347 from xiaoyifang/fix/local-file-dictionary
...
fix: file:/// local file dictionary support
2023-02-17 14:50:17 +08:00
xiaoyifang
84c6b79217
fix: local dictionary file:/// support
2023-02-16 16:11:27 +08:00
xiaoyifang
c5b9e48e0e
fix: local dictionary file:/// support
2023-02-16 15:58:44 +08:00
Abs62
e43c0d2521
ScanPopup: Some more of save/restore position of the pinned popup window
2023-02-14 22:40:08 +03:00
Abs62
74aa95220d
ScanPopup: Save/restore position of the pinned popup window after closing/reopening it
2023-02-14 17:51:03 +03:00
xiaoyifang
1688481bc3
github: change windows xapian github action
2023-02-13 20:57:36 +08:00
xiaoyifang
b8680d63b2
Merge pull request #345 from shenlebantongying/staged
...
feat: bring back custom qt style sheets for Windows
2023-02-13 14:44:17 +08:00
xiaoyifang
b5cc1a9fdd
Merge pull request #346 from xiaoyifang/fix/sound-repeat
...
fix: always repeat the first played sound
2023-02-13 11:40:10 +08:00
xiaoyifang
ac59713ed0
fix: repeat play the first played sound
2023-02-13 10:53:23 +08:00
shenlebantongying
f8e2e3c021
feat: bring back custom qt style sheets for Windows
2023-02-12 11:01:36 -05:00
xiaoyifang
1efe5df30d
Merge pull request #344 from shenlebantongying/staged
...
fix: reset background to white when darkreader mode is used
2023-02-12 18:03:00 +08:00
shenleban tongying
91bb527c6e
fix: reset background to white when darkreader mode is used
...
A few theme's yellow background is ugly when inverted
2023-02-12 02:18:56 -05:00
Xiao YiFang
bd736d7f37
fix: qmultimedia qmediaplayer can not play the next audio in qt6.4.2
2023-02-09 23:04:28 +08:00
Xiao YiFang
2baffb0628
fix: website dictionary display incorrect text on the page.
...
fix #340
2023-02-09 23:00:32 +08:00
xiaoyifang
85429d79a5
add translations to changes in ce037dbfda
2023-02-08 15:35:31 +08:00
xiaoyifang
ca5b47cca7
Merge pull request #337 from xiaoyifang/fix/iconv-convert-error
...
fix: iconv convert error
2023-02-08 10:38:07 +08:00
xiaoyifang
105019da95
Merge pull request #336 from xiaoyifang/merge/upstream-2023-2-8
...
merge upstream wikimedia changes
2023-02-08 10:14:48 +08:00
xiaoyifang
5eac90e72c
fix:iconv convert error
2023-02-08 10:11:21 +08:00
xiaoyifang
7a3755333c
Merge remote-tracking branch 'gd/master' into staged
2023-02-08 09:47:51 +08:00
