shenleban tongying
0cb3bb9142
refactor: abstract FsEncoding::dirname(getDictionaryFilenames()[0])
...
* FsEncoding::dirname is mostly used with getDictionaryFilenames()[0] to obtain the containing folder of a dict
* Abstract them into Dictionary::Class::getContainingDir()
* FsEncoding::dirname is removed
2023-04-14 12:53:53 +08:00
shenleban tongying
e66f97f7db
refactor: remove FsEncoding::encode/decode
...
They never serve any purpose other than converting between std::string <> QString <> char*.
2023-04-14 07:27:59 +08:00
xiaoyifang
034c878e91
fix: code smell
...
unused stored value `owner`
2023-04-13 12:17:59 +08:00
shenleban tongying
86f1aeceb6
refactor: simplify MainWindow::showDictionaryHeadwords
...
* merge two methods into one
2023-04-13 10:17:59 +08:00
shenleban tongying
ddb9655938
refactor: move MRU ctrl handling code from mainwindow.cc to mruqmenu.cc
2023-04-12 20:16:29 +08:00
Xiao YiFang
7402dcdd6a
clean:remove std::wstring
...
std::wstring is not a proper implemention on Windows, will face cross platform issues
2023-04-10 22:02:43 +08:00
Xiao YiFang
e84b5aa861
feature:webengineprofile use non off record profile
2023-03-27 12:29:13 +08:00
Ren Tatsumoto
7fc2d64cd8
give external programs access to translateLine via %GDSEARCH% ( #417 )
...
* give external programs access to translateLine via %GDSEARCH%
* remove code smell
* reformat with clang-format
* update translations
* don't write to stdin of an external program if GDSEARCH is set
* update ui docs
2023-03-24 19:52:38 +08:00
xiaoyifang
a234bb0e43
remove qt-style.css content totally ( #407 )
...
* remove all qt-style
* remove all related #translationLine #GroupCombox qt style
2023-03-22 09:01:22 +08:00
shenleban tongying
13add70db2
cleanup: remove unnecessary variables in ArticleMaker
...
4 variables are removed because they are always read-only and always the same as global config. There is no reason to keep or update a separate copy.
2023-03-21 17:42:52 +08:00
shenleban tongying
0731253489
cleanup: simplify DSL's expand mode
...
Related code was related to DSL's [*][/*] tag.
One of the feature removed is Ctrl+8 to toggle current articleview's AlwaysExpand mode, because DSL is the only format that has this feature and User can turn on AlwaysExpand Mode on Preferences. There is no need to assign a shortcut for it.
2023-03-21 15:34:55 +08:00
xiaoyifang
b3a1d27c2f
Merge pull request #401 from xiaoyifang/fix/epwing-load-article
...
fix: epwing load article protection when load invalid address
2023-03-21 00:56:48 +08:00
Xiao YiFang
8cc5c54b78
refactor: remove unneccessary macro condition
2023-03-21 00:01:02 +08:00
Xiao YiFang
d4c285226c
fix: sonarcloud analysis
...
if,switch, and range-based for loop initializer should be used to reduce scope of variables cpp:S6004
2023-03-20 23:47:23 +08:00
Xiao YiFang
736a9aad23
epwing:does not add ref link to the history
2023-03-20 23:26:27 +08:00
Xiao YiFang
a5f9560b99
fix: windows can not restore the Geometry
...
fix #312
the reason is still unknown , when invoke the addNewTab, the window's size was reset to its default size
2023-03-20 22:54:04 +08:00
Ren Tatsumoto
fb6d4f9ccd
Let the user disable main window stealing focus when searching. ( #387 )
...
* add a checkbox that allows the user to disable main window being raised when search is triggered
* run clang-format on the edited lines
* partially revert clang-format
2023-03-17 09:54:45 +08:00
Ren Tatsumoto
1a0af48a7a
Improve Anki support ( #384 )
...
* allow the user to configure word,text,sentence Anki fields
* if sentence field is not set, don't add it
* mark the target word bold, if possible
* Update how to connect with anki.md
* rename default field names
2023-03-16 19:55:47 +08:00
shenleban tongying
10a79372f8
fix: better QObject hierarchy
...
* set scanpopup's parent to null because it is a top level window.
* set macClipboard as a child of the mainWindow
2023-03-09 14:14:18 +08:00
shenleban tongying
9079e2125d
fix: move enableScanningAction code after scanPopup's initialization
2023-03-07 17:46:52 +08:00
xiaoyifang
afa77a8f31
fix: remove unused code
2023-03-07 17:46:37 +08:00
xiaoyifang
84798c56ea
fix:check scanPopup existence
2023-03-07 10:09:18 +08:00
shenleban tongying
a0e32fdfa7
fix: enabled scanpopup at startup doesn't work
...
* also merge clipboard monitoring code with toolbar scanning action icon changing code together
2023-03-04 01:59:37 -05:00
shenleban tongying
b3aac01f41
refactor: elimate makeScanPopup()
...
* Old code keep destory the scanpopup, then recreate it whenever the dict list or group list changed.
* New code keep a single instance of scanpopup, and only update necessary info.
2023-02-22 20:09:26 -05:00
shenleban tongying
497ecf3719
fix: use alternative clipboard change monitor on macOS
...
QClipboard cannot monitor data changes on mac unless an application is focused
2023-02-17 22:02:52 -05:00
shenlebantongying
f8e2e3c021
feat: bring back custom qt style sheets for Windows
2023-02-12 11:01:36 -05:00
shenleban tongying
ce037dbfda
doc: update urls
...
Replace old goldendict.org
2023-01-05 20:34:53 -05:00
Xiao YiFang
d8398a2be7
fix: scanpopup was trigger twice
...
fix #304
2023-01-02 22:45:07 +08:00
Xiao YiFang
4a30302864
fix: move Contexts to header file
2023-01-02 22:00:42 +08:00
xiaoyifang
0089420801
Merge pull request #302 from xiaoyifang/fix/qkeysequenceedit
...
Fix: replace preference.ui hotkeyedit with qkeysequenceedit
2022-12-30 11:39:14 +08:00
Xiao YiFang
794d4b934f
fix: replace hhotkeyedit with qkeysequenceedit
...
related to #291
2022-12-30 01:11:22 +08:00
shenleban tongying
e2bd010b19
fix: Unsatisfactory "Close To Tray" behavior on macOS
2022-12-29 11:36:01 -05:00
shenlebantongying
7daf9b4e56
fix: articleview style switching
2022-12-29 04:44:46 -05:00
shenleban tongying
2aeed5e705
clang-tidy: apply modernize-use-override
2022-12-29 02:14:53 -05:00
shenleban tongying
7fa87b6b42
fix: remove unused isScanningEnabled, the logic is handled in mainwindow::clipboardChanged()
2022-12-28 21:58:27 -05:00
shenleban tongying
bdc43650bb
fix: add a mini delay for selection clipboard
2022-12-28 21:36:02 -05:00
shenleban tongying
a28aec3c9f
fix: clipboard changes isn't ignored
2022-12-28 21:19:58 -05:00
shenleban tongying
c6f895c15c
fix: when darkreader mode changes in perferences, reload all pages
2022-12-28 06:13:42 -05:00
shenleban tongying
426f77fee5
refactor: remove duplicated favoriatePane shortcut setting
2022-12-27 05:27:59 -05:00
shenleban tongying
01c0b8d9d9
refactor: remove duplicated history shortcut setting
2022-12-27 01:52:20 -05:00
shenleban tongying
9828ef9dc8
perfect_dark: add toggle option to enable Dark Reader mode
2022-12-26 12:29:30 -05:00
shenleban tongying
07e92e8ac1
refactor: upgrade most of macro based Signal/Slot to new syntax
2022-12-25 21:08:17 -05:00
shenlebantongying
587aad1471
Perfect dark: remove explict Qt widget coloring
2022-12-25 01:53:53 -05:00
shenleban tongying
fcfa4e43e2
refactor: replace escaped strings with raw strings via clang-tidy
2022-12-24 17:01:50 -05:00
Xiao YiFang
8100bc1ae3
fix: restrict darkmode within Windows platform.
...
fix #188
https://github.com/xiaoyifang/goldendict/issues/188#issuecomment-1362444703
2022-12-22 20:55:42 +08:00
shenleban tongying
3237054cf3
fix: memory leaks found by clang LeakSanitizer
2022-12-21 20:08:41 -05:00
Xiao YiFang
e95f69ad55
fix: when in darkmode ,dictionary info panel background text is unclear
2022-12-16 21:00:02 +08:00
xiaoyifang
08c0df49e1
fix: change macro QT_NO_OPENSSL to QT_NO_SSL
2022-12-15 15:11:09 +08:00
Xiao YiFang
99bfb1c965
fix: reset style when changed from darkmode to normal
2022-12-13 20:01:18 +08:00
xiaoyifang
fc0ad83879
winspecific: revert darkmode regression ,keep windows default style
...
when starting in windows for the first time
2022-12-12 09:47:47 +08:00