Commit graph

5776 commits

Author SHA1 Message Date
Abs62 655d2456c0
Merge pull request #981 from vedgy/fix-ub-in-gestures
Don't static_cast to a wrong type in Gestures
2018-03-26 17:33:21 +03:00
Igor Kushnir 278e05cbf3 Run a single external audio player process at a time
External and internal audio players work similarly now. Fixes #950.

* inherit a new ExternalAudioPlayer class from AudioPlayerInterface;
* use an existing ExternalViewer class to implement ExternalAudioPlayer;
* take (const char *, int) instead of std::vector<char> in
  ExternalViewer constructor to fit into AudioPlayerInterface;
* extend ExternalViewer API to let ExternalAudioPlayer stop superseded
  audio player processes;
* make AudioPlayerInterface::play() return an error message string to
  allow reporting immediate failures from derived classes;
* Document AudioPlayerInterface API;
* Document AudioPlayerFactory::player();
* use the common audio interface exclusively in ArticleView.
2018-03-24 21:34:06 +02:00
Igor Kushnir e5045860ef Make adding new audio player implementations easy
* add a new interface class AudioPlayerInterface;
* inherit a new proxy class Ffmpeg::AudioPlayer from it;
* partially switch ArlticleView to using the interface;
* expose MainWindow's AudioPlayerInterface instance to all ArticleView
  instances;
* add a new AudioPlayerFactory class responsible for creating instances
  of concrete classes derived from AudioPlayerInterface depending on
  relevant Config::Preferences values;
* increase minimum supported Qt version from 4.5 to 4.6 in README
  in order to use QScopedPointer introduced in Qt 4.6.
2018-03-24 21:31:48 +02:00
Igor Kushnir 2e25be8f71 Eliminate redundant casts to/from void* in Ffmpeg player 2018-03-24 20:16:50 +02:00
Igor Kushnir 6e9c79f67b Don't static_cast to a wrong type in Gestures
The result of a downcast to a wrong dynamic type is undefined according
to the C++ standard.

Wrong casts were detected at goldendict start by GCC's
-fsanitize=undefined option. This commit fixes #974.
2018-03-24 18:03:10 +02:00
Abs62 bd95948264 Fix potential error in dictzip.c (issue #978) 2018-03-23 20:40:54 +03:00
Abs62 dd0464b9d5 Hunspell: Strip comments while search base form of word 2018-03-23 16:08:33 +03:00
Abs62 0e22d06f97
Merge pull request #977 from kyleskimo/patch-3
Update zh_TW.ts
2018-03-23 16:02:45 +03:00
kyleskimo 22f0e6ff77
Update zh_TW.ts
Update translation.
2018-03-23 14:24:29 +08:00
Abs62 4ec525d67d Fix typos 2018-03-21 22:15:22 +03:00
Abs62 1dc4c24966 DSL: Warnings about unknown and unfinished tags 2018-03-19 17:44:12 +03:00
Abs62 ad705bd01e Fix isNameOf...() functions for case of string contains whitespaces only 2018-03-19 17:42:30 +03:00
Abs62 9468f266f5 Increase limit of node elements while build index 2018-03-13 22:25:17 +03:00
Abs62 e89df78ecb A little optimization of read data from network 2018-03-12 20:22:38 +03:00
Abs62 cbdd6bfe5a Qt5: Fix some potential issues after using QRegularExpression instead of QRegExp 2018-03-12 00:06:09 +03:00
Abs62 357638b033 Wiki: Fix handling of url's without urls scheme 2018-03-11 16:33:17 +03:00
Abs62 f2294ec3b6 Wiki: Fix parsing of "audio" tags (issue #967) 2018-03-11 16:08:37 +03:00
Abs62 5409cdf2c9 DSL: Fix expand tildes for headwords with stress tag while full-text search 2018-03-09 23:43:15 +03:00
Abs62 b2169a3183 DSL: Expand tildes while full-text search 2018-03-09 18:47:11 +03:00
Abs62 99a4e00b65 Full-text search: Fix find headwords by unsorted offsets 2018-03-09 02:16:15 +03:00
Abs62 b30dc0f1a5 Zim: Fix threads synchronization while full-text indexing 2018-03-08 16:32:05 +03:00
Abs62 d3d978e7c9 Zim: More fast interrupt of full-text search 2018-03-08 11:46:19 +03:00
Abs62 a563311b61 Unify buffer size for lzma2 decompressor 2018-03-08 11:34:07 +03:00
Abs62 1e85a18662 Full-test search: Use dictionary-specific articles sorting while search 2018-03-08 00:23:01 +03:00
Abs62 3deb5ee266 Zim: Sort articles by cluster number while full-text indexing 2018-03-07 23:32:20 +03:00
Abs62 6d03661b70 Stardict: Add class for "h3" headwords tags 2018-03-07 17:01:16 +03:00
Abs62 69650fff43 Zim: Add some caching for multi-elements clusters 2018-03-07 17:00:43 +03:00
Abs62 2def5f120d Mac-specific: Update lzma library to version 5.2.3 2018-03-06 18:31:53 +03:00
Abs62 ba145fac47 Win-specific: Update lzma library to version 5.2.3 2018-03-06 18:31:03 +03:00
Abs62 d56f3835dc Full-text search: A little code optimization 2018-03-06 18:29:49 +03:00
Abs62 76c862a773 Fix typo 2018-03-01 19:02:50 +03:00
Abs62 7b4e5a2ff7 Full-text search: A little optimization for memory allocation 2018-03-01 18:44:11 +03:00
Abs62 81e8fe7e20 Full-text search: More fast interrupt of search 2018-03-01 18:06:48 +03:00
Abs62 57508c0a5c Slob: Fix threads synchronization while full-text indexing 2018-02-28 21:15:29 +03:00
Abs62 9465fcefb5 DSL: Fix full-text indexing for case of unsorted parts in headword 2018-02-28 17:18:08 +03:00
Abs62 cfd74be181 Qt5: Fix handling of "audio" tag in GLS format 2018-02-28 17:17:10 +03:00
Abs62 cbdad22f2d Qt5: Some optimizations for QRegularExpression 2018-02-28 17:15:27 +03:00
Abs62 fe39fc8a05 Qt5: More QRegularExpression instead of QRegExp 2018-02-27 20:18:35 +03:00
Abs62 03db65a4c6 Fix comments stripping while CSS isolation 2018-02-26 17:33:55 +03:00
Abs62 135593f663 Add new files to git 2018-02-22 19:49:54 +03:00
Abs62 c204f75e52 Qt5: Use QRegularExpression instead of QRegExp in many cases 2018-02-22 16:55:56 +03:00
Igor Kushnir 50fe9be623 Show #link as a tooltip instead of empty "Definition: "
Internal links in MediaWiki articles don't lead to word definitions,
so the "Definition: " prefix is not correct for them. It also does not
provide any information and is largely useless.

Perhaps the actual footnote text should be displayed in the tooltip,
but this requires distinguishing them from citations/references and
backlinks.
2018-02-21 13:01:02 +02:00
Abs62 8180c911b7 Update help system 2018-02-08 22:57:08 +03:00
Abs62 24ba0aa64d Update help system 2018-02-08 18:05:19 +03:00
Abs62 740637d98a Ignore Ctrl/Shift/Alt modifiers while click on the "Found in Dictionaries" pane if Dictionaries bar is hidden 2018-02-08 18:01:39 +03:00
Abs62 65237ab22c Use Alt+LClick in the "Found in Dictionaries" pane as LClick in the Dictionaries bar 2018-02-08 18:01:02 +03:00
Abs62 109bd56f39 Wiki: Fix work with headwords containing the '+' sign 2018-01-31 20:54:51 +03:00
Abs62 8ba93a6c5a
Merge pull request #951 from vedgy/mediawiki-subpage-fix
Fix subpage links in MediaWiki
2018-01-31 17:39:08 +03:00
Igor Kushnir deea197ca7 Fix subpage links in MediaWiki
I haven't encountered any prefix other than "/wiki/" that should be
discarded. If there are such other prefixes, I think they would conform
to some pattern, and so the replacement code could be adjusted to
accommodate them.

This commit fixes #813.
Examples of pages with subpage links in English Wikipedia that are fixed
by this commit: "Asio (disambiguation)", "Asio C plus plus library".
This issue is much more prevalent in Wookieepedia because it has
a two-tab link system with the patterns */Legends and */Canon.
2018-01-31 14:09:19 +02:00
Abs62 d65d9248ed Fix one warning in log 2018-01-09 23:15:53 +03:00