hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-24 12:44:07 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity
3336 commits 16 branches 629 tags 255 MiB
Commit graph

440 commits

Author SHA1 Message Date
xiaoyifang 2bccf038b1
Merge branch 'goldendict:master' into staged 2022-05-26 07:12:25 +08:00
wisherhxl 0cea62699d Linux-specific: workaround of clipboard issue with Ctrl+C+C 
Closes #1420, closes #650, closes #858.
 2022-05-25 21:01:33 +03:00
Xiao YiFang e241cbef33 fix merge conflict 
when merge the changes introduced by pull #77
 2022-05-25 23:54:45 +08:00
Igor Kushnir c770e9688e Don't update state prematurely in showTranslationFor() 
MainWindow::showTranslationFor() overloads disable the "Pronounce Word"
action, then call ArticleView::showDefinition(). And then immediately
update pronounce availability, Found in Dictionaries list, Back and
Forward buttons. Since ArticleView::showDefinition() loads the requested
page asynchronously, the previous page is still current. Therefore the
"Pronounce Word" action is immediately re-enabled (if the still-current
article has sounds), the other state updates have no effect whatsoever.
Once the new page is loaded, the state is updated again in
MainWindow::pageLoaded() - this time with the desired effect.

So the only effect of the state updates in
MainWindow::showTranslationFor() is to revert the intentional disabling
of the "Pronounce Word" action. Plus waste some CPU time. The
pronunciation-disabling behavior looks better to me and is consistent
with the scan popup's behavior (which immediately hides the
"Pronounce Word" button).
 2022-05-25 18:27:18 +03:00
Xiao YiFang de11e573d3 fix:quit application failed 
when the inspector windows is show
 2022-05-23 23:38:04 +08:00
Xiao YiFang fe1fd6b933 fix: webengineview font lose affect after restart the application 2022-05-23 20:14:26 +08:00
Xiao YiFang a7ba9e4b36 opt:use acceptNavigationRequest instead of weburlinterceptor 2022-05-20 18:01:41 +08:00
Xiao YiFang 459b684e5b opt: make the inspect window's instance to exactly only one. 2022-05-20 17:31:47 +08:00
Xiao YiFang e6ab87ca73 fix:add ifr local scheme 
due to iframe security policy and x-frame-option .
the website online dictionary can not work in qt 5.15.2+ version.
this is a workaround to pass through the restriction.
 2022-05-15 22:54:26 +08:00
Xiao YiFang 9c402d986e opt: add dictionary fallback font family settings 2022-05-08 16:44:09 +08:00
xiaoyifang 5a0a6c6491 feature:add ignore punctuaion option 2022-04-23 16:15:23 +08:00
xiaoyifang eaf76fbcb6 clean code:remove useless code 
the maximumwindowssize was only set value in the ~MainWindows() which means
it can not be saved into the config file.
 2022-04-19 22:22:03 +08:00
xiaoyifang 8b9544bc17 fix:currentIndexChanged slot does not match 2022-04-01 23:32:11 +08:00
xiaoyifang 228d7001e5
Merge pull request #35 from ngn999/bugfix/Macbook_scroll_issue 
disable macOS trackpad zoom; fix a deadlock
 2022-03-31 00:10:37 +08:00
ngn999 6d0c7b0fec reindent MainWindow::on_saveArticle_triggered 2022-03-31 00:03:42 +08:00
ngn999 b187c0ef41 fix code review indent issue 2022-03-30 23:08:24 +08:00
xiaoyifang 19e738becc optimize: print preview dialog set zoom factor to 100% 2022-03-30 17:19:08 +08:00
xiaoyifang 88a69d1976 fix:revert deferredInit 2022-03-30 15:34:59 +08:00
xiaoyifang 3ea8fd78ef print preview blurry 2022-03-29 20:47:41 +08:00
ngn999 188f67556c no memory problem 2022-03-28 11:24:27 +08:00
ngn999 748bafd43b fix save file progress dialog never close bug 2022-03-28 11:09:33 +08:00
ngn999 e45f466a9d make toHtml async 2022-03-28 10:30:23 +08:00
ngn999 05bbf54330 rewrite lambda capture list 2022-03-27 23:36:14 +08:00
ngn999 6c310b41af make isFramedArticle async, and remvoe runJavaScriptSync() 2022-03-27 23:05:45 +08:00
ngn999 95be606a9e make ArticleView::hasSound() async 2022-03-27 22:22:42 +08:00
xiaoyifang 9836e8d529 ui: update icon 2022-03-27 18:12:33 +08:00
xiaoyifang c5fae8de1b fix:edit dictionaries 2022-03-22 20:20:48 +08:00
xiaoyifang fa2aae908b toolbar icon size 2022-03-15 22:26:24 +08:00
xiaoyifang 0560785a65 replace dictionary vector with QMap 
remove signal DictGroupWidget::showDictionaryInfo
 2022-03-14 08:22:31 +08:00
xiaoyifang c664ac315c dictionary group ,id match performance improve . 
use qmap to replace the double for loop check.
 2022-03-14 00:17:34 +08:00
xiaoyifang ab1b525f12 printreviewdialog change default printer 2022-03-12 18:31:21 +08:00
xiaoyifang 5d8b410a8b fix: exception with PopupFocusReason 2022-03-11 22:26:38 +08:00
yifang fb2eac9b5e upgrade to 6.2,linux compile 2022-03-11 22:14:40 +08:00
xiaoyifang 23d833fbb8 6.2: currentIndexChanged signal is changed. 2022-03-11 22:00:53 +08:00
xiaoyifang 7b5511a7bd upgrade to qt6.2 2022-03-11 22:00:45 +08:00
xiaoyifang 3a092947da fix:popup javascript windows 2022-03-11 00:41:35 +08:00
yifang 4a96067e86 fix:large memory consumption when edit dictionaries through right menu context 2022-03-03 23:59:42 +08:00
yifang f16b25737d optimize: hide sources when edit dictionaries with specific groupid 2022-03-03 23:45:35 +08:00
yifang 0040724b6f Revert "fix:edit dictionaries dialog ,memory consume too much" 
This reverts commit c9d053d227.
 2022-03-03 23:13:04 +08:00
yifang c9d053d227 fix:edit dictionaries dialog ,memory consume too much 2022-02-28 21:21:34 +08:00
xiaoyifang d607079ffb fix: double click to translation should stop audio first. 
there are cases when the audio is too long (in wiki).
when double click occured .the audio is still playing.
 2022-02-25 23:33:34 +08:00
xiaoyifang 448f8f80a5 clean:remove hotkey dll handler 2022-02-25 23:01:54 +08:00
xiaoyifang 434dbd6e45 fix:Win+Up Win+Down to restore and save geometry 
the above shortkey can not restore geometry after resize the window
clean code .
 2022-02-25 22:54:34 +08:00
xiaoyifang aeee511859 fix:Win+Up Win+Down to restore and save geometry 
the above shortkey can not restore geometry after resize the window
 2022-02-25 22:51:39 +08:00
yifang 7e2231805f optimize: float number compare precision 
optimize: float number compare precision
 2022-02-19 01:08:20 +08:00
yifang 835e376b16 fix: typo 2022-02-18 20:43:07 +08:00
yifang cc9b64876f fix: try to fix macos close to tray issue 
can not be sure .
though the code will have not side effect.
 2022-02-18 20:22:56 +08:00
xiaoyifang 6fbadad807 clean:open dictionary folder in windows 
make windows's logic same as linux
 2022-02-16 23:00:20 +08:00
xiaoyifang 570c75e920 performance: Prefer prefix ++/-- operators for non-primitive types. 
more detail check https://hownot2code.com/2016/06/30/use-a-prefix-increment-operator-i-in-iterators-instead-of-a-postfix-i-operator/
 2022-02-16 22:08:32 +08:00
xiaoyifang 9ecc10ed50 performance: Prefer prefix ++/-- operators for non-primitive types. 
more detail check https://hownot2code.com/2016/06/30/use-a-prefix-increment-operator-i-in-iterators-instead-of-a-postfix-i-operator/
 2022-02-16 21:47:03 +08:00