mirror of
https://github.com/xiaoyifang/goldendict-ng.git
synced 2024-11-27 19:24:08 +00:00
9aa3c44d4e
* add config and GUI support for internal player back end switching;
* make FFmpeg player disabling option consistent with other similar
qmake options by using CONFIG;
* add a new qmake option that disables Qt Multimedia player. This is
useful for GNU/Linux distributions where Qt WebKit and Qt Multimedia
packages depend on different GStreamer versions and don't work
correctly when combined in one application.
The existing FFmpeg+libao internal player back end has a relatively
low-level implementation, which is difficult to understand and improve.
There are at least 3 open internal player issues:
1) many GNU/Linux users have to edit their libao configuration file to
make Goldendict's internal player work (issue #412);
2) libao's pulseaudio plugin does not support 32-bit audio, which
means that many MediaWiki pronunciations don't work with the most
popular GNU/Linux audio driver (issue #949);
3) Ffmpeg::DecoderContext uses deprecated FFmpeg APIs, which causes
compiler warnings and means that this internal player back end
may not compile with a future FFmpeg library version (issue #978).
The Qt Multimedia back end implementation uses the highest-level
Qt audio API and is very simple.
This new back end works flawlessly on my GNU/Linux machine.
I'm not making it the default back end because I don't know how well
it will work on other platforms with different configurations.
34 lines
1 KiB
C++
34 lines
1 KiB
C++
/* This file is (c) 2018 Igor Kushnir <igorkuo@gmail.com>
|
|
* Part of GoldenDict. Licensed under GPLv3 or later, see the LICENSE file */
|
|
|
|
#ifndef AUDIOPLAYERFACTORY_HH_INCLUDED
|
|
#define AUDIOPLAYERFACTORY_HH_INCLUDED
|
|
|
|
#include "audioplayerinterface.hh"
|
|
#include "config.hh"
|
|
|
|
class ExternalAudioPlayer;
|
|
|
|
class AudioPlayerFactory
|
|
{
|
|
Q_DISABLE_COPY( AudioPlayerFactory )
|
|
public:
|
|
explicit AudioPlayerFactory( Config::Preferences const & );
|
|
void setPreferences( Config::Preferences const & );
|
|
/// The returned reference to a smart pointer is valid as long as this object
|
|
/// exists. The pointer to the owned AudioPlayerInterface may change after the
|
|
/// call to setPreferences(), but it is guaranteed to never be null.
|
|
AudioPlayerPtr const & player() const { return playerPtr; }
|
|
|
|
private:
|
|
void reset();
|
|
void setAudioPlaybackProgram( ExternalAudioPlayer & externalPlayer );
|
|
|
|
bool useInternalPlayer;
|
|
Config::InternalPlayerBackend internalPlayerBackend;
|
|
QString audioPlaybackProgram;
|
|
AudioPlayerPtr playerPtr;
|
|
};
|
|
|
|
#endif // AUDIOPLAYERFACTORY_HH_INCLUDED
|