Commit graph

1204 commits

Author SHA1 Message Date
syeopite 877bb5c821
Add aliases for watch route 2021-04-06 20:36:23 -07:00
TheFrenchGhosty ae353cef2e
Merge pull request #1974 from syeopite/fix1562
Fix channel info extract for video game channels
2021-04-06 15:49:11 +00:00
syeopite 909606826d
Change footer div into footer element 2021-04-06 04:15:08 -07:00
syeopite ea16c01fa2
Fix mobile responsive design for footer 2021-04-05 20:24:02 -07:00
syeopite a8649f286c
Handle nil type for default_homepage 2021-04-04 17:19:31 -07:00
syeopite 94f285695e
Add missing closing div element 2021-04-04 16:10:27 -07:00
syeopite 428747ab69
Allow default_home config to be empty value 2021-04-04 15:20:08 -07:00
syeopite 049e8e07ef
Fix footer position to bottom of page 2021-04-04 02:45:38 -07:00
syeopite 716a845e92
Fix missing navbar search bar 2021-04-04 02:26:07 -07:00
syeopite 555108c7fd
Add styling to search bar on empty home page 2021-04-04 00:48:14 -07:00
syeopite e1af3d9bf3
Add html of search bar to empty home page 2021-04-03 23:26:58 -07:00
syeopite e864c7541c
Hide header search bar when default_home is empty 2021-04-03 21:32:30 -07:00
syeopite b4a6cbbd09
Merge info extract functions back to one 2021-04-03 20:54:10 -07:00
syeopite fe4eef5855
Fix channel info extract for 'video game' channels 2021-04-03 20:26:38 -07:00
TheFrenchGhosty c0997f951c
Merge pull request #1929 from Svallinn/channel_playlist_fix
Fix channels' playlists fetching
2021-04-03 21:21:42 +00:00
syeopite 20b961c1c8
Preserve original cookies 2021-04-02 17:08:55 -07:00
TheFrenchGhosty c4c2e01213
Merge pull request #1922 from Svallinn/search_api_fixes
Fix channels' search API
2021-04-02 05:53:41 +00:00
Samantaz Fox 62e46b7a36 Fix missing last page in playlists 2021-04-01 18:46:49 +00:00
TheFrenchGhosty 052c5c67b8
Merge pull request #1960 from syeopite/fix1959
Add new YT consent cookie to every request
2021-04-01 16:07:07 +00:00
TheFrenchGhosty b794c5cfcf
Set the request cookie to "YES+" 2021-04-01 15:59:24 +00:00
TheFrenchGhosty be8a4013a7
Merge pull request #1945 from syeopite/trending-api-fix
Fix Trending API
2021-04-01 10:22:46 +00:00
Samantaz Fox 87c25f83a4 Fix API giving ytimg instead of instance URLs for thumbnails 2021-04-01 02:36:35 +02:00
syeopite e08bea5f51
Fix lint 2021-03-31 15:34:29 -07:00
syeopite 739f610507
Add new YT consent cookie to every request 2021-03-31 14:57:00 -07:00
syeopite 608313c1d1
Update regex expressions to handle unexpected '};' 2021-03-29 17:37:12 -07:00
syeopite 8b75590d3e
Remove news trending section from ui 2021-03-28 01:25:04 -07:00
syeopite a7624d4724
Fix trending API 2021-03-27 22:48:43 -07:00
Svallinn acfa9e8a55
Parse responses to JSON instead of using regex 2021-03-26 04:17:46 +00:00
Svallinn 8823753b46
Remove commented line 2021-03-26 03:54:10 +00:00
Svallinn c5ccefe6f7
Parse response to JSON instead of using regex 2021-03-26 03:52:28 +00:00
syeopite 148071a744
Add 'www' to URL on watch on youtube button 2021-03-25 11:24:02 -07:00
syeopite 56fab9d178
Add watch on youtube button on each video item 2021-03-24 18:34:06 -07:00
syeopite f422a77014
Add translation to Audio Mode icon on vid result 2021-03-24 18:07:18 -07:00
Svallinn e248e7ebaf
Remove unused function and related test 2021-03-24 05:35:26 +00:00
Svallinn aa4c623a06
Add deprecation note 2021-03-24 05:34:23 +00:00
Svallinn cbdba66ef3
Use the youtubei API over the legacy one 2021-03-24 05:33:45 +00:00
Svallinn e49aaa0216
Fix channel search API 2021-03-24 05:15:06 +00:00
Andrew Zhao 61d49a1215 remove comments extract cursor 2021-03-24 00:08:58 -04:00
TheFrenchGhosty c481ca924b
Merge pull request #1911 from SamantazFox/fix-long-playlists
Fix long playlists (100+ videos)
2021-03-23 18:07:01 +00:00
Samantaz Fox 23e5b6ba72 Remove extra 'next page' button at then end of a playlist 2021-03-23 02:25:47 +00:00
Samantaz Fox 3e88b72316 Remove useless parameter 'youtubei_browse' in get_channel_videos_response() 2021-03-22 18:53:17 +01:00
Samantaz Fox aaefa38602 Make the linter happy 2021-03-21 16:05:50 +01:00
Samantaz Fox a61735e29a Print detailed error message when playlist can't be retrieved 2021-03-21 15:47:51 +01:00
Samantaz Fox 9bdfb0a32b Playlist: Support edge case where 'content' in JSON may be erroneously plural 2021-03-21 15:47:44 +01:00
Samantaz Fox 94ecd29e35 Make use of youtube API helper in src/invidious/channels.cr 2021-03-21 15:47:26 +01:00
Samantaz Fox 980f5f1299 Playlist: Fix video continuation (100+ videos playlists) 2021-03-21 15:47:03 +01:00
Samantaz Fox f99d62a2bc Create youtube API wrapper fo /youtubei/v1/browse 2021-03-21 15:44:18 +01:00
Samantaz Fox 89be1975ea Playlist: Fix continuation token generation 2021-03-21 15:43:49 +01:00
Samantaz Fox fec82df451 Fix fetching of large playlist 2021-03-21 00:15:39 +01:00
Andrew Zhao 89fd35e02d fix comment replies 2021-03-20 00:43:12 -04:00
TheFrenchGhosty 3286328de4
Merge pull request #1837 from syeopite/master
Enhance search filter UI for JS disabled users
2021-03-19 20:32:27 +00:00
syeopite 977c34c0d7
Remove unused script element in search.ecr 2021-03-19 11:33:27 -07:00
syeopite 48a3c3a0c1
Add hover state to filter UI 2021-03-13 10:57:27 -08:00
syeopite b56ebd13b6
Fix indent in search.ecr for filters 2021-03-13 09:14:55 -08:00
Samantaz Fox 3de39698dd Make the build tests happy: remove blank lines 2021-03-11 03:46:17 +00:00
Samantaz Fox b86476410f playlists: Fix description being simple text (issue #1767) 2021-03-11 00:44:35 +00:00
Samantaz Fox 57ea45ff51 content_to_comment_html: Fix /watch links + make newline replace universal 2021-03-11 00:42:13 +00:00
TheFrenchGhosty ec30f7c5d4
Merge pull request #1849 from saltycrys/channels
WIP channels fix
2021-03-06 10:06:20 +01:00
TheFrenchGhosty 790167e914
Merge pull request #1832 from mark9064/patch-1
Fix engagement
2021-03-05 01:00:42 +01:00
saltycrys 378c0d049e WIP channels fix 2021-03-03 22:21:29 +01:00
Perflyst fc8c555519
Merge pull request #1729 from Rjevski/12factor-database-url-restored
Support "Database URL" in addition to existing DB-related parameters
2021-03-02 18:41:10 +01:00
syeopite 83b5fd252e
Enhance search filter UI for JS disabled users
Change filters UI box to use <details>.

Stylize detail button for filter ui

Fix localization for 'filter'

Fix CSS

Fix styling
2021-03-01 03:45:07 -08:00
mark9064 9ae18b0b3b
Fix engagement
Engagement was calculated as 0-1 but displayed as a percentage
2021-02-28 11:59:46 +00:00
Andrew Zhao 2600695927 fix search
Put search page in the super secret proto field
2021-02-25 22:19:22 -05:00
TheFrenchGhosty 705e4fca06
Merge pull request #1797 from B0pol/published_utc
Use UTC for published date
2021-02-25 17:57:02 +01:00
TheFrenchGhosty a4ba4cf6ce
Merge pull request #1795 from B0pol/comments
Fix comment replies count
2021-02-25 17:56:30 +01:00
TheFrenchGhosty 0b2109576a
Merge pull request #1804 from tenpura-shrimp/captionpreload
do not preload captions
2021-02-25 17:54:28 +01:00
Andrew Zhao 295e5c9731 show how long ago stream started 2021-02-24 23:08:04 -05:00
Andrew Zhao 9b79e35d52 do not preload captions 2021-02-24 01:02:55 -05:00
bopol 237100da18 Use UTC for published date 2021-02-21 12:35:21 +01:00
bopol 1e33c0c288 Fix comment replies count 2021-02-21 00:09:04 +01:00
saltycrys 2bf445e165 Fix playlists with Various Artists author 2021-02-10 01:04:27 +01:00
Andrew Zhao 148f3002ec use large thumbnail for channels in search 2021-02-04 18:20:49 -05:00
Perflyst ec82c1f957
Merge pull request #1730 from notpushkin/patch-1
Add link[rel="alternate"] pointing to YouTube version
2021-02-04 07:55:39 +01:00
saltycrys 5f03a583d1 Update code for Crystal 0.36.0
Rename `HTTPClient@socket` to `HTTPClient@io`, see
https://github.com/crystal-lang/crystal/pull/9543.

Rename `URI#full_path` to `URI#request_target`, see
https://github.com/crystal-lang/crystal/pull/10099.
2021-02-02 20:01:02 +01:00
saltycrys 991a04dc2a Adjust routes
Simple routes have been moved into a single `Misc` file.

Embed routes have been moved into a single `Embed` file.

The preferences route has been renamed to be more consistent with other parts
of the codebase.
2021-02-02 06:18:16 +01:00
Perflyst 82da5cfd01
Merge pull request #1712 from tenpura-shrimp/bumpvideojs
Bump videojs and fix webworker
2021-01-31 12:18:40 +01:00
saltycrys 909285ea46
Merge pull request #1732 from saltycrys/unrequire-logger
Unrequire `logger`
2021-01-31 03:48:29 +01:00
saltycrys a0bc0641c7 Unrequire logger
Crystal's `Logger` was required but never used in Invidious. Crystal 0.36.0
removed `Logger` in favor of `Log`.
2021-01-31 03:33:38 +01:00
Alexander Pushkov e7ada61881
Add link[rel="alternate"] pointing to YouTube version 2021-01-30 23:45:55 +00:00
Andre Borie 79e99908de Allow providing 12-Factor-style Database URL in config 2021-01-30 19:33:58 +00:00
saltycrys c9a316ad35
Merge pull request #1702 from saltycrys/config
Config improvements
2021-01-30 14:46:10 +01:00
Andrew Zhao 4a0b10984a Bump videojs and fix webworker 2021-01-29 19:08:28 -05:00
Andrew Zhao d0dbbd1cb1 remove https from channel thumbnail in search 2021-01-28 00:51:14 -05:00
saltycrys b45f371911 Make config a constant
Instead of passing around `config` there is now the global `CONFIG`.
2021-01-23 19:39:04 +01:00
saltycrys f1a7ee997b Add config environment variables
The config file can now be specified with `INVIDIOUS_CONFIG_FILE`.
A YAML formatted string can still be passed with `INVIDIOUS_CONFIG`, replacing
the config file.

Additionally all options can now be specified as environment variables.
The syntax for variable names is `INVIDIOUS_` followed by the option name in
upper case. The values are parsed as YAML.

These new env vars only update the provided main configuration, but it is
possible to point the config file at the example config and then use env vars
for all config options:
```
INVIDIOUS_CONFIG_FILE=./config/config.example.yml \
INVIDIOUS_CHANNEL_THREADS=10 \
./invidious
```
2021-01-23 18:58:13 +01:00
Andrew Zhao 15ba3325d9 add ui for searching 2021-01-17 14:33:49 -05:00
HackerNCoder 606dd11b4f
Remove admin_email. Use repos url for captcha ID and reddit header. Add note about not updating changelog 2021-01-07 21:09:24 +01:00
HackerNCoder 4d512d908d
Remove some mentions of omarroth 2021-01-07 19:01:13 +01:00
saltycrys df9e7f284c Adjust log verbosity
The default log level has been changed from `debug` to `info`.
The `debug` log level is now more verbose. `debug` now gives a general overview
of what is happening (where implemented) while `trace` gives all available
details.
2021-01-05 20:51:18 +01:00
saltycrys 6365ee7487 Make logger a constant
Instead of passing around `logger` there is now the global `LOGGER`.
2021-01-05 20:43:19 +01:00
saltycrys 7a8620a570 Add CLI arguments to config file
The log level can now be set with `log_level` (accepts ints and strings).
The log file can now be set with `output` (also accepts `STDOUT`).
2021-01-05 20:35:59 +01:00
Perflyst 2c24bf3222
Merge pull request #1389 from vhuynh3000/decrypt_on_demand
add config to decrypt on demand instead of polling
2021-01-05 19:32:22 +01:00
saltycrys 36e9fb9d68 Fix watch_videos endpoint
Playlists created by `watch_videos` do not have an author which caused a crash
previously.
2021-01-04 05:35:59 +01:00
saltycrys 8b56a038b7 Set content type for HTML error helpers
This fixes `Unexpected char '<' at 1:1` errors caused by content type mismatch.
2021-01-04 05:24:08 +01:00
vhuynh3000 3a2bd4e928 add config to decrypt on demand instead of polling 2021-01-03 20:50:52 +01:00
Perflyst 28dac81a90
Merge pull request #999 from notpushkin/patch-1
Add audio mode link to items
2021-01-03 13:58:23 +01:00
Perflyst c89632d2a8
Merge pull request #1608 from saltycrys/add-subscription-traces
Add Subscription Traces
2020-12-31 11:30:04 +01:00
TheFrenchGhosty 82c8f3b556
Merge pull request #1600 from jksladjflkjsadflkjsadf/closeclients
Close http clients after use
2020-12-30 01:14:31 +00:00
bopol 608b9e66f4 fix channel/ID/community endpoint
fixes https://github.com/iv-org/invidious/issues/1611
2020-12-30 01:09:39 +01:00
saltycrys dfd5e30015 Fix Video Mode Button
The query params that get edited for `embed_params` are now deep copied instead
of shallow copied, preventing the originals from being changed.
2020-12-29 01:22:56 +01:00
Perflyst b19524d56a
Merge pull request #1609 from saltycrys/add-popular-enabled-option
Add `popular-enabled` option
2020-12-28 11:30:55 +01:00
Andrew Zhao e0d25ff887 Close http clients after using
The crystal http client maintains a keepalive connection to the other
server which stays alive for some time. This should be closed if the
client instance is not used again to avoid hogging resources
2020-12-27 19:40:58 -05:00
saltycrys 198dfffaeb Add popular-enabled option
This is similar to the removed `top-enabled` option but for the Popular feed.
The instance needs to be restarted if the feed was enabled.

Editing admin options on the preferences page is also fixed.

The handling of the feed pages now only happens in a single place.

Instead of redirecting:
  - The Top feed now displays a message that it was removed from Invidious.
  - The Popular feed now displays a message that it was disabled if it was.
2020-12-27 06:12:43 +01:00
saltycrys c4ef055248 Add RefreshChannelsJob traces
Traces can be enabled with `-l trace`.

The problem with subscriptions is that sometimes requests to YouTube never
finish. As soon as that happens `channel-threads` times subscriptions stop
being refreshed. This is most likely a problem with the lsquick bindings.
2020-12-27 05:20:33 +01:00
saltycrys 420ceffbb0 Rename threads to fibers
The config and command line options haven't been changed.
2020-12-27 05:14:33 +01:00
Perflyst eeeecf9763
Merge pull request #1572 from saltycrys/add-dash-quality-preference
Add DASH quality preference
2020-12-23 20:36:13 +01:00
Perflyst 8df591e8d4
Merge pull request #1595 from saltycrys/improve-storyboards
Improve storyboards
2020-12-23 14:30:10 +01:00
saltycrys 75c6844b66 Improve storyboards
Instead of limiting the width of storyboards through CSS it is now done in the
VTT directly.
2020-12-21 17:02:36 +01:00
saltycrys b39f01dcdf Improve logging
Everything that gets logged now has a log level associated with it.

The log level can be set with the new `-l` or `--log-level` arguments.

The defaul log level is `debug` for now. There aren't many things that get
logged but if the logs get spammed in the future it can be set down to `info`.
2020-12-21 16:32:34 +01:00
saltycrys ef96a50cea Remove "Top" feed option from preferences
The Top feed used to be a feed based on YouTube ratings. Once YouTube removed
publicly available ratings the Top feed was removed from Invidious but the
option to display a link to it remained.
2020-12-19 19:30:42 +01:00
saltycrys eed78c960d Improve DASH quality preference
Besides `auto`, `best` and `worst` it is now possible to select a target height.
If the target height is not available the closest lower height is selected.
2020-12-19 18:37:41 +01:00
saltycrys eea7ca9b72 Add DASH quality preference
The options are `auto` (the current and default behavior), `best` and `worst`.

The UI is only updated once playback starts.
2020-12-19 18:37:30 +01:00
Matthew McGarvey fb06482916 Extract out User Preferences endpoints 2020-12-15 18:54:30 -06:00
TheFrenchGhosty 2349a6ab0c Actually fix the icons of #1564 but for real this time 2020-12-09 20:21:42 +01:00
TheFrenchGhosty 70eaf41acb Actually fix the icons of #1564 by using an icon that exist in ionicons v4 2020-12-09 20:14:06 +01:00
TheFrenchGhosty 912091981e Fix the icons of #1564 and remove a useless line 2020-12-09 20:04:59 +01:00
TheFrenchGhosty aca42ff6a5
Update the cryptocurrency addresses and replace the Liberapay link with a link to the documentation (#1564)
* Update the cryptocurrency address with newly created one

* Replace the icon used for the donation address and link

* Replace the word Monero with the word XMR

* Replace the Liberapay placeholder with a link to the documentation
2020-12-09 19:43:45 +01:00
Matthew McGarvey 2dacdf0210 Extract login/signout routes from global file 2020-12-08 20:50:39 -06:00
TheFrenchGhosty 5e8856e65b
Merge pull request #1551 from saltycrys/add-embed-link
Add embed link to watch page
2020-12-08 21:30:13 +00:00
saltycrys d42539949e Add YT embed link to watch page 2020-12-08 19:10:29 +01:00
TheFrenchGhosty 28ca5b2b57
Merge pull request #1552 from azhao-squareup/master
do not proxy hls livestrem on supported browser
2020-12-08 18:00:36 +00:00
Andrew Zhao 0cb442d40e do not proxy hls on supported browser 2020-12-08 00:53:48 -05:00
saltycrys 30c92ce1b7 Add embed link to watch page 2020-12-08 02:28:44 +01:00
saltycrys e55a09241e Fix Invidious playlist continuation
Playing a video in a Invidious playlist now correctly redirects to the next
video. The problem was that the offset was updated in the wrong place.
2020-12-07 22:28:27 +01:00
TheFrenchGhosty 68552b6d65
Merge pull request #1544 from schwukas/fix-youtube-subscription-import
Fix youtube subscription import
2020-12-07 17:03:57 +00:00
Lukas 77c13e10ec Update link to instructions 2020-12-07 13:34:40 +01:00
Lukas 0f66ff50a4 Fix #1516 Document is empty 2020-12-07 13:10:00 +01:00
Lukas cb40a74aaf Add temporary link to subscription export instructions 2020-12-06 21:46:58 +01:00
saltycrys 2de206cb81 Fix comments
The YouTube headers are now always added for requests to YouTube.
Previously they were only added for requests going through QUIC.

The session token is now JSON decoded to unescape escaped Unicode characters.

The comment continuation protobuf has been updated and the request now goes
through the YouTube `pbj` JSON API.
2020-12-06 04:11:41 +01:00
TheFrenchGhosty 76cad41382
Merge pull request #1525 from saltycrys/fix-video-descriptions
Fix `extract_polymer_config`
2020-12-03 23:31:39 +00:00
saltycrys cc684ff0b1 Fix redirect channels
Redirect channels may use JS to redirect now, instead of only a response header
as it used to be. This fix reads the channel to redirect to from `ytInitialData`.
2020-12-03 21:02:52 +01:00
saltycrys 7823c07f1a Fix extract_polymer_config
The `ytInitialPlayerResponse` regex can now handle `var` and `window`
assignments.

The video streams can now be extracted from `player_response` and
`initial_data`.

This fixes the descriptions on videos and videos themselves. Videos are
technically broken right now, but work becasue of a fallback that goes through
embeds.
2020-12-03 18:10:41 +01:00
Matthew McGarvey d7377015a2 Extracting search endpoints 2020-12-01 18:02:39 -06:00
saltycrys b409cdece5 Improve error message 2
Electric Boogaloo

The long backtrace has been moved into a `<details>` HTML element, as suggested
by @B0pol. To make the error still visible it has been added to the top under
`Title:`. This also encourages informative issue titles.
2020-12-01 13:41:19 +01:00
Théo Gaillard df3f9a2ae8
fix: channel info parsing 2020-11-30 19:35:45 +01:00
TheFrenchGhosty ca781651cb Fix formatting of #1504 2020-11-30 15:56:01 +01:00
saltycrys 92bb477f68 Improve error message
The error message has been reworded and the issue template now includes the
date, route, version and backtrace.
2020-11-30 13:02:35 +01:00
saltycrys 0f08cc5aa9 Remove backtrace on YouTube error
YouTube returning an error is not a bug in Invidious, so it should not print
a backtrace.
2020-11-30 12:57:25 +01:00
saltycrys 3dac33ffba
Add backtraces to errors (#1498)
Error handling has been reworked to always go through the new `error_template`,
`error_json` and `error_atom` macros.
They all accept a status code followed by a string message or an exception
object. `error_json` accepts a hash with additional fields as third argument.

If the second argument is an exception a backtrace will be printed, if it is a
string only the string is printed. Since up till now only the exception message
was printed a new `InfoException` class was added for situations where no
backtrace is intended but a string cannot be used.

`error_template` with a string message automatically localizes the message.
Missing error translations have been collected in https://github.com/iv-org/invidious/issues/1497
`error_json` with a string message does not localize the message. This is the
same as previous behavior. If translations are desired for `error_json` they
can be added easily but those error messages have not been collected yet.

Uncaught exceptions previously only printed a generic message ("Looks like
you've found a bug in Invidious. [...]"). They still print that message
but now also include a backtrace.
2020-11-30 10:59:21 +01:00
TheFrenchGhosty fe73eccb90
Merge pull request #1479 from saltycrys/theme-flash
Apply dark theme immediately
2020-11-28 20:54:45 +00:00
Théo Gaillard b41ca72d2b
revert: remove 'JSON.parse("' 2020-11-26 18:22:31 +01:00
Théo Gaillard 1ba17a0e14
feat: centralize ytInitialData parsing 2020-11-26 13:43:53 +01:00
Théo Gaillard 480d31eb5e
fix: ytInitialData parsing with regex 2020-11-26 07:22:47 +01:00
TheFrenchGhosty 1973f93d4a
Merge pull request #1482 from matthewmcgarvey/extract-playlist-routes
Extract playlist routes from global file
2020-11-20 21:48:34 +00:00
Émilien Devos 3a2f4d4def
allow to set a custom anti-captcha api url (#1473) 2020-11-20 22:21:26 +01:00
Matthew McGarvey 192d2b86b6 Extract playlist routes from global file 2020-11-19 19:21:48 -06:00
TheFrenchGhosty 6ca948ac3c
Merge pull request #1477 from saltycrys/empty-preference-values
Fill empty preference values
2020-11-19 21:45:00 +00:00
saltycrys ff46c18164 Move themes into default.css
Now that themes are controlled with a class instead of setting
media="none" on the stylesheet link and both themes already being
duplicated in default.css for the automatic themeing it makes sense
to have all theme related CSS in the same place.

This commit also fixes the missing dark theme on embeds.
2020-11-17 22:53:45 +01:00
saltycrys de777907f2 Apply dark theme immediately
Themes are now controlled with a class on the body element.

If a preference is set the body element will have either "dark-theme"
or "light-theme" class. If no preference is set or the preference is
empty the class will be "no-theme".

"dark-theme" and "light-theme" are handled by darktheme.css and
lighttheme.css respectively.

"no-theme" is handled by default.css where depending on the value of
"prefers-color-scheme" the styles corresponding to "dark-theme" or
"light-theme" are applied.

Unfortunately this means that both themes are duplicated, once in the
theme .css and once in default.css.
2020-11-16 04:19:41 +01:00