Commit graph

4169 commits

Author SHA1 Message Date
Samantaz Fox 84cc732281
search functions: Don't return result count
This is useless, as the items count can be directly acessed
using the '.size' method, so use that instead when needed.
2022-01-28 02:22:36 +01:00
Samantaz Fox 971b6ec96f
Fix 'Lint/UselessAssign' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 46f7ca9ffa
Remove useless intermediary variable in youtube_api.cr
This fixes an ameba warning
2022-01-28 02:19:53 +01:00
Samantaz Fox e85bc3e0f6
Remove script for locales propagation
Not required anymore now that weblate takes care of it
2022-01-28 02:19:53 +01:00
Samantaz Fox dee20f92a7
Avoid infinite loop in ChannelVideo's to_xml/to_json methods 2022-01-28 02:19:53 +01:00
Samantaz Fox 12b818a83c
Fix more 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 1c91110464
Fix some 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 4cd7a3e83f
Remove useless 'locale = env.get...' from many routes 2022-01-28 02:19:53 +01:00
Samantaz Fox fa99c9aa85
Use '.dig?()' in playlist parsing 2022-01-28 02:19:53 +01:00
Samantaz Fox 2d949834e9
Make 'additional_fields' optional in JSON error template functions
This allows us to de-duplicate functions
2022-01-28 02:19:53 +01:00
Samantaz Fox c7b74aa8b4
Remove useless 'locale' argument from error template functions 2022-01-28 02:19:53 +01:00
Samantaz Fox 5e3c9cf290
Remove useless arguments from playlist-related functions 2022-01-28 02:19:53 +01:00
Samantaz Fox 508f137b30
Merge pull request #2666 from matthewmcgarvey/extract-stuff-1
Move more routes to new pattern
2022-01-28 02:12:35 +01:00
Samantaz Fox 67dd2b419a
db: use prepared statements rather than crafted argument list 2022-01-26 17:31:01 +01:00
Samantaz Fox 0749baae4b
Makefile: Fix 'STATIC' in help message
Fix description (typo) and default value
2022-01-26 13:24:40 +01:00
matthewmcgarvey df9f897ebe Fix code broken when extracting data control route 2022-01-25 19:28:16 -06:00
matthewmcgarvey 8ef1e81294 Make certain routes ignored if api only 2022-01-25 19:10:18 -06:00
matthewmcgarvey d755d05f88 Move more routes to new pattern 2022-01-25 19:10:18 -06:00
Samantaz Fox ce4a52325b
db: use now() function instead of passing Time.utc 2022-01-26 01:49:29 +01:00
Samantaz Fox 714a001332
DB: playlists: make that 'insert' never raises 2022-01-25 23:53:00 +01:00
Samantaz Fox c78f84d5c6
DB: Move integrity check to the base.cr file 2022-01-25 23:53:00 +01:00
Samantaz Fox a6c9b263da
DB: don't pass PG_DB to check_table/check_enum 2022-01-25 23:53:00 +01:00
Samantaz Fox 5ad2fc64b4
DB: Move a forgotten 'UPDATE channels' statement 2022-01-25 23:42:36 +01:00
Samantaz Fox 2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search
Handle invalid channel id in channel: search
2022-01-25 19:34:43 +01:00
Matthew McGarvey c5967ad572
will -> should
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2022-01-25 11:35:19 -06:00
Samantaz Fox 5ece07a807
Merge pull request #2841 from iv-org/SamantazFox-remove-note-quic
config: remove note about QUIC disabled at Google
2022-01-25 14:24:36 +01:00
Samantaz Fox e00f9a869d
config: remove note about QUIC disabled at Google
The situation is back to normal.
2022-01-25 13:53:46 +01:00
Samantaz Fox 662cf2f633
Merge pull request #2826 from weblate/weblate-invidious-translations
Translations update from Hosted Weblate
2022-01-25 01:43:14 +01:00
Hosted Weblate 16f1a23c54
Update Portuguese (Brazil) translation
Update Portuguese (Brazil) translation

Co-authored-by: André Marcelo Alvarenga <andrealvarenga@gmx.net>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kamuri Amorim <myk.gata14@gmail.com>
2022-01-25 01:15:12 +01:00
Hosted Weblate fb364b532c
Update Croatian translation
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Milo Ivir <mail@milotype.de>
2022-01-25 01:15:12 +01:00
Hosted Weblate 2bebf578c7
Update French translation
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Samantaz Fox <translator-weblate@samantaz.fr>
2022-01-25 01:15:12 +01:00
Hosted Weblate a5b9c83256
Update Japanese translation
Co-authored-by: GnuPGを使うべきだ <dieeeazpnnqbpddh@cock.email>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
2022-01-25 01:15:12 +01:00
Hosted Weblate dc0e242a63
Update Polish translation
Co-authored-by: skajmer <skajmer@protonmail.com>
2022-01-25 01:15:12 +01:00
Hosted Weblate 178e317d11
Update Chinese (Traditional) translation
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
2022-01-25 01:15:12 +01:00
Hosted Weblate 3aa740d877
Update Chinese (Simplified) translation
Co-authored-by: Eric <alchemillatruth@purelymail.com>
2022-01-25 01:15:12 +01:00
Hosted Weblate 951d7d8339
Update Turkish translation
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
2022-01-25 01:15:12 +01:00
Hosted Weblate b5bd1f507e
Update Hungarian translation
Co-authored-by: f3rr31 <5920873@disroot.org>
2022-01-25 01:15:12 +01:00
Hosted Weblate 7b9368ae75
Update Spanish translation
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Jorge Maldonado Ventura <jorgesumle@freakspot.net>
2022-01-25 01:15:12 +01:00
Samantaz Fox b2c3d9fb0a
Merge pull request #2828 from SamantazFox/add-ameba-shard
Add Ameba static code analysis tool to dev shards
2022-01-25 01:15:06 +01:00
テクニカル諏訪子 3af2165f18 Merge branch 'master' of github.com:iv-org/invidious 2022-01-25 02:00:09 +09:00
Samantaz Fox 6bd48ca645
Merge pull request #2832 from tonyfinn/patch-1
Specify the public schema for playlist videos migration
2022-01-24 14:18:08 +01:00
テクニカル諏訪子 706967ed4e Merge branch 'master' of github.com:iv-org/invidious 2022-01-22 12:25:28 +09:00
Tony Finn cdc007c83c
Specify the public schema for public videos
Unlike the other migrations, this one uses a bare table name to specify the table. This means it looks in the default search path. Unfortunately, the out of box search path is:

1. Schema with the same name as the user
2. Public

Because of this, if a schema exists with the same name as the DB user, the playlist_videos table will get created in _that_ schema, rather than the public schema, and then the grant statement will fail with an error like below if check_table is enabled as it keeps trying to create the table but failing on the grant statement:

```
2022-01-22 02:27:42 UTC [info] check_table: check_table: CREATE TABLE playlist_videos
Unhandled exception: relation "public.playlist_videos" does not exist (PQ::PQError)
  from /usr/share/crystal/src/primitives.cr:266:3 in 'handle_error'
  from lib/pg/src/pq/connection.cr:184:9 in 'handle_async_frames'
  from lib/pg/src/pq/connection.cr:162:7 in 'read'
  from lib/pg/src/pq/query.cr:53:14 in 'exec_all'
  from lib/db/src/db/database.cr:126:9 in '__crystal_main'
  from /usr/share/crystal/src/crystal/main.cr:110:5 in 'main'
  from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'
2022-01-22 02:27:43 UTC [info] check_table: check_table: CREATE TABLE playlist_videos
Unhandled exception: relation "public.playlist_videos" does not exist (PQ::PQError)
  from /usr/share/crystal/src/primitives.cr:266:3 in 'handle_error'
  from lib/pg/src/pq/connection.cr:184:9 in 'handle_async_frames'
  from lib/pg/src/pq/connection.cr:162:7 in 'read'
  from lib/pg/src/pq/query.cr:53:14 in 'exec_all'
  from lib/db/src/db/database.cr:126:9 in '__crystal_main'
  from /usr/share/crystal/src/crystal/main.cr:110:5 in 'main'
  from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'
```
2022-01-22 02:32:13 +00:00
Samantaz Fox 7dbbe27cdd
Use --production flag for shards installation on docker 2022-01-20 22:33:34 +01:00
Samantaz Fox b91874355c
Add Ameba static code analysis tool to dev shards 2022-01-20 22:25:01 +01:00
TheFrenchGhosty 8b0ed8b110
Create FUNDING.yml 2022-01-19 20:43:52 +00:00
matthewmcgarvey 574e35a720 HTML escape user input 2022-01-19 09:01:13 -06:00
Samantaz Fox 32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments
Fix loading reddit comments when there are no threads found
2022-01-19 12:53:20 +01:00
matthewmcgarvey 56e505164d 404 error with message and provide example 2022-01-18 18:56:26 -06:00
matthewmcgarvey d4f3139b73 Don't catch and provide better error message instead 2022-01-18 18:37:16 -06:00