Commit graph

2314 commits

Author SHA1 Message Date
Samantaz Fox 7112f35793
comments: don't error out when video has no comments
continuationItems is nil when video has no comments
2022-02-14 21:54:26 +01:00
Féry Mathieu (Mathius) 7048193f00
Move store of modification in Cookie instead of localStorage 2022-02-14 17:22:06 +01:00
Féry Mathieu (Mathius) c952754c8c
Add videojs-persist plugin 2022-02-14 17:01:10 +01:00
Samantaz Fox 85ba04b715
Merge pull request #2871 from SamantazFox/user-code-cleaning
User code cleaning & fixing
2022-02-14 15:38:05 +01:00
Samantaz Fox 8af202e86b
Merge pull request #2892 from matthewmcgarvey/video-playability
Raise error if video not playable, also handle missing related videos
2022-02-14 00:59:07 +01:00
Samantaz Fox 57353fe0c6
Fix Freetube subscriptions import 2022-02-13 22:40:51 +01:00
Samantaz Fox 60e870b277
Fix OPML import 2022-02-12 17:32:20 +01:00
matthewmcgarvey bf054dfda5 Do not check for pending migrations on app start
This is so that we don't break deploys with this PR.
Instead we only ship the 'invidious --migrate' cli command
and let people test that. Maybe even ship a new migration that wouldn't break
apps that don't run the migrations. Then we roll out the functionality
that requires migrations.
2022-02-12 09:20:43 -06:00
matthewmcgarvey 59654289cb Run migrations through CLI instead of when app starts 2022-02-11 22:43:16 -06:00
matthewmcgarvey cf13c11236 Migrations tweaks 2022-02-11 22:29:19 -06:00
matthewmcgarvey ddf1e84f7c Raise exception if playability not ok, also handle missing related videos 2022-02-10 23:43:14 -06:00
Samantaz Fox 01135db80a
video_playback: Check "host" parameter validity 2022-02-11 02:04:05 +01:00
Samantaz Fox cdd473e195
DB: fix inverted arguments in User.update_password()
Closes https://github.com/iv-org/invidious/issues/2875
2022-02-10 19:52:45 +01:00
Samantaz Fox da10cdd5ab
Merge pull request #2872 from SamantazFox/misaligned-captions
Use a regex to fix badly aligned captions
2022-02-10 18:38:59 +01:00
matthewmcgarvey 8ec992a8a3 Add custom migration implementation 2022-02-09 00:50:32 -06:00
Samantaz Fox ec55b905cb
Fix empty error page on BrokenTubeException 2022-02-09 01:36:17 +01:00
Samantaz Fox 492d1144e0
Apply changes from code review 2022-02-08 03:05:49 +01:00
Samantaz Fox 4f4b19a962
embed page: fix typo in videojs-overlay script URL 2022-02-08 02:41:08 +01:00
Samantaz Fox febd785428
Add missing subtitle languages 2022-02-08 02:13:14 +01:00
Samantaz Fox 76cc8ac66b
HTML escape error message 2022-02-08 01:48:44 +01:00
Samantaz Fox f73aef33f0
Add compile option to disable fetching of player dependencies 2022-02-07 22:45:08 +01:00
Samantaz Fox d12dff9dcf
Use a regex to fix badly aligned captions 2022-02-07 22:18:24 +01:00
Samantaz Fox 99d770be64
Move user pages (ECR files) to subfolder 2022-02-07 17:39:15 +01:00
Samantaz Fox 71a8867a4a
Move user cookies to their own module 2022-02-07 17:39:15 +01:00
Samantaz Fox 2bbd424fce
Move import logic to its own module 2022-02-07 17:38:50 +01:00
Samantaz Fox ef8dc7272b
Put CSV import function under its own module 2022-02-07 17:15:22 +01:00
Samantaz Fox ad4a06fca5
Move user captcha code to its own module 2022-02-07 17:15:22 +01:00
Samantaz Fox c04f45d5e3
Move user struct to own file, under Invidious namespace 2022-02-07 17:15:22 +01:00
Samantaz Fox fb36155022
Move user routes definitions to a macro in routing.cr 2022-02-07 17:15:21 +01:00
Samantaz Fox 7ace3fc989
Move remaining user-related routes out of main file 2022-02-07 17:15:21 +01:00
Samantaz Fox 170e754998
Merge pull request #2868 from SamantazFox/related-channels-items-fix
Related channel may contain a continuation entry
2022-02-07 16:54:44 +01:00
Samantaz Fox 6a75fa08dc
Merge pull request #2492 from mastihios/patch-input-html-escape
Change <input value="..."> encoding to HTML.escape
2022-02-07 16:53:43 +01:00
Dimitris Apostolou 7e4690e43c
Fix typos 2022-02-07 14:57:14 +02:00
Samantaz Fox 698a6f3886
API: handle related channels parsing exceptions 2022-02-07 00:52:18 +01:00
Samantaz Fox 1668e4187e
Related channel may contain a continuation entry 2022-02-07 00:37:47 +01:00
Samantaz Fox ba37259258
Also propagate changes to watch ECR page 2022-02-03 04:24:31 +01:00
Samantaz Fox eca8d2e7d7
Apply suggestions from code review
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
2022-02-03 03:55:43 +01:00
mastihios cb0f7bf6b0
Change <input value="..."> encoding to HTML.escape 2022-02-03 01:47:18 +01:00
Samantaz Fox 1ec15dc073
Propagate related videos changes to API function 2022-02-03 01:44:11 +01:00
Samantaz Fox f124e8cf93
Fix parsing of related videos 2022-02-03 01:37:30 +01:00
Samantaz Fox 9621175dc9
extractors: Add helper for short view count text 2022-02-03 01:37:30 +01:00
Samantaz Fox e6ddd6d6c1
make HelperExtractors non-private 2022-02-03 01:37:30 +01:00
Samantaz Fox d7ebd763f5
video parsing: add secondary_results root element 2022-02-03 01:37:30 +01:00
Samantaz Fox 99091e919c
video parsing: raise if major root element is missing 2022-02-03 01:37:30 +01:00
Samantaz Fox 6ddbccbc95
Add new exception for parsing issues 2022-02-03 01:37:23 +01:00
Samantaz Fox 4e44a91d08
Add support for clips 2022-02-02 00:41:02 +01:00
Samantaz Fox fc5f84a0cd
Merge pull request #2827 from SamantazFox/more-code-cleanup
More code cleanup
2022-02-02 00:36:19 +01:00
Samantaz Fox d546f1870e
Merge pull request #2845 from SamantazFox/more-db-improvements
More db improvements
2022-01-30 23:34:48 +01:00
Samantaz Fox f5cb7ba96c
Merge pull request #2833 from matthewmcgarvey/get-channel-cleanup
Channel helpers cleanup
2022-01-30 23:16:15 +01:00
Samantaz Fox 519c227c4f
Use short syntax for 'File.open' block 2022-01-29 13:43:26 +01:00
Samantaz Fox 6f4665588f
search.cr: use do/end rather than inline {} block 2022-01-28 15:54:38 +01:00
Samantaz Fox eba311baa9
Merge pull request #2397 from syeopite/dep-manager-for-videojs-stuff
Add dependency manager script for videojs stuff
2022-01-28 15:30:13 +01:00
matthewmcgarvey e92b3779ad Add back in refreshing of channels every 2 days 2022-01-27 20:12:45 -06:00
matthewmcgarvey a82d21ff78 Cleanup channel helpers code 2022-01-27 20:12:42 -06:00
Samantaz Fox 63e1165936
videos.cr: use '.dig?()' where possible 2022-01-28 02:22:48 +01:00
Samantaz Fox 84cc732281
search functions: Don't return result count
This is useless, as the items count can be directly acessed
using the '.size' method, so use that instead when needed.
2022-01-28 02:22:36 +01:00
Samantaz Fox 971b6ec96f
Fix 'Lint/UselessAssign' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 46f7ca9ffa
Remove useless intermediary variable in youtube_api.cr
This fixes an ameba warning
2022-01-28 02:19:53 +01:00
Samantaz Fox dee20f92a7
Avoid infinite loop in ChannelVideo's to_xml/to_json methods 2022-01-28 02:19:53 +01:00
Samantaz Fox 12b818a83c
Fix more 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 1c91110464
Fix some 'Lint/ShadowingOuterLocalVar' warnings reported by ameba 2022-01-28 02:19:53 +01:00
Samantaz Fox 4cd7a3e83f
Remove useless 'locale = env.get...' from many routes 2022-01-28 02:19:53 +01:00
Samantaz Fox fa99c9aa85
Use '.dig?()' in playlist parsing 2022-01-28 02:19:53 +01:00
Samantaz Fox 2d949834e9
Make 'additional_fields' optional in JSON error template functions
This allows us to de-duplicate functions
2022-01-28 02:19:53 +01:00
Samantaz Fox c7b74aa8b4
Remove useless 'locale' argument from error template functions 2022-01-28 02:19:53 +01:00
Samantaz Fox 5e3c9cf290
Remove useless arguments from playlist-related functions 2022-01-28 02:19:53 +01:00
Samantaz Fox 67dd2b419a
db: use prepared statements rather than crafted argument list 2022-01-26 17:31:01 +01:00
matthewmcgarvey df9f897ebe Fix code broken when extracting data control route 2022-01-25 19:28:16 -06:00
matthewmcgarvey 8ef1e81294 Make certain routes ignored if api only 2022-01-25 19:10:18 -06:00
matthewmcgarvey d755d05f88 Move more routes to new pattern 2022-01-25 19:10:18 -06:00
Samantaz Fox ce4a52325b
db: use now() function instead of passing Time.utc 2022-01-26 01:49:29 +01:00
Samantaz Fox 714a001332
DB: playlists: make that 'insert' never raises 2022-01-25 23:53:00 +01:00
Samantaz Fox c78f84d5c6
DB: Move integrity check to the base.cr file 2022-01-25 23:53:00 +01:00
Samantaz Fox a6c9b263da
DB: don't pass PG_DB to check_table/check_enum 2022-01-25 23:53:00 +01:00
Samantaz Fox 5ad2fc64b4
DB: Move a forgotten 'UPDATE channels' statement 2022-01-25 23:42:36 +01:00
Samantaz Fox 2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search
Handle invalid channel id in channel: search
2022-01-25 19:34:43 +01:00
Matthew McGarvey c5967ad572
will -> should
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2022-01-25 11:35:19 -06:00
matthewmcgarvey 574e35a720 HTML escape user input 2022-01-19 09:01:13 -06:00
Samantaz Fox 32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments
Fix loading reddit comments when there are no threads found
2022-01-19 12:53:20 +01:00
matthewmcgarvey 56e505164d 404 error with message and provide example 2022-01-18 18:56:26 -06:00
matthewmcgarvey d4f3139b73 Don't catch and provide better error message instead 2022-01-18 18:37:16 -06:00
matthewmcgarvey 97dceb3a5a Custom error on channel search, handle in search 2022-01-18 18:37:16 -06:00
matthewmcgarvey 212f6d6bf5 Fix channel search json parse to not raise 2022-01-18 18:37:16 -06:00
Samantaz Fox 8c2495a399
Apply suggestions from review 2022-01-17 21:47:29 +01:00
matthewmcgarvey 9233f71549 Use &.methods where possible instead of curly braces 2022-01-17 13:03:36 -06:00
matthewmcgarvey b2a738cf13 Fix loading reddit comments when there are no threads found 2022-01-17 12:11:47 -06:00
Samantaz Fox 34a79c5f1e
Don't show "next steps" message with a stack trace
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
2022-01-16 16:15:23 +01:00
Samantaz Fox a2600acfa9
Improve crash page messages
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
2022-01-16 16:15:23 +01:00
Samantaz Fox 250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus
Fix search autofocus
2022-01-16 15:24:27 +01:00
Samantaz Fox 6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import
Add CSV Subscriptions Import
2022-01-16 15:11:37 +01:00
Samantaz Fox 6cf6c56dd1
Autofocus search bar only on search homepage 2022-01-13 22:19:19 +01:00
Samantaz Fox 8b72481b8c
Fix comments
"ReplyCount" is actually an Int, not a String.
2022-01-13 20:43:46 +01:00
Samantaz Fox aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales
Better support of plurals in locales
2022-01-13 12:55:55 +01:00
Samantaz Fox eff8b23f57
Improve youtube import type detection
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
2022-01-12 18:13:15 +01:00
Samantaz Fox 81a2300af8
Prevent import of insanely large files 2022-01-12 01:28:58 +01:00
Samantaz Fox fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels
Update to fetch related channels again
2022-01-11 01:50:48 +01:00
matthewmcgarvey dc62b6ffdb Can fetch related channels using just the channel ucid] 2022-01-10 17:07:52 -06:00
Samantaz Fox eb7e79fdf7
i18n: Apply code review suggestions + code cleaning 2022-01-10 22:49:07 +01:00
Samantaz Fox 37c953e633
i18n: Use plurals for tokens/replies/unseen notifications 2022-01-10 22:49:07 +01:00
Samantaz Fox 5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts 2022-01-10 22:49:07 +01:00