hashirama/uvg266
1
0
Fork 0
mirror of https://github.com/ultravideo/uvg266.git synced 2024-11-24 02:24:07 +00:00
Code Issues Actions Projects Releases Wiki Activity

Drop an unnecessary pthread_cond_broadcast

Browse source 
Drop pthread_cond_broadcast on threadqueue->cond in function
kvz_threadqueue_waitfor. The broadcast caused threads to be woken up
more often than necessary.
This commit is contained in:
Arttu Ylä-Outinen 2017-07-13 14:44:59 +03:00
parent 20d6444f07
commit 4fc9b743c1
1 changed files with 11 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/threadqueue.c
View file

@ -443,25 +443,18 @@ int kvz_threadqueue_finalize(threadqueue_queue_t * const threadqueue)
return 1;
}
int kvz_threadqueue_waitfor(threadqueue_queue_t * const threadqueue, threadqueue_job_t * const job) {
int job_done = 0;
//NULL job is clearly OK :-)
int kvz_threadqueue_waitfor(threadqueue_queue_t * const threadqueue, threadqueue_job_t * const job)
{
// NULL job is clearly OK.
if (!job) return 1;
//Lock the queue
PTHREAD_LOCK(&job->lock);
while (job->state != THREADQUEUE_JOB_STATE_DONE) {
PTHREAD_COND_WAIT(&threadqueue->cb_cond, &job->lock);
}
PTHREAD_UNLOCK(&job->lock);
PTHREAD_LOCK(&threadqueue->lock);
do {
PTHREAD_LOCK(&job->lock);
job_done = (job->state == THREADQUEUE_JOB_STATE_DONE);
PTHREAD_UNLOCK(&job->lock);
if (!job_done) {
PTHREAD_COND_BROADCAST(&(threadqueue->cond));
PTHREAD_COND_WAIT(&threadqueue->cb_cond, &threadqueue->lock);
}
} while (!job_done);
// Free jobs submitted before this job.
int i = 0;
@ -478,7 +471,7 @@ int kvz_threadqueue_waitfor(threadqueue_queue_t * const threadqueue, threadqueue
}
PTHREAD_UNLOCK(&threadqueue->lock);
return 1;
}