hashirama/uvg266
1
0
Fork 0
mirror of https://github.com/ultravideo/uvg266.git synced 2024-11-24 02:24:07 +00:00
Code Issues Actions Projects Releases Wiki Activity

Fix leaking memory when --roi given many times

Browse source 
Any previously allocated delta QP array was not freed when allocating
a new array.
This commit is contained in:
Arttu Ylä-Outinen 2017-02-05 19:43:12 +09:00
parent bfd89136a4
commit 63a567ad8a
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/cfg.c
View file

@ -1023,17 +1023,20 @@ int kvz_config_parse(kvz_config *cfg, const char *name, const char *value)
fprintf(stderr, "ROI dimensions exceed arbitrary value of 10000.\n");
return 0;
}
const unsigned size = width * height;
cfg->roi.width = width;
cfg->roi.height = height;
cfg->roi.dqps = calloc((size_t)size, sizeof(*cfg->roi.dqps));
if (!cfg->roi.dqps) {
const unsigned size = width * height;
uint8_t *dqp_array = calloc((size_t)size, sizeof(cfg->roi.dqps[0]));
if (!dqp_array) {
fprintf(stderr, "Failed to allocate memory for ROI table.\n");
fclose(f);
return 0;
}
FREE_POINTER(cfg->roi.dqps);
cfg->roi.dqps = dqp_array;
cfg->roi.width = width;
cfg->roi.height = height;
for (int i = 0; i < size; ++i) {
int number; // Need a pointer to int for fscanf
if (fscanf(f, "%d", &number) != 1) {
@ -1041,7 +1044,7 @@ int kvz_config_parse(kvz_config *cfg, const char *name, const char *value)
fclose(f);
return 0;
}
cfg->roi.dqps[i] = (uint8_t)number;
dqp_array[i] = (uint8_t)number;
}
fclose(f);