From 911ae942d4e08a4589dc656fd6a764a159929f6f Mon Sep 17 00:00:00 2001 From: siivonek Date: Fri, 12 Aug 2022 15:28:30 +0300 Subject: [PATCH] [isp] Add height to sig coeff group context calculation function. --- src/context.c | 5 +++-- src/context.h | 2 +- src/rdo.c | 13 ++++++++----- src/strategies/generic/encode_coding_tree-generic.c | 7 ++++++- 4 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/context.c b/src/context.c index 7f9890cf..d6f7e84b 100644 --- a/src/context.c +++ b/src/context.c @@ -610,13 +610,14 @@ void uvg_context_copy(encoder_state_t * const target_state, const encoder_state_ uint32_t uvg_context_get_sig_coeff_group( uint32_t *sig_coeff_group_flag, uint32_t pos_x, uint32_t pos_y, - int32_t width) + int32_t width, + int32_t height) { uint32_t uiRight = 0; uint32_t uiLower = 0; uint32_t position = pos_y * width + pos_x; if (pos_x + 1 < (uint32_t)width) uiRight = sig_coeff_group_flag[position + 1]; - if (pos_y + 1 < (uint32_t)width) uiLower = sig_coeff_group_flag[position + width]; + if (pos_y + 1 < (uint32_t)height) uiLower = sig_coeff_group_flag[position + width]; return uiRight || uiLower; } diff --git a/src/context.h b/src/context.h index 5155ebd3..3f342409 100644 --- a/src/context.h +++ b/src/context.h @@ -49,7 +49,7 @@ void uvg_init_contexts(encoder_state_t *state, int8_t QP, int8_t slice); void uvg_context_copy(encoder_state_t * target_state, const encoder_state_t * source_state); -uint32_t uvg_context_get_sig_coeff_group( uint32_t *sig_coeff_group_flag,uint32_t pos_x, uint32_t pos_y,int32_t width); +uint32_t uvg_context_get_sig_coeff_group( uint32_t *sig_coeff_group_flag,uint32_t pos_x, uint32_t pos_y,int32_t width, int32_t height); uint32_t uvg_context_get_sig_coeff_group_ts(uint32_t* sig_coeff_group_flag, uint32_t pos_x, uint32_t pos_y, int32_t width); uint32_t uvg_context_get_sig_ctx_idx_abs(const coeff_t* coeff, uint32_t pos_x, uint32_t pos_y, uint32_t width, uint32_t height, int8_t type, diff --git a/src/rdo.c b/src/rdo.c index 0c572f29..c91727d3 100644 --- a/src/rdo.c +++ b/src/rdo.c @@ -1425,8 +1425,11 @@ void uvg_rdoq( // ISP_TODO: height const uint32_t log2_cg_size = uvg_g_log2_sbb_size[log2_block_width][log2_block_height][0] + uvg_g_log2_sbb_size[log2_block_width][log2_block_height][1]; + const uint32_t log2_cg_width = uvg_g_log2_sbb_size[log2_block_width][log2_block_height][0]; + const uint32_t log2_cg_height = uvg_g_log2_sbb_size[log2_block_width][log2_block_height][1]; - const uint32_t cg_width = (MIN((uint8_t)32, width) >> (log2_cg_size / 2)); + const uint32_t cg_width = (MIN((uint8_t)TR_MAX_WIDTH, width) >> log2_cg_width); + const uint32_t cg_height = (MIN((uint8_t)TR_MAX_WIDTH, height) >> log2_cg_height); const uint32_t *old_scan = uvg_g_sig_last_scan[ scan_mode ][ log2_block_width - 1 ]; const uint32_t *old_scan_cg = g_sig_last_scan_cg[log2_block_width - 1][scan_mode]; @@ -1636,7 +1639,7 @@ void uvg_rdoq( if( cg_scanpos ) { if (sig_coeffgroup_flag[cg_blkpos] == 0) { uint32_t ctx_sig = uvg_context_get_sig_coeff_group(sig_coeffgroup_flag, cg_pos_x, - cg_pos_y, cg_width); + cg_pos_y, cg_width, cg_height); cost_coeffgroup_sig[cg_scanpos] = lambda *CTX_ENTROPY_BITS(&base_coeff_group_ctx[ctx_sig],0); base_cost += cost_coeffgroup_sig[cg_scanpos] - rd_stats.sig_cost; } else { @@ -1652,7 +1655,7 @@ void uvg_rdoq( // add SigCoeffGroupFlag cost to total cost ctx_sig = uvg_context_get_sig_coeff_group(sig_coeffgroup_flag, cg_pos_x, - cg_pos_y, cg_width); + cg_pos_y, cg_width, cg_height); cost_coeffgroup_sig[cg_scanpos] = lambda * CTX_ENTROPY_BITS(&base_coeff_group_ctx[ctx_sig], 1); base_cost += cost_coeffgroup_sig[cg_scanpos]; @@ -1713,7 +1716,7 @@ void uvg_rdoq( default: assert(0); } - // ISP_TODO: does height affect ctx_cbf? Do this when fixing other cbf stuff + // This cbf should work even with non-square blocks ctx_cbf = ( color != COLOR_V ? 0 : cbf_is_set(cbf, 5 - uvg_math_floor_log2(width), COLOR_U)); best_cost = block_uncoded_cost + lambda * CTX_ENTROPY_BITS(&base_cbf_model[ctx_cbf],0); base_cost += lambda * CTX_ENTROPY_BITS(&base_cbf_model[ctx_cbf],1); @@ -1732,7 +1735,7 @@ void uvg_rdoq( if( dest_coeff[ blkpos ] ) { uint32_t pos_y = blkpos >> log2_block_width; - uint32_t pos_x = blkpos - ( pos_y << log2_block_width ); // ISP_TODO: height + uint32_t pos_x = blkpos - ( pos_y << log2_block_width ); double cost_last = get_rate_last(lambda, pos_x, pos_y, last_x_bits,last_y_bits ); double totalCost = base_cost + cost_last - cost_sig[ scanpos ]; diff --git a/src/strategies/generic/encode_coding_tree-generic.c b/src/strategies/generic/encode_coding_tree-generic.c index c1d2add9..7465ffa9 100644 --- a/src/strategies/generic/encode_coding_tree-generic.c +++ b/src/strategies/generic/encode_coding_tree-generic.c @@ -148,6 +148,11 @@ void uvg_encode_coeff_nxn_generic(encoder_state_t * const state, int32_t cg_pos_y = cg_blk_pos / (MIN((uint8_t)32, width) >> (log2_cg_size / 2)); int32_t cg_pos_x = cg_blk_pos - (cg_pos_y * (MIN((uint8_t)32, width) >> (log2_cg_size / 2))); + const uint32_t log2_cg_width = uvg_g_log2_sbb_size[log2_block_width][log2_block_height][0]; + const uint32_t log2_cg_height = uvg_g_log2_sbb_size[log2_block_width][log2_block_height][1]; + const uint32_t cg_width = (MIN((uint8_t)TR_MAX_WIDTH, width) >> log2_cg_width); + const uint32_t cg_height = (MIN((uint8_t)TR_MAX_WIDTH, height) >> log2_cg_height); + // !!! residual_coding_subblock() !!! // Encode significant coeff group flag when not the last or the first @@ -156,7 +161,7 @@ void uvg_encode_coeff_nxn_generic(encoder_state_t * const state, } else { uint32_t sig_coeff_group = (sig_coeffgroup_flag[cg_blk_pos] != 0); uint32_t ctx_sig = uvg_context_get_sig_coeff_group(sig_coeffgroup_flag, cg_pos_x, - cg_pos_y, (MIN((uint8_t)32, width) >> (log2_cg_size / 2))); + cg_pos_y, cg_width, cg_height); CABAC_FBITS_UPDATE(cabac, &base_coeff_group_ctx[ctx_sig], sig_coeff_group, bits, "significant_coeffgroup_flag"); }