hashirama/xserver
Watch
0
0
Fork
You've already forked xserver
 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-11-01 03:03:58 +00:00
Code Issues Projects Releases Wiki Activity

dix: dixfonts: explain analyzer false alarm on alleged free() of stack chunk

Browse source 
The analyzer is wrong here, because the free'd closure pointer really points
to some calloc()'d chunk, instead of the PolyText()'s stack frame.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-05-06 15:56:58 +02:00
commit 2b9ccde53a
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
dix/dixfonts.c
View file

@ -1348,6 +1348,10 @@ doPolyText(ClientPtr client, PTclosurePtr c)
FreeScratchGC(c->pGC);
free(c->data);
/* if compiler/ananylzer warns here, it's a false alarm:
here `c` points to a calloc()ed chunk, not the on-stack struct
from PolyText(). */
free(c);
}
return TRUE;
@ -1494,6 +1498,9 @@ doImageText(ClientPtr client, ITclosurePtr c)
FreeScratchGC(c->pGC);
free(c->data);
/* if compiler/ananylzer warns here, it's a false alarm:
here `c` points to a calloc()ed chunk, not the on-stack struct
from PolyText(). */
free(c);
}
return TRUE;