hashirama/xserver
Watch
0
0
Fork
You've already forked xserver
 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-11-09 04:20:30 +00:00
Code Issues Projects Releases Wiki Activity

dix: let CreateGCperDepth() accept ScreenPtr instead of screen id
Some checks are pending
Build X servers / xserver-build-ubuntu (push) Waiting to run
Details
Build X servers / drivers-build-ubuntu (push) Waiting to run
Details
Build X servers / xserver-build-mingw32-ubuntu (push) Waiting to run
Details
Build X servers / xserver-build-macos (push) Waiting to run
Details
Build X servers / xserver-build-freebsd (push) Waiting to run
Details
Build X servers / Release pushed tag (push) Waiting to run
Details

Browse source 
It's only caller already has the ScreenPtr, so it doesn't make any sense
passing in the screen number and let that function retrieve the pointer
on its own again.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-08-11 15:51:14 +02:00 • committed by Enrico Weigelt
commit 3af53d474f
3 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
dix/gc.c
View file

@ -831,13 +831,11 @@ FreeGCperDepth(ScreenPtr pScreen)
}
Bool
CreateGCperDepth(int screenNum)
CreateGCperDepth(ScreenPtr pScreen)
{
ScreenPtr pScreen;
DepthPtr pDepth;
GCPtr *ppGC;
pScreen = screenInfo.screens[screenNum];
ppGC = pScreen->GCperDepth;
/* do depth 1 separately because it's not included in list */
if (!(ppGC[0] = CreateScratchGC(pScreen, 1)))

2
dix/gc_priv.h
View file

@ -24,7 +24,7 @@ int FreeGC(void *pGC, XID gid);
void FreeGCperDepth(ScreenPtr pScreen);
Bool CreateGCperDepth(int screenNum);
Bool CreateGCperDepth(ScreenPtr pScreen);
Bool CreateDefaultStipple(ScreenPtr pScreen);

2
dix/main.c
View file

@ -216,7 +216,7 @@ dix_main(int argc, char *argv[], char *envp[])
FatalError("failed to create screen pixmap properties");
if (!dixScreenRaiseCreateResources(pScreen))
FatalError("failed to create screen resources");
if (!CreateGCperDepth(i))
if (!CreateGCperDepth(pScreen))
FatalError("failed to create scratch GCs");
if (!CreateDefaultStipple(pScreen))
FatalError("failed to create default stipple");