hashirama/xserver
Watch
0
0
Fork
You've already forked xserver
 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-09-21 20:26:45 +00:00
Code Issues Projects Releases Wiki Activity

Coverity #169: Fix potential fgets() into NULL (?!?).

Browse source
This commit is contained in:
Daniel Stone 2006-04-09 17:26:17 +00:00
commit 7637aa17f2
2 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
xkb/ddxList.c
View file

@ -169,8 +169,6 @@ char tmpname[PATH_MAX];
if ((list->pattern[what][0]=='*')&&(list->pattern[what][1]=='\0')) {
buf = Xprintf("%s/%s.dir",XkbBaseDirectory,componentDirs[what]);
in= fopen(buf,"r");
xfree (buf);
buf = NULL;
}
if (!in) {
haveDir= False;
@ -186,8 +184,6 @@ char tmpname[PATH_MAX];
if ((list->pattern[what][0]=='*')&&(list->pattern[what][1]=='\0')) {
buf = Xprintf("%s.dir",componentDirs[what]);
in= fopen(buf,"r");
xfree (buf);
buf = NULL;
}
if (!in) {
haveDir= False;
@ -224,6 +220,13 @@ char tmpname[PATH_MAX];
return BadImplementation;
}
list->nFound[what]= 0;
if (buf) {
xfree(buf);
buf = NULL;
}
buf = xalloc(PATH_MAX * sizeof(char));
if (!buf)
return BadAlloc;
while ((status==Success)&&((tmp=fgets(buf,PATH_MAX,in))!=NULL)) {
unsigned flags;
register unsigned int i;