Commit graph xserver/Xext/security
Author SHA1 Message Date
Mason Green
1090a8b19b Xext: security: fix double free when AddResource() fails
When AddResource() cannot allocate its record, it calls the resource
type's delete function before returning FALSE. For an authorization that
is SecurityDeleteAuthorization(), which removes the authorization,
releases its event clients and frees pAuth.

ProcSecurityGenerateAuthorization() then went to bailout, which removed
the authorization a second time and freed pAuth again. Return BadAlloc
directly instead.

Signed-off-by: Mason Green <mason@greenm01.net>
2026-10-14 11:59:30 +02:00
Enrico Weigelt, metux IT consult
f9f5f4e306 xext: security: use stdbool's 'bool' instead of 'Bool' for local variables
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-08-07 14:48:38 +02:00
Enrico Weigelt, metux IT consult
5f2e1b8d73 xext: security: securitysrv.h: fix includes
Some checks failed
Build X servers / drivers-build-ubuntu (video-siliconmotion:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-sis:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-sisusb:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-suncg14:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-suncg3:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-suncg6:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-sunffb:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-sunleo:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-suntcx:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-tdfx:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-trident:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-v4l:25.0.1) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-vbox:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-vesa:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-vmware:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-voodoo:25.0.0) (push) Has been cancelled
Build X servers / drivers-build-ubuntu (video-xgi:25.0.0) (push) Has been cancelled
Build X servers / xserver-build-mingw32-ubuntu (push) Has been cancelled
Build X servers / xserver-build-freebsd (push) Has been cancelled
Build X servers / xserver-build-dragonflybsd (push) Has been cancelled
Build X servers / xserver-build-netbsd (push) Has been cancelled
Build X servers / xserver-build-solaris (push) Has been cancelled
Build X servers / xserver-build-openbsd (push) Has been cancelled
Build X servers / xserver-build-hurd (push) Has been cancelled
Build X servers / xserver-build-alpine (push) Has been cancelled
Build X servers / gentoo-deps-image (push) Has been cancelled
Build X servers / xserver-build-gentoo (push) Has been cancelled
Build X servers / xserver-build-rhel (10) (push) Has been cancelled
Build X servers / xserver-build-rhel (9) (push) Has been cancelled
Build X servers / Release pushed tag (push) Has been cancelled
We don't need input.h and pixmap.h here, but we need os.h

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-07-29 17:29:15 +02:00
Enrico Weigelt, metux IT consult
931be13ea8 Xext: move some calls with return on error into macros
A frequent pattern inside request handlers looks like this:

   int rc = doSomething(...);
   if (rc != Success) {
       return rc;
   }

Making the code bit shorter & quicker to read my moving this
into a macro like this:

   X_CALL_CHECK_ERR(doSomething(...));

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-06-24 19:23:43 +02:00
Enrico Weigelt, metux IT consult
ee50768a3f Xext: security: move it into it's own subdir
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-06-18 14:47:39 +02:00