Author	SHA1	Message	Date
Jeremy Huddleston Sequoia	3d20b6d253	fb: Don't widen the planemask over padding bits when ROOTLESS_SAFEALPHA is set ... Wide LineDoubleDash lines drew black on screen under XQuartz while the server's own XGetImage readback showed the correct pixels, because at depth 24 that readback ignores alpha. Opaque text and dashed arcs take the same path. fbValidateGC widens a planemask that covers the drawable's depth to cover its full bits per pixel, so the blit and fill paths can take their all-ones shortcuts. On a rootless server that also writes the alpha channel of the window's premultiplied surface, which CoreGraphics then composites as black. Rootless keeps that alpha opaque by clearing the bits from the planemask, but only its own ValidateGC does so, and mi revalidates the GC in the middle of a drawing operation to swap the foreground for the background pixel. By then the damage layer has unwrapped the rootless funcs down to fb, so the reassertion never happens and the rest of the operation lands with a zero alpha channel. Fixes: https://github.com/XQuartz/XQuartz/issues/230 Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>	2026-09-30 19:06:39 +02:00
Herman Semenoff	b1571febfd	fb: Avoid potential out-of-bounds shift amounts in fbBlt ... In fbBlt(), explicitly check (srcX < dstX) in the alternate shift calculation branch so that shift values (leftShift and rightShift) remain strictly within valid bit-width bounds [0..FB_UNIT - 1], avoiding potential 32-bit shift undefined behavior warnings	2026-08-31 15:51:17 +02:00
Enrico Weigelt, metux IT consult	7268350d98	fb: use stdbool's 'bool' instead of 'Bool' for local variables ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-08-07 14:24:27 +02:00
Enrico Weigelt, metux IT consult	b40d0ec6fd	license: add X11 OR MIT OR AGPL-3.0-or-later to Enrico Weigelt's source files ... Update SPDX-License-Identifier from MIT OR X11 (or MIT OR X11 OR AGPLv3+ variants) to the canonical X11 OR MIT OR AGPL-3.0-or-later on 95 existing source files. Add the triple-license header to 33 newly-identified files authored by Enrico Weigelt that were missing SPDX headers entirely. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-29 10:02:59 +02:00
Peter Hutterer	8a09b80700	fb/mi/glamor: reject glyphs with negative dimensions ... GLYPHWIDTHPIXELS and GLYPHHEIGHTPIXELS compute glyph dimensions from signed INT16 fields. A crafted PCF font can produce negative results (e.g. rightSideBearing < leftSideBearing). All callees have a while (height--) loop which will end up in OOB writes for negative height values. In the case of a negative height, some callees cast to size_t or end up with negative strides. The same pattern exists in fbPoloyGlyphBit, miPolyGlyphBlt and glamor_poly_glyph_blt_gl, so let's fix all of them in one go. Assisted-by: Claude:claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2250> (cherry picked from commit e31efd3e10) Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-14 11:54:22 +02:00
Enrico Weigelt, metux IT consult	8031c2f45a	treewide: fix result type of BitmapBytePad() to size_t ... sizes can't have negative numbers, so use the size_t here. Also having to fix up lots of callers. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-29 15:44:48 +02:00
Enrico Weigelt, metux IT consult	d03c830039	fb: parentheses around macro argument symbols ... For safety, add extra parantheses on each used macro argument. In most cases not strictly necessary, but better have some strict and automatically enforcable policy here than wasting time on judging individual cases. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-25 06:53:59 +02:00
Enrico Weigelt, metux IT consult	561168cfa1	render: move it under Xext/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-17 14:29:57 +02:00
Enrico Weigelt, metux IT consult	a900f1dc57	treewide: clean up includes of mipict.h ... This header is part of SDK and thus located under ./include Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-04-30 14:51:33 +02:00
Alan Coopersmith	2f144d56e3	fb: quiet -Wanalyzer-out-of-bounds warnings in fbOverlayCopyWindow() ... Reported in #1817: xwayland-24.1.6/redhat-linux-build/../fb/fboverlay.c:230:13: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read xwayland-24.1.6/redhat-linux-build/../fb/fboverlay.c:233:9: warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2162>	2026-04-21 12:19:30 +02:00
Enrico Weigelt, metux IT consult	69d57bcf52	Xext: move over public SDK headers to include/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-12 19:00:42 +01:00
Enrico Weigelt, metux IT consult	25fc1a02f5	render: move over public SDK headers to include/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-12 17:43:44 +01:00
Enrico Weigelt, metux IT consult	430d3b62c2	fb: move over public SDK headers to include/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-12 14:39:31 +01:00
Enrico Weigelt, metux IT consult	5e99813293	fb: replace DDXPoint by xPoint ... DDXPoint is just an alias to xPoint Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-10 16:01:08 +01:00
Oleh Nykyforchyn	ccb9b1bd17	fb: reexport fbGetGCPrivateKey and add itw wrapped version ... This patch reexports a symbol needed by NVidia 340 driver and adds its "wrapped" version for libwfb to prevent XServer crashes. Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>	2025-12-18 10:47:47 +01:00
Enrico Weigelt, metux IT consult	9b8d7d1eb9	treewide: don't include <region.h> anymore ... Nothing in there that we need, include <regionstr.h> instead. But keeping the file in place, until all external consumer have been migrated. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-27 19:27:27 +01:00
Enrico Weigelt, metux IT consult	dda346463e	fb: wfbrename: drop unused symbol fbGeneration ... Just fallout from mfb removal back 17 years ago. See: f31bd087e8 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-19 13:28:54 +01:00
Enrico Weigelt, metux IT consult	48cb1118ee	treewide: drop unnecessary pixmap field initialization ... The PixmapRec is already calloc()'ed, so no need for additional zero-writes into individual fields. This also removes some unncessary #ifdefs. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-01 13:31:52 +02:00
Enrico Weigelt, metux IT consult	d6cd58e04c	fb: fix unused function fbInitializeDrawable() ... > ../fb/fbpixmap.c:32:20: warning: unused function 'fbInitializeDrawable' [-Wunused-function] > 32 | static inline void fbInitializeDrawable(DrawablePtr pDrawable) {} Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-08-29 19:05:15 +02:00
Enrico Weigelt, metux IT consult	ae1b649587	treewide: replace PICT_FORMAT_A by PIXMAN_FORMAT_A ... Try not to use old compat macros anymore, use the real ones instead. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-08-07 12:45:37 +02:00
Enrico Weigelt, metux IT consult	bbabd96e6c	meson: rename symbol MITSHM to CONFIG_MITSHM ... some bit better naming for config symbols. Yet leaving the old one defined, until all drivers have kept up. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-08-05 11:39:28 +02:00
Enrico Weigelt, metux IT consult	e1d5d60848	fb: use NULL instead of NullClient ... No need to have another name for NULL, we can use NULL directly. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-07-18 22:24:55 +02:00
Enrico Weigelt, metux IT consult	cd1041d7ac	fb: fbbits.h: no need to include dix-config.h here ... All in-tree consumers already need to include dix-config.h on the very top anyways, and there are no out-of-tree consumers (private to fb subsys) Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-07-18 04:51:30 +02:00
Enrico Weigelt, metux IT consult	16030f7d9e	fb: fbpict.h: no need to include dix-config.h here ... All in-tree consumers already need to include dix-config.h on the very top anyways, and out-of-tree consumers don't have that include at all. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-07-18 04:51:30 +02:00
dasha_uwu	7c64a06ba4	treewide: remove "lib" prefix in static_library names (meson) ... this was producing static libraries named "liblibsomething.a" Signed-off-by: dasha_uwu <dasha@linuxping.win>	2025-07-03 12:01:52 +02:00
Mike Gelfand	166d1b5e6b	fb: add/fix include guards where missing/broken ... Skipped headers designed for multiple or non-trivial inclusion: * fb/fbbits.h Signed-off-by: Mike Gelfand <mikedld@mikedld.com>	2025-06-27 13:58:05 +02:00
Enrico Weigelt, metux IT consult	e6467895f9	dix: add dixAllocServerXID() ... Adding a separate function for allocating server-client's XIDs. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 17:21:48 +02:00
Enrico Weigelt, metux IT consult	e25852fd53	fb: replace xallocarray() by calloc() ... Only key difference that calloc(), in contrast to rellocarray(), is zero-initializing. The overhead is hard to measure on today's machines, and it's safer programming practise to always allocate zero-initialized, so one can't forget to do it explicitly. Cocci rule: @@ expression COUNT; expression LEN; @@ - xallocarray(COUNT,LEN) + calloc(COUNT,LEN) Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 17:21:43 +02:00
Enrico Weigelt, metux IT consult	c4c5f03cb7	fb: use calloc() instead of malloc() ... Using calloc() instead of malloc() as preventive measure, so there never can be any hidden bugs or leaks due uninitialized memory. The extra cost of using this compiler intrinsic should be practically impossible to measure - in many cases a good compiler can even deduce if certain areas really don't need to be zero'd (because they're written to right after allocation) and create more efficient machine code. The code pathes in question are pretty cold anyways, so it's probably not worth even thinking about potential extra runtime costs. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:48:17 +02:00
Enrico Weigelt, metux IT consult	d708b28adc	treewide: drop COMPOSITE symbol ... It's always enabled for very long time now (at least since meson transition), there doesn't seem to be any need to ever disable it again. So we can reduce code complexity by removing all the ifdef's. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:47:01 +02:00
Enrico Weigelt, metux IT consult	ac947ad0d6	fb: unexport fbGetScreenPixmap() macro ... No external users, so no need to keep it exported any longer. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:41:12 +02:00
Enrico Weigelt, metux IT consult	3e21e96ae4	fb: unexport fbGetGCPrivate() macro ... Not used by drivers, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:41:09 +02:00
Enrico Weigelt, metux IT consult	05ffb3ec67	fb: unexport FbDash*() macros ... No external users, so no need to keep them exported. (note that xf86-video-intel has it's own copies of them) Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:41:06 +02:00
Enrico Weigelt, metux IT consult	b1f60ad68c	fb: unexport FbMaskBits() macro ... No external users, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:27 +02:00
Enrico Weigelt, metux IT consult	df02054150	fb: unexport FB_HEAD_BITS and FB_TAIL_BITS macros ... Not used by any driver, so no need to keep them exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:24 +02:00
Enrico Weigelt, metux IT consult	cffb529195	fb: unexport FbBitsStrideToStipStride() macro ... Not used by any drivers, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:20 +02:00
Enrico Weigelt, metux IT consult	514a142ab0	fb: move FbStipStrideToBitsStride() to fbblt.c ... It's only consumer is fbblt.c, so move it there. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:17 +02:00
Enrico Weigelt, metux IT consult	e85e8fae56	fb: move MEMCPY_WRAPPED() and MEMSET_WRAPPED() into fbblt.c ... Only used inside fbblt.c, so we can move them into there. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:15 +02:00
Enrico Weigelt, metux IT consult	bfcbcf0302	fb: unexport fbListInstalledColormaps() ... Not used by any drivers, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:12 +02:00
Enrico Weigelt, metux IT consult	50c2c59dc9	fb: unexport fbAllocatePrivates() ... Only used inside fb/, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:09 +02:00
Enrico Weigelt, metux IT consult	4a94e4d01e	fb: unexport fbSetBits() ... Only used within fb/, not by any driver, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:05 +02:00
Enrico Weigelt, metux IT consult	97e82b3812	fb: unexport fbInitializeDrawable() and make it static ... Only used inside fbpixmap.c (where it's defined), so can be static. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:40:02 +02:00
Enrico Weigelt, metux IT consult	31548e3705	fb: unexport fbValidateDrawable() ... Not used by any drivers, so no need to keep it exported. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:59 +02:00
Enrico Weigelt, metux IT consult	62d5d4ff83	fb: make fbGCFuncs static ... Not used outside fbgc.c, so can be made static. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:56 +02:00
Enrico Weigelt, metux IT consult	ab6c67e547	fb: make fbGCOps static ... Not used anywhere outside fbgc.c, so can be static. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:52 +02:00
Enrico Weigelt, metux IT consult	4125712079	fb: drop obsolete fbPolyFillArc and fbPolyRectangle defines ... Those aliases haven't been used (outside fb core itself), since XAA removal back 17 years ago, no no need to carry them in public interface any longer. See: 703a9645f3 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:49 +02:00
Enrico Weigelt, metux IT consult	879589060c	fb: drop obsolete fbGetExpose() macro ... Hasn't been used since 15 years so, probably should was forgotten to clean up. See: bbbf795e6b Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:46 +02:00
Enrico Weigelt, metux IT consult	abaf937693	fb: drop obsolete FbLaneCase*() macros ... They haven't been used for over a decade now, so no need to keem'em any longer. (note: xf86-video-intel has it's own copy of them)	2025-06-12 16:39:43 +02:00
Enrico Weigelt, metux IT consult	5504bc42ae	fb: drop obsolete FbMaskStip macro ... Hasn't been used since 24bpp support was dropped, almost a decade ago. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:41 +02:00
Enrico Weigelt, metux IT consult	db2568b834	fb: drop obsolete fbFillPolygon define ... Hasn't been used since XAA removal, back 17 years ago. Probably just had been forgotten to clean up. See: 703a9645f3 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-06-12 16:39:38 +02:00