Author	SHA1	Message	Date
Enrico Weigelt, metux IT consult	9f913a3156	meson_options: disable XvMC build by default ... XvMC is only helpful for old MPEG2 decoding (and here only some specific part, the motion compensation). It's only supported by few cards, and needs special client-side drivers, which need to have direct and pretty low-level (non-DRI) GPU access (usually involving root access). Since it's local-only anyways, modern clients can use generic GPU shaders for various video formats (via standard DRI/mesa) and send whole frames. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-10-13 14:16:38 +02:00
Ivaylo Dimitrov	17bb295818	DPMS: Don't wake display from input when timeouts are disabled ... When DPMS is active, `mieqProcessInputEvents()` unconditionally switches the display back to `DPMSModeOn` for every input event. This prevents systems from keeping the display powered off while still allowing applications to use input devices when DPMS is externally managed by disabling all screen-saver and DPMS timeouts. When all screen-saver and DPMS timeouts are disabled, the current DPMS state is assumed to be externally managed and should not be overridden by input activity. Keep input processing unchanged so devices such as media buttons remain usable while the display is off. Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2287> (cherry picked from commit 975453b1aa) (cherry picked from commit 3daad9945ee4cf750dc2624109096cbfb288be13) (cherry picked from commit 68481c5b4ee716a8a7d093e1b9ca622d97882156)	2026-10-02 12:35:19 +02:00
Alan Coopersmith	2bbea240f3	Handle -Wimplicit-fallthrough warnings from gcc 16.1 ... Gets rid of 36 -Wimplicit-fallthrough warnings Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>	2026-09-30 21:03:21 +02:00
Herman Semenoff	e5137d9fde	mi: fix operator precedence in hookX when calculating arc hook offset ... In hookX(), add parentheses around the ternary operator (left ? -def->l : def->l) so that the addition applies to the selected delta rather than treating (def->w + left) as the ternary condition	2026-09-09 11:33:48 +02:00
Herman Semenoff	11bb4b1b73	mi: guard against NULL event pointer ... In miPointerSetPosition(), ensure nevents and events pointers are non-NULL before checking for and updating barrier event coordinates to avoid potential NULL pointer dereferences	2026-08-31 14:02:13 +02:00
Enrico Weigelt, metux IT consult	2ba0ed012f	mi: fix double-free/UAF in miDCInitialize() on miSpriteInitialize() failure ... miDCInitialize() registers the CloseScreen hook (miDCCloseScreen, via dixScreenHookPostClose()) and stores pScreenPriv into the screen's devPrivates *before* calling miSpriteInitialize(). On failure it only freed pScreenPriv, leaving both the hook armed and the devPrivates slot pointing at now-freed memory. This isn't just "a caller that ignores the Bool return could look it up later" -- the hook it already registered guarantees the problem fires on every subsequent screen close: miDCCloseScreen() looks up the dangling pointer via dixLookupPrivate(), passes it to miDCSwitchScreenCursor() (dereferencing freed memory, e.g. dixDestroyPixmap() on pScreenPriv->sourceBits), and then frees pScreenPriv a second time. Trigger: any allocation failure inside miSpriteInitialize() during screen init (a DDX like vfb/kdrive/xfree86/xnest/xwin calling miDCInitialize()) sets this up; the actual crash fires later, at screen close. Fix: unhook the CloseScreen callback and clear the devPrivates slot before freeing pScreenPriv, matching what miDCCloseScreen() itself does on the normal teardown path. Found via a fleet-directed alloc-fail/UAF sweep of Xext/, mi/, and miext/, not from a live crash report. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-08-07 15:00:09 +02:00
Enrico Weigelt, metux IT consult	67d6254f24	mi: use stdbool's 'bool' instead of 'Bool' for local variables ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-08-07 14:35:29 +02:00
Enrico Weigelt, metux IT consult	b40d0ec6fd	license: add X11 OR MIT OR AGPL-3.0-or-later to Enrico Weigelt's source files ... Update SPDX-License-Identifier from MIT OR X11 (or MIT OR X11 OR AGPLv3+ variants) to the canonical X11 OR MIT OR AGPL-3.0-or-later on 95 existing source files. Add the triple-license header to 33 newly-identified files authored by Enrico Weigelt that were missing SPDX headers entirely. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-29 10:02:59 +02:00
Enrico Weigelt, metux IT consult	4ebdb499dd	Xext: remove the XF86-BigFont extension ... XF86-BigFont lets local clients share font-metrics arrays via SysV shared memory (and compresses them for remote clients) -- a local-only optimization dating back to ancient XFree86. It hasn't been built by default for really long time. Enabling it in our CI immediately exposed that the code has bit-rotted on 7 non-Linux CI lanes (macOS/BSD: including a nonexistent Linux-only header; Solaris: an ARRAY_SIZE redefinition pulled in via its system headers; mingw32: implicit geteuid()/getegid() plus an unused variable). Concrete evidence that this extension currently has no real users exercising it, since none of that breakage was ever noticed. Therefore no practical need for carrying it around any longer. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-27 18:31:44 +02:00
Enrico Weigelt, metux IT consult	dd2ad2cd93	xext: panoramiX: helpers for checking wether it's enabled/disabled ... These helpers are always defined, even when compiling w/o PanoramiX at all (symbol XINERAMA not defined), so we need fewer ifdef's. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-24 17:27:51 +02:00
Enrico Weigelt, metux IT consult	e1e63e6c9f	xext: composite: move some function declarations ... move it them the compositeext_priv.h header, which is supposed to be the one included by other parts of the Xserver. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-23 18:48:47 +02:00
Peter Hutterer	8a09b80700	fb/mi/glamor: reject glyphs with negative dimensions ... GLYPHWIDTHPIXELS and GLYPHHEIGHTPIXELS compute glyph dimensions from signed INT16 fields. A crafted PCF font can produce negative results (e.g. rightSideBearing < leftSideBearing). All callees have a while (height--) loop which will end up in OOB writes for negative height values. In the case of a negative height, some callees cast to size_t or end up with negative strides. The same pattern exists in fbPoloyGlyphBit, miPolyGlyphBlt and glamor_poly_glyph_blt_gl, so let's fix all of them in one go. Assisted-by: Claude:claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2250> (cherry picked from commit e31efd3e10) Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-07-14 11:54:22 +02:00
Enrico Weigelt, metux IT consult	8031c2f45a	treewide: fix result type of BitmapBytePad() to size_t ... sizes can't have negative numbers, so use the size_t here. Also having to fix up lots of callers. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-29 15:44:48 +02:00
Enrico Weigelt, metux IT consult	a09755b660	treewide: drop ifdef's for GLYPHPADBYTES != 4 ... It's always defined to 4, for over a decade now, so no extra case checks needed anymore. See: 17c3347f14 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-29 14:28:42 +02:00
Enrico Weigelt, metux IT consult	639da9e136	treewide: replace min/max macros by non-exported MIN/MAX and deprecate them ... Replace public min/max macros by private MIN/MAX and deprecate them. The few drivers still using them can trivially define them on their own. Adding a new private header for all kind of math-ish definitions - future commits will move more stuff there. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-25 14:06:17 +02:00
Enrico Weigelt, metux IT consult	88df8c687c	mi: parentheses around macro argument symbols ... For safety, add extra parantheses on each used macro argument. In most cases not strictly necessary, but better have some strict and automatically enforcable policy here than wasting time on judging individual cases. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-25 09:23:45 +02:00
Enrico Weigelt, metux IT consult	8ca8ba3a49	dix: add dixScreenRaiseDisplayCursor() ... Add new function for calling into screen's DisplayCursor() chain. This is a preparational step for moving hide cursor counters (xfixes) and animations (randr) into DIX, in order to get rid of ugly wrapping. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-25 07:15:00 +02:00
Enrico Weigelt, metux IT consult	bae2233ebe	mi: move over mioverlay.c to hw/xfree86/compat ... Since these are just dummies needed for compat with proprietary Nvidia driver, they're better off in the compat directory. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-24 19:26:49 +02:00
Enrico Weigelt, metux IT consult	56799a9107	mi: drop mioverlay.h ... Since no drivers are compiled against this anymore, and the mioverlay.c functions only dummies just to satisfy proprietary Nvidia driver's symbol dependencies, this header isn't needed anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-24 19:26:49 +02:00
Enrico Weigelt, metux IT consult	c2fbb847a0	mi: mioverlay: turn overlay functions into dummies ... Those shouldn't be called anymore for decades now, but proprietary nvidia drivers still referencing them. Hopefully they don't call them anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-24 19:26:49 +02:00
Enrico Weigelt, metux IT consult	876c782094	treewide: clean up includes of misc.h ... adding include/ prefix to it. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-19 19:24:57 +02:00
Enrico Weigelt, metux IT consult	02ecb28c4c	mi: mipoly.h: drop obsolete assert() ... not hit for aeons now, not actually needed anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-18 17:47:03 +02:00
Enrico Weigelt, metux IT consult	2906b973a8	Xext: move remaining panoramix headers into panoramix subdir. ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-17 19:01:48 +02:00
Enrico Weigelt, metux IT consult	6d6bd73647	composite: move it under Xext/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-17 07:50:13 +02:00
Enrico Weigelt, metux IT consult	6cbd9ee388	Xext: dpms: refactor entrypoints for DIX/DDX ... Refactor the entry pointer header, add documentation and move it to a more suitable place. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-15 16:41:30 +02:00
Enrico Weigelt, metux IT consult	29cc25065b	xnest: no need for DISABLE_EXT_DPMS anymore ... All the other DDX'es (except xfree86) are already handling it the same way: the extension is present, but the ScreenRec->DPMS() pointer left NULL (callers already checking for that), so no need for any special magic for Xnest. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-06-15 16:25:25 +02:00
Peter Hutterer	28eac12569	mi: fail on reallocarray failure in miAppendSpans ... Use the XNF version for this and simply bail out if it fails. Clearly this hasn't been a problem in over 20 years and I can't be bothered finding the perfect cleanup path. Co-Authored-by: Claude Code <noreply@anthropic.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2184> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-04 16:54:47 +02:00
Peter Hutterer	479d2ca741	mi: Handle allocation failure in XYToWindow() spriteTrace realloc ... Co-Authored-by: Claude Code <noreply@anthropic.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2184> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-04-30 18:32:07 +02:00
Enrico Weigelt, metux IT consult	394d57264e	mi: misprite.h: change retval's from Bool to bool (stdbool.h) ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-04-23 20:01:59 +02:00
Enrico Weigelt, metux IT consult	00d1ff9171	mi: mifillarc.h: fix missing include of <X11/Xdefs.h> ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-04-23 18:04:06 +02:00
stefan11111	e6a0fa4b0c	Treewide: Fix typos ... Signed-off-by: Diego Viola <diego.viola@gmail.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2134> ---------------------------------------------------------------------------- This commit is the result of `git apply commit.diff --reject` applied on e8f4522312 67c82078fe does not apply to Xlibre Signed-off-by: stefan11111 <stefan11111@shitposting.expert>	2026-03-16 13:11:07 +01:00
Enrico Weigelt, metux IT consult	69d57bcf52	Xext: move over public SDK headers to include/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-12 19:00:42 +01:00
Enrico Weigelt, metux IT consult	58e80dc78a	mi: move over public SDK headers to include/ ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-12 16:21:38 +01:00
Enrico Weigelt, metux IT consult	8fdd177d8f	mi: replace DDXPoint by xPoint ... DDXPoint is just an alias to xPoint Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-10 18:50:53 +01:00
Enrico Weigelt, metux IT consult	62b0add858	mi: move ValidateRec to mi_priv.h and rename to MiValidateRec ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-10 18:27:41 +01:00
Enrico Weigelt, metux IT consult	0c2289ce0c	mi: drop including dix-config.h from headers ... It needs to be included from the very top of source files anyways, should not be done from individual headers. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-10 16:01:20 +01:00
Enrico Weigelt, metux IT consult	1fa1ec50a3	mi: drop ifdef on obsolete DAMAGE symbol ... It's always set by meson.build and planned to be removed entirely. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-02-10 11:52:19 +01:00
stefan11111	dc39eda42b	treewide: Move the dri2 extension to Xext and use it for all X servers ... This is needed to get proton working in Xfbdev, but is probably useful in other places too. Xephyr has some unrelated issues regaring Xinput, so steam doesn't work there. Signed-off-by: stefan11111 <stefan11111@shitposting.expert>	2026-01-02 17:51:43 +01:00
Enrico Weigelt, metux IT consult	33729b1361	include: windowstr.h: unexport w*() macros ... These aren't used by any drivers, so no need to keep them public. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-27 19:54:42 +01:00
Enrico Weigelt, metux IT consult	9b8d7d1eb9	treewide: don't include <region.h> anymore ... Nothing in there that we need, include <regionstr.h> instead. But keeping the file in place, until all external consumer have been migrated. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-27 19:27:27 +01:00
Enrico Weigelt, metux IT consult	a72972274e	mi: drop intToCoord() macro ... Not used anywhere, no need to keep it around any longer. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-27 18:25:12 +01:00
Herman Semenov	4689dfb21f	mi: fix missing braces for expected logical condition 'if-else if' ... Without missing braces, logical behavior 'if-else if' block works as two 'if' independent blocks.	2025-11-26 16:45:55 +01:00
Mike Gelfand	770c21c947	mi: move include guards up to wrap the whole file ... See: https://gcc.gnu.org/onlinedocs/cppinternals/Guard-Macros.html Signed-off-by: Mike Gelfand <mikedld@mikedld.com>	2025-11-21 15:20:11 +01:00
Enrico Weigelt, metux IT consult	44077ee11c	dix: unexport screenIsSaved and HasSaverWindow() ... These aren't used by any external drivers, so no need to keep them public. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-11-20 17:52:23 +01:00
Enrico Weigelt, metux IT consult	962580a15a	treewide: macros lambda-esque screen iteration ... iterating over screen list via lambda-esque macros calls like this DIX_FOR_EACH_SCREEN({ do_something }); withing the body, the iterator variables `walkScreenIdx` and `walkScreen` are defined and can be directly used (read-only). the code inside the body is running in a separate scope. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-10-01 11:40:34 +02:00
Enrico Weigelt, metux IT consult	0ade4aef80	mi: fix missing includes of extinit.h ... Don't rely on this file just being included indirectly by somebody else just by accident. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-25 13:48:41 +02:00
Enrico Weigelt, metux IT consult	b0ffa7b286	treewide: rename dixGetFirstScreenPtr() to dixGetMasterScreen() for correct semantics ... In Xinerama/Panoramix configuration there's one screen that's having special meaning - it's used for simulating as the frontend for all client operations: the clients (should) only talk to that screen, while panoramix subsystem is proxying those operations to all the other screens (with certain changed applied, eg. coordinate transformations). Historically, this screen happens to be the first one in the system (some of it's proc's are hooked up in order to achieve desired behaviour). That's why it used to be accessed via screenInfo.screens[0] - that already had been encapsulated into a tiny helper `dixGetFirstScreen()`. a) the correct terminus technicus for a situation where one device (or SW entity) entirely controlling others is a master-slave-relationship: the controlling device/entity is `master`, the controlled ones are `slave` (to that specific master). b) the term "first screen" is inacurate and misleading here: what the caller's are actually interest in isn't the first entry in the screen array, but the screen that's controlling the others. With upcoming refactoring of the Xinerama/Panoramix subsystem, this might well be a different array index than 0. c) the term `default` also wouldn't match: `default` implies there's a real practical choice, and such value applies when no explicit choice has been made. But in this case, it practically doesn't make sense (except perhaps for debugging purpose) for a client to use any different screen. Therefore fixing the function name to the correct technical terminology. (for sake of patch readability, renaming corresponding variables is left to subsequent patches). Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-12 11:44:05 +02:00
Enrico Weigelt, metux IT consult	6bc438ab5a	treewide: use inline helper for accessing first screen ... Instead of everybody directly accessing the (internal) screenInfo struct, let those consumers only interested in first screen use a little helper. Also caching the value if it's needed several times. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-10 13:45:05 +02:00
Enrico Weigelt, metux IT consult	a324351f67	treewide: drop unnecessary includes of Xi/eglobals.h ... Dropping include by sources that don't use anything from this header. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-09 14:41:10 +02:00
Enrico Weigelt, metux IT consult	40473404e4	mi: miDCDeviceCleanup(): little loop simplification ... skip cycle via `continue` instead of having a big if{} block. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2025-09-04 19:13:14 +02:00