No description
  • C 94.2%
  • Python 2.2%
  • Roff 1.2%
  • Objective-C 1%
  • Meson 0.9%
  • Other 0.3%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Peter Hutterer 1b6955c310 present: unlink notifies from window list in present_clear_window_notifies
When a window is destroyed, present_clear_window_notifies()
does not remove the notify list node from the window. The notify
may then be freed as part of the window_priv, leaving dangling
pointers in place.

When the vblank owning the notify is later torn down,
present_free_window_notify() calls xorg_list_del() which
writes through these dangling pointers (use-after-free write).

This happens when Present cross-window notifies are used: a
PresentPixmap on window A can reference window B as a notify target.
An untriggered wait_fence keeps the vblank alive so that B can be
destroyed first, creating the dangling-pointer window.

Fix this by calling the free function we have (and moving the window
reset into that function too). present_clear_window_notifies is only
called from one place anyway.

This vulnerability was discovered by:
  Anonymous working with TrendAI Zero Day Initiative

ZDI-CAN-31830

CVE-2026-93515

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Assisted-by: Claude:claude-opus-4-6
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2341>
2026-10-06 15:25:16 +10:00
.gitlab-ci Fix remaining ruff check issues 2026-10-03 13:23:49 -07:00
composite composite: Fix PanoramiX overlay window release 2026-08-08 20:11:24 +00:00
config config: remove the fdi2iclass.py script 2026-10-03 13:23:14 -07:00
damageext damageext: fix wrong REQUEST_SIZE_MATCH type in SProcDamageAdd 2026-04-24 01:09:42 +00:00
dbe Zero out structs to avoid leaking information via padding 2026-04-24 01:14:55 +00:00
dix Use _X_FALLTHROUGH macro to silence fallthrough warnings in clang as well 2026-09-12 18:25:58 +00:00
doc meson: replace join_paths() with / operator 2026-03-28 10:02:41 -07:00
dri3 meson: only install dri3.h if building dri3 support 2026-09-01 01:21:05 +00:00
exa exa: silence -Wold-style-declaration warning from gcc 16 2026-08-09 15:29:21 -07:00
fb Use _X_FALLTHROUGH macro to silence fallthrough warnings in clang as well 2026-09-12 18:25:58 +00:00
glamor glamor/glamor_egl: Add a fallback path to glamor_gbm_bo_from_pixmap_internal 2026-10-03 23:10:26 +00:00
glx glx: validate dataBytes against cmdlen in RenderLarge first request 2026-10-06 15:25:16 +10:00
hw Generalize GBM feature tests 2026-10-03 13:43:30 -07:00
include xkb: widen size_syms, num_syms, size_acts, num_acts to unsigned int 2026-10-06 15:25:16 +10:00
man Disable font server connections by default 2026-07-30 10:07:05 +10:00
mi Use _X_FALLTHROUGH macro to silence fallthrough warnings in clang as well 2026-09-12 18:25:58 +00:00
miext miext/sync: Handle SIGBUS from truncated shm fences 2026-10-03 20:59:50 +00:00
os os: Add busfault_set_jmp() for SIGBUS unwind 2026-10-03 20:59:50 +00:00
present present: unlink notifies from window list in present_clear_window_notifies 2026-10-06 15:25:16 +10:00
pseudoramiX pseudoramiX: add missing byte swapping in various fields 2026-04-24 01:55:37 +00:00
randr randr: fix size and offset in RRChangeProviderProperty PrependMode 2026-10-06 15:25:16 +10:00
record Strip trailing whitespace from source files 2026-01-25 10:40:02 -08:00
render Use _X_FALLTHROUGH macro to silence fallthrough warnings in clang as well 2026-09-12 18:25:58 +00:00
test present: unlink notifies from window list in present_clear_window_notifies 2026-10-06 15:25:16 +10:00
Xext Use _X_FALLTHROUGH macro to silence fallthrough warnings in clang as well 2026-09-12 18:25:58 +00:00
xfixes Add log messages when ForceTerminate is blocked 2026-07-12 12:34:36 -07:00
Xi Xi: validate modifier values in ProcXIPassiveUngrabDevice 2026-10-06 15:25:16 +10:00
xkb xkb: fix CheckKeySyms overwriting request-range symsPerKey entries 2026-10-06 15:25:16 +10:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.git-blame-ignore-revs Ignore the coding style change commit during git blame 2026-01-25 10:39:58 -08:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml ci: Run ruff check against the whole tree 2026-10-03 13:23:49 -07:00
.mailmap Update mailmap for Peter Harris 2026-01-25 10:40:01 -08:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING config: remove the fdi2iclass.py script 2026-10-03 13:23:14 -07:00
meson.build Generalize glamor dependencies 2026-10-03 13:43:30 -07:00
meson_options.txt glx: include: meson_options.txt: Allow disabling DRI glx backends 2026-10-03 20:05:22 +00:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
SECURITY.md Create a SECURITY.md file 2026-01-25 10:40:03 -08:00
xorg-server.m4 Strip trailing whitespace from source files 2026-01-25 10:40:02 -08:00
xorg-server.pc.in pkgconfig files: Add URL 2026-01-25 10:40:01 -08:00
xserver.ent.in

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct