Joe Shaw
e354ccac36
fix a sign problem with valuator data. ...
Without this patch, any negative valuator value is wrong when returned
from XQueryDeviceState(). This is a regression from at least xserver
1.4.
Valuator data is set in dix/getevents.c:set_valuators() by copying
signed int values into an unsigned int field
DeviceEvent.valuators.data.
That data is converted into a double with an implicit cast by
assignment to axisVal[i] in Xi/exevents.c:UpdateDeviceState().
That double is converted back to a signed int in
queryst.c:ProcXQueryDeviceState(). If the original value in
set_valuators() is negative, the double value will be > 2^31 and the
conversion back to a signed int is undefined. (Although I
consistently see the value -2^31.)
Fix this by changing the definition of DeviceEvent.valuators.data from
uint32_t to int32_t.
Signed-off-by: Joe Shaw <joeshaw@litl.com>
Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2010-10-18 10:16:23 +10:00
Misc coding style cleanup
2010-05-13 06:16:48 +07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
Use GetCurrentRootWindow or equivalent instead of spriteTrace[0].
2010-10-13 15:58:12 +10:00
Comparison between pointer and integer in latest dix/dispatch.c
2010-10-13 10:20:06 -07:00
xserver: delete pervasively use of DISPATCH_PROC
2010-09-28 16:45:05 +03:00
dixfonts: Deobfuscate GC ops calls.
2010-09-13 15:55:17 -07:00
dix: optimize CallCallbacks
2010-10-13 09:24:06 -07:00
Use GetCurrentRootWindow or equivalent instead of spriteTrace[0].
2010-10-13 15:58:12 +10:00
dix: don't create core motion events for non-x/y valuators.
2010-09-01 14:42:44 +10:00
Use GetCurrentRootWindow or equivalent instead of spriteTrace[0].
2010-10-13 15:58:12 +10:00
Replace malloc/strlen/strcpy with strdup.
2010-08-27 19:05:48 -04:00
Un-export CreateScratchGC now that nothing external uses it.
2010-09-13 15:58:08 -07:00
fix a sign problem with valuator data.
2010-10-18 10:16:23 +10:00
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
Replace dixChangeGC with calls directly to the right variant.
2010-05-13 17:14:07 -07:00
Remove more superfluous if(p) checks around free(p)
2010-06-06 20:27:18 +07:00
Return Success from generate_modkeymap() when max_keys_per_mod is zero
2010-09-01 14:44:46 +10:00
dix: remove proc tables initialization
2010-09-28 16:46:46 +03:00
Move mi/miregion.c to dix/region.c
2010-06-05 17:48:20 -07:00
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
Introduce per-object per-screen privates.
2010-09-18 11:17:18 +02:00
Fix property and selection devPrivate allocation.
2010-09-10 11:44:12 -07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
Replace X-allocation functions with their C89 counterparts
2010-05-13 00:22:37 +07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
Fix property and selection devPrivate allocation.
2010-09-10 11:44:12 -07:00
Replace X-allocation functions with their C89 counterparts
2010-05-13 00:22:37 +07:00
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
dix: remove proc tables initialization
2010-09-28 16:46:46 +03:00
dix: reset pScreen->root to NULL when root window is deleted.
2010-08-16 11:50:22 -07:00
Update Sun license notices to current X.Org standard form
2009-12-16 17:11:35 -08:00
Update Sun license notices to current X.Org standard form
2009-12-16 17:11:35 -08:00
e354ccac36