Alan Coopersmith
50b1097643
Constify the reason string throughout the authorization check framework ...
Almost all of the places the string is assigned point to a literal
string constant, so use const char * for those, and const char **
for function calls that return it via an argument. Fortunately
the top level function, ClientAuthorized, which returns the string
as its return value is called from only one place, ProcEstablishConnection.
ProcEstablishConnection stores either that return value or a string literal
in char *reason. It only uses reason as an argument to SendConnSetup.
SendConnSetup passes the reason argument to strlen & WriteToClient,
both of which already have const qualifiers on their args.
Thus added const to the reason variable in ProcEstablishConnection
and the reason argument to SendConnSetup.
Fixes gcc warnings:
dispatch.c: In function 'ProcEstablishConnection':
dispatch.c:3711:9: warning: assignment discards qualifiers from pointer target type
auth.c: In function 'CheckAuthorization':
auth.c:218:14: warning: assignment discards qualifiers from pointer target type
auth.c:220:20: warning: assignment discards qualifiers from pointer target type
connection.c: In function 'ClientAuthorized':
connection.c:683:3: warning: return discards qualifiers from pointer target type
mitauth.c: In function 'MitCheckCookie':
mitauth.c:88:13: warning: assignment discards qualifiers from pointer target type
xdmauth.c:259:14: warning: assignment discards qualifiers from pointer target type
xdmauth.c:270:14: warning: assignment discards qualifiers from pointer target type
xdmauth.c:277:11: warning: assignment discards qualifiers from pointer target type
xdmauth.c:293:15: warning: assignment discards qualifiers from pointer target type
xdmauth.c:313:14: warning: assignment discards qualifiers from pointer target type
xdmauth.c:322:11: warning: assignment discards qualifiers from pointer target type
rpcauth.c: In function 'SecureRPCCheck':
rpcauth.c:136:10: warning: assignment discards qualifiers from pointer target type
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
2011-12-12 17:03:10 -08:00
.gitignore: use common defaults with custom section #24239
2009-11-11 21:40:20 -08:00
dix: optimize CallCallbacks
2010-10-13 09:24:06 -07:00
os: Add facilities for client ID tracking.
2010-12-23 13:53:18 +02:00
dixfonts: Deobfuscate GC ops calls.
2010-09-13 15:55:17 -07:00
Quit using clientErrorValue in dix/colormap.c.
2010-05-13 17:14:07 -07:00
Revert "Bug #6924 : Restore the ABI for DrawableRec and ColormapRec to the state"
2011-09-19 22:31:21 -07:00
Eliminate MAXSCREENS-sized CursorScreenKey array.
2011-09-19 22:53:05 -07:00
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
Move the apple fat binary hacks back to a header file, and make it apple-only.
2009-01-30 16:36:45 -08:00
Move to autoconf standard function name checks & defines
2011-12-05 14:32:45 -08:00
Merge remote-tracking branch 'whot/for-keith'
2011-12-08 20:57:26 -08:00
dix: add a new DixAccess bit, "DixPostAccess".
2009-06-26 17:05:52 -04:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
dix: use one single function to register fpe fonts
2010-06-24 13:55:28 -07:00
Remove #define NEED_EVENTS and NEED_REPLIES
2008-12-12 11:43:32 +10:00
dix: add CopyGrab() function
2011-12-09 14:56:23 +10:00
Save major/minor opcodes in ClientRec for RecordAReply
2011-12-01 15:11:20 +00:00
Input: Allow EventToCore to return multiple events
2011-02-17 09:40:59 +10:00
XQuartz: Transition from xEvent based mieq to InternalEvent
2009-09-27 23:31:07 -07:00
dix: add ScrollInfo to DeviceChangedEvents
2011-10-25 14:06:41 +10:00
Make XIGetKnownProperty take a const char * argument
2011-11-23 12:15:06 -08:00
Save major/minor opcodes in ClientRec for RecordAReply
2011-12-01 15:11:20 +00:00
Fix gcc -Wwrite-strings warnings in various extensions
2011-11-23 12:15:07 -08:00
Fix gcc -Wwrite-strings warnings in various extensions
2011-11-23 12:15:07 -08:00
Un-export CreateScratchGC now that nothing external uses it.
2010-09-13 15:58:08 -07:00
Delete unused lastWinOrg field from GCs.
2010-09-13 15:55:17 -07:00
config: add udev/systemd multi-seat support
2011-08-22 15:56:49 +10:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
Add a new XI2Mask struct and a few helper functions.
2011-12-09 14:56:23 +10:00
input: swap the server over to use the XI2mask struct
2011-12-09 14:56:23 +10:00
Add a new XI2Mask struct and a few helper functions.
2011-12-09 14:56:23 +10:00
kdrive: Add option to compile out input drivers
2010-01-06 19:47:53 +06:00
include: rename "foos" to "list_of_foos" in the struct list documentation
2011-12-06 18:15:15 +10:00
Add 'optionstr.h' to include/Makefile.am
2011-11-20 14:50:57 -08:00
include: add BUG_WARN_MSG for custom error message on bug condition
2011-12-09 14:56:24 +10:00
dix: adds support for none root window background
2010-11-11 23:24:43 +02:00
input: switch InputOption to use XF86OptionRec storage.
2011-10-25 14:06:39 +10:00
Constify the reason string throughout the authorization check framework
2011-12-12 17:03:10 -08:00
dix: Remove the memory of the multibuffer extension
2010-10-13 09:18:41 -07:00
Revert "dix: Remove usage_hint from pixmaps, store it in ->drawable.class"
2011-03-17 23:48:52 -07:00
"privates.h", line 198: warning: void function cannot return value
2011-05-27 19:52:10 -07:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
dix: Shrink PropertyRec on LP64
2011-03-14 13:44:46 -04:00
Support (and require) XI 2.1
2011-09-29 14:09:41 +10:00
Input: Widen pointer acceleration types to double
2011-09-29 12:24:33 +10:00
Add RegionInitBoxes(), and fix some buggy callers of RegionInit().
2011-04-22 21:39:31 -04:00
constify strings in resource name registry
2011-12-12 17:03:08 -08:00
constify strings in resource name registry
2011-12-12 17:03:08 -08:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
Store desktop dimensions in screenInfo.
2011-10-13 11:26:09 +10:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
xfree86: nds32: add nds32 related definitions into include headers.
2010-09-23 15:35:48 -07:00
dix: delete logo hack screen saver
2010-11-11 23:20:35 +02:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
Rework symbol visibility for easier maintenance
2008-12-03 05:43:34 -02:00
Move VENDOR_* defines from AC_SUBST to a header to avoid angering shave.
2009-04-14 10:35:44 -04:00
DIX: Make PrintWindowTree actually useful
2011-07-01 08:46:15 +10:00
composite: Inhibit window background paint with manual subwindow redirection
2011-08-03 20:46:36 -07:00
input: Purge AddOtherInputDevices DDX hook.
2010-09-01 15:26:52 +10:00
Move to autoconf standard function name checks & defines
2011-12-05 14:32:45 -08:00
Mark XKB char * as const to clean up gcc -Wwrite-strings warnings
2011-11-23 12:15:06 -08:00
XKB: Remove descriptions from maprules
2009-01-22 15:08:56 +11:00
Mark XKB char * as const to clean up gcc -Wwrite-strings warnings
2011-11-23 12:15:06 -08:00
Revert "XKB: Sanitise * actions" commits ( #19602 )
2009-07-10 11:23:52 +10:00
configure: wrap PCI code with macro and set it at build time
2011-10-15 21:18:47 -07:00
Fix gcc warnings about redundant declarations of fallback functions
2011-12-05 14:32:59 -08:00
Add asprintf() implementation for platforms without it
2010-12-07 11:10:35 -08:00
Input: Add vertical and horizontal scroll axes
2011-09-29 12:26:43 +10:00
Move SHA1 computation from render/glyph.c to os/
2009-10-15 01:17:44 +02:00
Remove unused function checks from configure.ac & include/*.h.in
2011-12-03 10:19:12 -08:00
50b1097643