Enrico Weigelt, metux IT consult
ed289f734b
os: don't ever try to mess with stderr / fd 2
...
1. We've got some ancient code here that's trying to open stderr (fd 2) itself,
in case it cannot write there for strange reason. POSIX defines the three
standard streams (and associated fd's) to be available on program startup
(when main() is reached). One needs a sledgehammer for breaking a system
so much that this doesn't work anymore - even calling a program directly
from /etc/inittab does provide them.
2. The current implementation is not POSIX conformant - it should use freopen(),
and it leaks FILE structure.
3. stderr is set to buffered mode, quite the opposite of POSIX - it states
stderr shall NOT be buffered. Simple and obvious reason: not risking vital
error information getting lost.
4. Placing The logfile in /usr/adm - an ancient, pre-FHS, directory that rarely
exists on modern systems. That's even hardcoded, instead of derived from
build-time given installation pathes.
Conculusio: obsolete and broken, thus removing it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:32:00 +02:00
..
.gitignore
access.c
os: unexport ClientIsLocal()
2025-02-18 10:53:44 +00:00
alloc.c
os: move alloc functions to separate source file
2024-02-29 10:09:37 +00:00
audit.h
os: unexport audit functions
2024-04-15 19:54:34 +00:00
auth.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
auth.h
os: unexport fields from opaque.h not used by modules / drivers
2024-06-23 21:19:27 +00:00
backtrace.c
os: backtrace: Fix -Wincompatible-pointer-types compiler error on 32-bit targets
2025-02-07 16:58:02 +02:00
bug_priv.h
os: move BUG_*() macros to own private header
2025-02-17 19:32:48 +00:00
busfault.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
busfault.h
os: fix missing include of misc.h in busfault.h
2024-04-16 14:19:59 +02:00
client.c
os: split off internal definitions from client.h
2024-10-10 13:45:29 +00:00
client_priv.h
os: unexport SetCriticalOutputPending()
2025-02-23 17:39:18 +00:00
cmdline.h
os: unexport command line args handling functions
2024-04-15 21:21:40 +00:00
connection.c
os: connection.c should include header that defines GrabInProgress
2025-04-19 17:02:15 +00:00
ddx_priv.h
os: unexport ddx callbacks
2024-05-08 09:37:35 +02:00
fmt.c
os: move out Format*() functions
2024-03-09 17:34:51 +00:00
fmt.h
misc.h: unexport compare_version()
2025-02-18 11:17:40 +00:00
inputthread.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
io.c
os: unexport ReadRequestFromClient()
2025-02-18 10:53:44 +00:00
log.c
os: let vpnprintf() accept %X
2025-02-28 12:51:44 +01:00
meson.build
os: move out LockServer logic from util.c to serverlock.c
2024-07-26 22:26:07 +00:00
mitauth.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
mitauth.h
os: move Auth* function types to separate header
2024-02-22 23:42:53 +00:00
osdep.h
os: drop self-limiting resources
2025-06-12 16:31:57 +02:00
osinit.c
os: don't ever try to mess with stderr / fd 2
2025-06-12 16:32:00 +02:00
ospoll.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
ospoll.h
reallocarray.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
screensaver.h
os: unexport screen saver timer functions
2024-09-01 20:23:10 +00:00
serverlock.c
os: move -nolock help message printing to serverlock.h
2024-07-26 22:26:07 +00:00
serverlock.h
os: move -nolock help message printing to serverlock.h
2024-07-26 22:26:07 +00:00
strcasecmp.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
strcasestr.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
string.c
os: move string functions to separate source file
2024-02-29 10:09:37 +00:00
strlcat.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
strlcpy.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
strndup.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
timingsafe_memcmp.c
utils.c
os: drop self-limiting resources
2025-06-12 16:31:57 +02:00
WaitFor.c
os: drop unused TimerCheck()
2025-02-23 17:46:13 +00:00
xdmauth.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
xdmauth.h
os: move Auth* function types to separate header
2024-02-22 23:42:53 +00:00
xdmcp.c
os: if getaddrinfo() is available, use it, even if IPv6 support is disabled
2025-01-27 22:34:51 +00:00
xdmcp.h
Fix build with -Dxdmcp=false
2024-02-25 11:55:56 +01:00
xprintf.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
xserver_poll.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
xserver_poll.h
os: move xserver_poll.h into os/ directory
2024-06-21 00:53:39 +00:00
xsha1.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00
xsha1.h
include: move xsha1.h to os/
2024-03-03 23:11:05 +00:00
xstrans.c
drop obsolete HAVE_DIX_CONFIG_H
2024-10-10 13:38:31 +00:00