Chris Wilson
6dae7f3792
xace: Invalid reference to out-of-scope data.
...
The callback data passed by reference to the hook was allocated on stack
within the scope of the case statement. The compiler is free to reuse
any of that stack space whilst making the function call so we may end up
passing garbage into the callback.
References:
Bug 18451 - Xorg server 1.5.2 SEGV during XFixesGetCursorImage()
https://bugs.freedesktop.org/show_bug.cgi?id=18451
v2: Drop the unrelated hunk that snuck in when ammending the commit
message.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
2010-08-10 16:04:16 -07:00
..
bigreq.c
Eliminate boilerplate around client->noClientException.
2010-05-13 17:14:07 -07:00
dpms.c
Eliminate boilerplate around client->noClientException.
2010-05-13 17:14:07 -07:00
dpmsproc.h
DPMS: Remove unused DPMSGet()
2009-04-03 18:22:20 -04:00
dpmsstubs.c
DPMS: Remove unused DPMSGet()
2009-04-03 18:22:20 -04:00
geext.c
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
geext.h
Xext: remove ev_fill from GEExtensions.
2009-03-20 15:17:54 +10:00
geint.h
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
Makefile.am
xext: delete wrong source reference from fontcache
2010-06-03 15:55:59 +03:00
panoramiX.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
panoramiX.h
Delete panoramiXdataPtr: it's redundant.
2010-06-03 14:03:23 -07:00
panoramiXh.h
Centralize declaration of ConnectionInfo.
2008-08-20 13:14:34 -04:00
panoramiXprocs.c
Fix a couple more possible errors with input-only windows
2010-06-10 19:15:28 -07:00
panoramiXsrv.h
XineramaSetCursorPosition: use screen bounds directly, not POINT_IN_REGION.
2010-06-03 14:03:23 -07:00
panoramiXSwap.c
Merge branch 'master' into mpx
2008-01-03 17:04:54 +10:30
saver.c
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
security.c
SecurityResource should not segfault when client owning resource has exited
2010-06-10 18:58:54 -07:00
securitysrv.h
Xext: include security protocol header instead of client header
2009-09-20 19:57:01 +10:00
shape.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
shm.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
shmint.h
Update to xextproto 7.0.99.1.
2009-07-15 17:00:05 +10:00
sleepuntil.c
Replace X-allocation functions with their C89 counterparts
2010-05-13 00:22:37 +07:00
sleepuntil.h
Remove RCS tags. Fix Xprint makefile braindamage.
2006-07-21 17:56:00 -04:00
sync.c
Add typed resource-lookup errors for non-core resource types.
2010-05-19 12:32:48 -07:00
syncsrv.h
Xext: silence 'warning: no previous prototype' for sync, bigreq and xcmisc.
2009-09-21 09:17:56 +10:00
xace.c
xace: Invalid reference to out-of-scope data.
2010-08-10 16:04:16 -07:00
xace.h
Correct outdated e-mail address in "Author" statements.
2009-09-02 17:56:52 -04:00
xacestr.h
Correct outdated e-mail address in "Author" statements.
2009-09-02 17:56:52 -04:00
xcalibrate.c
Set event sequence number in WriteEventsToClient instead of at callers.
2010-05-19 12:32:34 -07:00
xcmisc.c
Eliminate boilerplate around client->noClientException.
2010-05-13 17:14:07 -07:00
xf86bigfont.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
xf86bigfontsrv.h
New header for XF86Bigfont server functions
2010-03-22 00:48:04 -05:00
xres.c
Eliminate boilerplate around client->noClientException.
2010-05-13 17:14:07 -07:00
xselinux.h
xselinux: Bump extension minor version.
2010-02-22 17:05:01 -05:00
xselinux_ext.c
Eliminate boilerplate around client->noClientException.
2010-05-13 17:14:07 -07:00
xselinux_hooks.c
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
xselinux_label.c
Replace X-allocation functions with their C89 counterparts
2010-05-13 00:22:37 +07:00
xselinuxint.h
Change the devPrivates API to require dixRegisterPrivateKey
2010-06-05 19:23:03 -07:00
xtest.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
xvdisp.c
Remove unnecessary parentheses around return values in functions
2010-06-10 06:42:42 -07:00
xvdisp.h
Fix swapped Xv dispatch under Xinerama.
2007-12-02 14:15:36 -05:00
xvdix.h
Add typed resource-lookup errors for non-core resource types.
2010-05-19 12:32:48 -07:00
xvmain.c
xv: Don't send port notify when SetPortAttribute fails
2010-06-21 19:03:20 -07:00
xvmc.c
Remove more superfluous if(p) checks around free(p)
2010-06-06 20:27:18 +07:00
xvmcext.h
Use libtool convenience libraries and better "symbol" table.
2008-12-07 02:22:19 -02:00