hashirama/ajattix
hashirama/ajattix
2
1
Fork 1
Code Issues 1 Pull requests Projects Releases Wiki Activity

packages: dictionaries: Set PKG_CONFIG_PATH env var instead of patching headers in goldendict-ng package definition #2

Merged
hashirama merged 1 commit from anemofilia/ajattix:main into main 2024-08-01 01:56:32 +00:00
Conversation 1 Commits 1 Files changed 1 +20 -35
anemofilia commented 2024-08-01 01:31:14 +00:00
Contributor
Copy link

This commit reverts the hacky solution we made some months ago to the problem of some qt headers not being found during build, and replaces it with the proper solution: setting up the PKG_CONFIG_PATH environment variable.

This commit reverts the hacky solution we made some months ago to the problem of some qt headers not being found during build, and replaces it with the proper solution: setting up the PKG_CONFIG_PATH environment variable.
anemofilia added 1 commit 2024-08-01 01:31:15 +00:00
hashirama commented 2024-08-01 01:56:16 +00:00
Owner
Copy link

simplifications are welcome, this seems much cleaner and better than our previous workaround.

simplifications are welcome, this seems much cleaner and better than our previous workaround.
hashirama merged commit e21d64195e into main 2024-08-01 01:56:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hashirama/ajattix#2
No description provided.
Delete branch "anemofilia/ajattix:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?