hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-11-24 04:24:09 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity

Eliminate a redundant makeScanPopup() call

Browse source 
Destroying and creating a scan popup instance twice in
MainWindow::editPreferences() is wasteful.

2b9dd55804 added the unconditional second
makeScanPopup() call below but didn't remove the existing call,
probably by mistake.
This commit is contained in:
Igor Kushnir 2018-04-18 22:06:45 +03:00
parent 0a8599d9b1
commit eec796c6e3
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
mainwindow.cc
View file

@ -2109,7 +2109,6 @@ void MainWindow::editPreferences()
updateTrayIcon(); updateTrayIcon();
applyProxySettings(); applyProxySettings();
applyWebSettings(); applyWebSettings();
makeScanPopup();
ui.tabWidget->setHideSingleTab(cfg.preferences.hideSingleTab); ui.tabWidget->setHideSingleTab(cfg.preferences.hideSingleTab);