Commit graph

43 commits

Author SHA1 Message Date
YiFang Xiao 3f968027b6 fix: warning about "Release of profile requested but WebEnginePage still not deleted"
fix #955
2023-07-12 14:36:49 +08:00
YiFang Xiao 0592d2060e fix: a possible crash of restoreState() in linux with qt6.5.1
fix #952
2023-07-11 21:38:50 +08:00
xiaoyifang 16f853b68b
fix: qtimer release memory (#863)
* fix: memory leakage
2023-06-16 08:37:33 +08:00
shenleban tongying b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
2023-06-11 10:17:20 -04:00
shenleban tongying f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax
Historical context: `MainWindow::addGlobalAction` was invented by

https://github.com/goldendict/goldendict/pull/482/files
2023-06-11 04:47:39 -04:00
YiFang Xiao 799370f5ef fix: adjust margin around dictionary group 2023-06-10 14:45:48 +08:00
xiaoyifang 9c1a77a3f8
fix regression: select translation line text when got focused (#841)
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 10:36:59 +08:00
YiFang Xiao fc08c16479 fix: merge history items when import history items 2023-06-09 21:57:09 +08:00
xiaoyifang f02fc350f8
fix: keep the application name unchanged for now (#835)
fix: Windows autostart reg entry use GoldenDict as entry name
2023-06-09 19:56:51 +08:00
xiaoyifang 9d047fea61
fix: add an --reset-windows-state option to command line (#829)
* fix: add an --reset-windows-state option to command line

* add an option
2023-06-09 19:56:04 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter
the parameter has no use right now
2023-06-08 08:30:23 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808)
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-05 21:22:20 +08:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804)
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect
fix #718
2023-06-03 17:49:37 +08:00
shenleban tongying 6823254bac clean: solve a TODO about translateInputFinished 2023-05-31 07:26:43 +08:00
shenleban tongying 6c7bb05f35 clean: convert SLOT translateInputFinished to new syntax 2023-05-31 07:26:43 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
2023-05-30 20:59:51 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736)
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
2023-05-29 00:01:54 +08:00
xiaoyifang 4eb8374a35
opt: mdx fulltext lock seperated with normal search (#759)
* opt: refactor mdx fullindex creation

* opt: incremental fulltext creation logic change

* opt: incremental fulltext creation logic change

* opt: progress of fulltext creation logic

* opt: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smell

* fix: code smell

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-29 00:01:21 +08:00
YiFang Xiao a8b6fbc754 opt: make the searchPanel can resize to a smaller width
🎨 apply clang-format changes

opt: make the searchPanel can resize to a smaller width

🎨 apply clang-format changes

fix:remove group label in docker
2023-05-23 19:03:21 +08:00
xiaoyifang d08d5fe576
opt: let qt handle the language direction (#709)
* opt: let qt handle the language direction

* 🎨 apply clang-format changes

* action: modify auto clang format action

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-19 19:41:27 +08:00
YiFang Xiao 1e328e0727 fix: qwarning placed in the wrong place 2023-05-19 19:40:19 +08:00
shenleban tongying d0b2349156 update .desktop and appstream xml 2023-05-18 10:27:40 +08:00
xiaoyifang d174dc16ba
opt:remove non-xapian fulltext creation logic (#643)
* opt!:remove non-xapian fulltext creation logic

BREAKING CHANGE: after this PR, xapian package will have to installed
before the compilation. on Linux, this should be libxapian-dev package.

For common users: all created fulltext which is not created by xapian
before will be recreated using the new
engine.

* fix: remove old fulltext search ui

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-17 22:29:56 +08:00
YiFang Xiao ced19b9f11 Revert "feature:webengineprofile use non off record profile"
This reverts commit e84b5aa861.
2023-05-16 04:44:48 -08:00
YiFang Xiao 967926cee4 fix: press enter the article view does not get the focus
fix #660
2023-05-13 22:57:08 +08:00
YiFang Xiao 3a24a43410 fix: when use arrow key in foundDictionaryPanel ,jump to the target dictionary 2023-05-11 18:43:02 +08:00
yifang xiao 2b72e14b55 fix: phrase send from scanpopup should not escape again
fix #626
2023-05-11 07:08:02 +08:00
shenleban tongying 70fd2d18f8 clean: use new Signal Slot syntax 2023-04-29 19:15:43 +08:00
shenleban tongying 6498bd4f17 clean: convert navPronounce connect to new syntax 2023-04-29 19:15:19 +08:00
YiFang Xiao 617589d09c fix:unified the cache/directory
supplement to a82ce2a86f
2023-04-27 13:25:57 +08:00
xiaoyifang a82ce2a86f opt: use unified cache dir
seperate the persistentstoragepath with cachepath
2023-04-26 07:45:48 +08:00
xiaoyifang 04260c1fbe fix: can not remove favorite word in popup
this bug was existed for a long time
2023-04-25 23:07:22 +08:00
xiaoyifang 19889bfa9b opt:add a statusbar notification when finshed save article
fix #554
2023-04-25 22:22:30 +08:00
shenleban tongying d0ae253c27 docs: various updates
* isolate Help related code into help.hh
* update website & README.md
2023-04-22 18:21:14 +08:00
shenleban tongying 3f3ba6eee1 refactor: reduce dependency on mainwindow.hh
* editdictionaries.cc and dictheadwords.cc doesn't actually need it
* fulltextsearch has a useless static_cast
2023-04-20 19:53:17 +08:00
shenleban tongying 5c5db459b5 feat(cli): implement --toggle-scan-popup command line option 2023-04-18 17:36:42 +08:00
Xiao YiFang 14c4366839 fix: when input word in translateline and press Enter
can not type word directly again.

fix:#185
2023-04-18 16:08:32 +08:00
Xiao YiFang 75b0a92be7 fix: remove unused windowsstyle.cc(.hh)
fix #512
2023-04-18 16:04:54 +08:00
shenleban tongying 03af31c6fc
refactor: move common/base/utils into /src/common/ 2023-04-17 20:41:47 -04:00
shenleban tongying b602bc0e9f fix(qmake): macOS build 2023-04-17 20:00:36 -04:00
shenleban tongying 8b8ad5d23d
refactor: move all ui related files to /src/ui/ 2023-04-17 19:11:58 -04:00
Renamed from src/mainwindow.cc (Browse further)