Commit graph

4223 commits

Author SHA1 Message Date
shenleban tongying 32304d4b15 cleanup: remove all useless #include <QDebug>
All Qt Headers already implicitly included it.
2023-03-21 21:15:14 +08:00
shenleban tongying 13add70db2 cleanup: remove unnecessary variables in ArticleMaker
4 variables are removed because they are always read-only and always the same as global config. There is no reason to keep or update a separate copy.
2023-03-21 17:42:52 +08:00
shenleban tongying 0731253489 cleanup: simplify DSL's expand mode
Related code was related to DSL's [*][/*] tag.

One of the feature removed is Ctrl+8 to toggle current articleview's AlwaysExpand mode, because DSL is the only format that has this feature and User can turn on AlwaysExpand Mode on Preferences. There is no need to assign a shortcut for it.
2023-03-21 15:34:55 +08:00
Xiao YiFang 7ac1877544 replace qt6.3.2 with 6.4.3 2023-03-21 09:20:28 +08:00
xiaoyifang e2e26bc7bc
Merge pull request #405 from xiaoyifang/fix/epwing-tr
epwing:translation does not work
2023-03-21 07:31:48 +08:00
xiaoyifang b3a1d27c2f
Merge pull request #401 from xiaoyifang/fix/epwing-load-article
fix: epwing load article protection when load invalid address
2023-03-21 00:56:48 +08:00
Xiao YiFang fe6808d07a epwing:translation does not work 2023-03-21 00:56:01 +08:00
Xiao YiFang 8cc5c54b78 refactor: remove unneccessary macro condition 2023-03-21 00:01:02 +08:00
Xiao YiFang d4c285226c fix: sonarcloud analysis
if,switch, and range-based for loop initializer should be used to reduce scope of variables cpp:S6004
2023-03-20 23:47:23 +08:00
xiaoyifang 669be41d9a
Merge pull request #404 from xiaoyifang/fix/restore-max
fix: windows can not restore the Geometry
2023-03-20 23:36:30 +08:00
Xiao YiFang 736a9aad23 epwing:does not add ref link to the history 2023-03-20 23:26:27 +08:00
Xiao YiFang 4282827506 epwing:handle invalid position 2023-03-20 23:26:17 +08:00
Xiao YiFang b9e8f644be fix: enable tabwidget scrollbuttons
fix #397
2023-03-20 22:54:49 +08:00
Xiao YiFang a5f9560b99 fix: windows can not restore the Geometry
fix #312

the reason is still unknown , when invoke the addNewTab, the window's size was reset to its default size
2023-03-20 22:54:04 +08:00
xiaoyifang 71935fb929
add auto translation action to non-English issues 2023-03-20 18:00:32 +08:00
shenleban tongying 3a93f8b959 Revert "fix: white flash when WebEngine page is loading in dark reader mode"
This reverts commit f7d6328f40.
2023-03-20 13:42:39 +08:00
Xiao YiFang 4008e47625 add some zh_CN translation 2023-03-19 20:52:12 +08:00
Xiao YiFang e4ccf1b378 feature:display dictionary description as html 2023-03-19 12:52:56 +08:00
Xiao YiFang 8bfc0fee23 epwing: add translation zh_CN.ts 2023-03-19 10:35:13 +08:00
Xiao YiFang c4674a246f feature: epwing dictionary reference navigation improved.
feature: add branch method to handle the reference navigation loadArticle function

feature: refactor epwing loadArticle method

epwing: add previous and next page link
2023-03-19 10:35:13 +08:00
shenleban tongying f7d6328f40 fix: white flash when WebEngine page is loading in dark reader mode 2023-03-18 19:53:08 +08:00
shenleban tongying fac1247c10 refactor: properly modularize articleview's ui 2023-03-18 11:00:06 +08:00
shenleban tongying a75867f82b refactor: convert articleview into plain code 2023-03-18 11:00:06 +08:00
Ren Tatsumoto fb6d4f9ccd
Let the user disable main window stealing focus when searching. (#387)
* add a checkbox that allows the user to disable main window being raised when search is triggered

* run clang-format on the edited lines

* partially revert clang-format
2023-03-17 09:54:45 +08:00
xiaoyifang 76fa9a806a change .clang-format style
ConstructorInitializerIndentWidth : 2
2023-03-17 09:51:06 +08:00
xiaoyifang ce40e66464
Update how to use .clang-format to format the code.md 2023-03-17 09:02:15 +08:00
Ren Tatsumoto 1a0af48a7a
Improve Anki support (#384)
* allow the user to configure word,text,sentence Anki fields

* if sentence field is not set, don't add it

* mark the target word bold, if possible

* Update how to connect with anki.md

* rename default field names
2023-03-16 19:55:47 +08:00
xiaoyifang c12c07a3a7 fix: typo 2023-03-16 15:56:26 +08:00
xiaoyifang a0211e258c
add code guildline when contributing code 2023-03-16 15:40:57 +08:00
xiaoyifang c012cc9140
add clang-format usage 2023-03-16 15:35:04 +08:00
xiaoyifang fa06c85d6d bump qt version to qt6.4.3 2023-03-16 14:17:13 +08:00
Xiao YiFang 91eefed48a fix:status bar when at the startup does not position correctly 2023-03-15 22:58:11 +08:00
Xiao YiFang 31c72dacdc fix: some mdx dictionary's description can be be displayed if using html 2023-03-15 21:34:11 +08:00
xiaoyifang 7242a53302 made some clang-format changes
BraceWrapping->AfterControlStatement:false
             ->BeforeCatch:true
2023-03-13 20:16:58 +08:00
Xiao YiFang 5b56790910 Merge remote-tracking branch 'gd/master' into staged 2023-03-11 14:22:05 +08:00
Xiao YiFang a54ee3e716 fix: convert string literal to Raw string to remove code smell 2023-03-11 14:10:02 +08:00
Xiao YiFang eb5ae99da9 fix: anchor #hashtag navigation failed to work 2023-03-11 14:10:02 +08:00
Xiao YiFang 61547dff03 feature: refactor the mainstatusbar 2023-03-11 11:04:07 +08:00
shenleban tongying 10a79372f8 fix: better QObject hierarchy
* set scanpopup's parent to null because it is a top level window.
* set macClipboard as a child of the mainWindow
2023-03-09 14:14:18 +08:00
shenleban tongying 9079e2125d fix: move enableScanningAction code after scanPopup's initialization 2023-03-07 17:46:52 +08:00
xiaoyifang afa77a8f31 fix: remove unused code 2023-03-07 17:46:37 +08:00
xiaoyifang 84798c56ea fix:check scanPopup existence 2023-03-07 10:09:18 +08:00
shenleban tongying 4f2c8d55aa refactor: port away from extlineedit
* the main feature of extlineedit.cc was having icons on left and right side which is already provided by QLineEdit::addAction after Qt5.2
2023-03-06 09:46:32 +08:00
xiaoyifang 9b7b64e174
Merge pull request #368 from shenlebantongying/qrcx_to_qrc
cleanup: Replace all usages of qrcx://localhost with qrc://
2023-03-06 07:33:21 +08:00
shenleban tongying 540dda26ed cleanup: Replace all usages of qrcx://localhost with qrc://
The replacement command:
git grep -l 'qrcx://localhost' | xargs sed -i 's/qrcx:\/\/localhost/qrc:\/\//g'

The qrcx:// URL scheme was introduced in 2009 or earlier - it is present
in the first commit in GoldenDict's git history. Back then GoldenDict
supported Qt versions earlier than 4.6, in which
QWebSecurityOrigin::addLocalScheme() was introduced. Adding the qrc URL
scheme as local obsoletes the qrcx URL scheme. GoldenDict does not
compile against Qt versions earlier than 4.6, so there is no reason to
use this custom URL scheme anymore.

Co-authored-by:  Igor Kushnir <igorkuo@gmail.com>
2023-03-05 15:20:05 -05:00
xiaoyifang 2404a5d341
Merge pull request #366 from shenlebantongying/staged
fix: enabled scanpopup at startup doesn't work
2023-03-04 16:58:38 +08:00
xiaoyifang e407a7b1ab
Merge pull request #364 from bershanskiy/darkreader
Add DarkReader.setFetchMethod()
2023-03-04 15:23:42 +08:00
shenleban tongying a0e32fdfa7 fix: enabled scanpopup at startup doesn't work
* also merge clipboard monitoring code with toolbar scanning action icon changing code together
2023-03-04 01:59:37 -05:00
xiaoyifang 7273f84682
Merge pull request #365 from xiaoyifang/fix/wiki-request
fix:wikipedia url request
2023-03-02 21:52:10 +08:00
Xiao YiFang 6151c914f5 fix:wikipedia url request 2023-03-02 21:23:35 +08:00