Commit graph

123 commits

Author SHA1 Message Date
YiFang Xiao 5ec1a66d91 fix: splash windows optimization 2023-07-08 08:59:42 +08:00
YiFang Xiao 92fa182643 fix: save audio, add opus extension 2023-07-07 20:26:40 +08:00
xiaoyifang af9563ad56
Merge pull request #923 from shenlebantongying/staged
misc fts fix
2023-07-02 12:24:19 +08:00
shenleban tongying ec566c4a3b
misc fts fixes
* config fts.enablePosition is not updated
 * update preferences layout
2023-07-01 23:41:05 -04:00
xiaoyifang 759246a86f
Merge pull request #920 from xiaoyifang/fix/status-2
fix: possible crash when show()
2023-07-02 10:00:45 +08:00
YiFang Xiao 9ab59d8713 fix: possible crash when show() 2023-07-02 08:37:28 +08:00
shenleban tongying e419962abc
doc: update fts related strings 2023-07-01 12:05:15 -04:00
xiaoyifang 2621fd694d
Merge pull request #917 from xiaoyifang/fix/statusbar
fix: statusbar crash  at some rare conditions
2023-07-01 22:59:04 +08:00
xiaoyifang 8b88ea544e
opt: add fullindex position (#916)
* opt: enable fulltext with position info

* opt: add fulltext position support

* 🎨 apply clang-format changes

* i18n: update translation entries

* opt: default enablePosition=false

* opt: fulltext search highlight

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-07-01 22:39:43 +08:00
YiFang Xiao ed8072d78f fix: statusbar at some rare conditions crash
the stacktrace show the line is parentWidget().
avoid using this the parentWidget() method.
2023-07-01 22:33:58 +08:00
xiaoyifang a878e725f2
fix: code smells in group widget (#901)
* fix: code smells in group widget

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-24 15:30:20 +08:00
YiFang Xiao 43c2cfdd65 fix: group widget null check 2023-06-23 09:28:35 +08:00
YiFang Xiao 2359352781 fix: editDictionaries tab interaction 2023-06-23 09:28:35 +08:00
YiFang Xiao aa94af4382 fix: fix double release pointer 2023-06-23 09:28:35 +08:00
YiFang Xiao f909413caa fix: code smells 2023-06-23 09:28:35 +08:00
YiFang Xiao 3b935e7660 fix: possible null object
refactor: group widget currentindex logic
2023-06-22 21:30:30 +08:00
xiaoyifang ef594117c3
opt: group widget remove all tabs (#892)
* opt: remove all group widget tabs

* 🎨 apply clang-format changes

* opt: does not elide text on tab name

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-22 17:17:57 +08:00
shenleban tongying ffe88499bb fix: macOS missing slot warning 2023-06-19 20:17:58 -04:00
shenleban tongying 1589e14b70
clean: remove redundant dictionaryNativeIcon
`dictionaryNativeIcon` was intended to access the original icon before none-square icons were transformed into squares.

`dictionaryNativeIcon` is only used in dictionaryBar, but according to the intention, it shouldn't.

In reality, `dictionaryNativeIcon` is almost always equal to `dictionaryIcon`.
2023-06-18 22:37:07 -04:00
shenleban tongying 9d19ea1ebc
feat: add -v --version flag to CLI
* also abstract version info into a standalone namespace
2023-06-17 05:00:05 -04:00
xiaoyifang 16f853b68b
fix: qtimer release memory (#863)
* fix: memory leakage
2023-06-16 08:37:33 +08:00
shenleban tongying 35f39ea7a0
clean: convert a few trivial old SIGNAL/SLOT to new syntax 2023-06-11 11:27:49 -04:00
shenleban tongying b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
2023-06-11 10:17:20 -04:00
shenleban tongying f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax
Historical context: `MainWindow::addGlobalAction` was invented by

https://github.com/goldendict/goldendict/pull/482/files
2023-06-11 04:47:39 -04:00
xiaoyifang ca4664f209
fix: possible crash (#836)
* fix: possible crash when show statusbar message

* windows qt upgrade to qt6.5.1

* Update src/ui/mainstatusbar.cc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-06-10 22:26:24 +08:00
shenlebantongying ab7af55696 update initializing.ui & splash img 2023-06-10 07:40:17 -04:00
xiaoyifang a688a08eb1
Merge pull request #843 from xiaoyifang/feature/splash-2
feat: make initialize ui more human-friendly
2023-06-10 18:25:48 +08:00
YiFang Xiao 90b89acac0 feat: make initialize ui more human-friendly 2023-06-10 16:57:49 +08:00
YiFang Xiao 799370f5ef fix: adjust margin around dictionary group 2023-06-10 14:45:48 +08:00
xiaoyifang 9c1a77a3f8
fix regression: select translation line text when got focused (#841)
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 10:36:59 +08:00
YiFang Xiao fc08c16479 fix: merge history items when import history items 2023-06-09 21:57:09 +08:00
xiaoyifang f02fc350f8
fix: keep the application name unchanged for now (#835)
fix: Windows autostart reg entry use GoldenDict as entry name
2023-06-09 19:56:51 +08:00
xiaoyifang 9d047fea61
fix: add an --reset-windows-state option to command line (#829)
* fix: add an --reset-windows-state option to command line

* add an option
2023-06-09 19:56:04 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter
the parameter has no use right now
2023-06-08 08:30:23 +08:00
xiaoyifang f58eb43bd2
opt: use QFontCombox instead (#781)
* opt: use QFontCombox instead

* 🎨 apply clang-format changes

* remove comment code

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-07 21:53:21 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
xiaoyifang e0dba5ac3b
Merge pull request #818 from shenlebantongying/expose_timer
feat: expose linux's selection clipboard delay timer to user
2023-06-05 22:46:08 +08:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808)
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-05 21:22:20 +08:00
shenleban tongying 6732f4630d
feat: expose linux's selection clipboard delay timer to user
* In certain programs like Chrome, the selection clipboard will update
even the user have not released mouse button.
2023-06-05 08:22:49 -04:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804)
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect
fix #718
2023-06-03 17:49:37 +08:00
xiaoyifang 5899aa7c94
fix: highlight fts search result (#792)
* fix: highlight fts search result

* 🎨 apply clang-format changes

* remove accent/diacritic handler used in fts search

* header file adjustment

* fix: qt5.15 compile

* fix: code smell

use const reference variable

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smells

🎨 apply clang-format changes

* opt: fix code smells

remove unused parameters from function `ftsIndexIsOldOrBad`

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 08:29:19 +08:00
xiaoyifang b7edc8ed2d 🎨 apply clang-format changes 2023-06-01 11:53:45 +00:00
YiFang Xiao 002f7a02f7 fix: code smells
refactor the disabledType string build
2023-06-01 19:52:16 +08:00
shenleban tongying 7f994112b7
fix: send to mainwindow got empty word
a regression due to Input Phase change: if word is sent to
mainwindow, then definition->getWord() would be empty
2023-05-31 04:17:16 -04:00
shenleban tongying 6823254bac clean: solve a TODO about translateInputFinished 2023-05-31 07:26:43 +08:00
shenleban tongying 6c7bb05f35 clean: convert SLOT translateInputFinished to new syntax 2023-05-31 07:26:43 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
2023-05-30 20:59:51 +08:00
YiFang Xiao 15e0fa087f opt: replace Mutex::Lock with QMutexLocker 2023-05-30 00:08:01 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736)
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
2023-05-29 00:01:54 +08:00