Commit graph

4201 commits

Author SHA1 Message Date
shenleban tongying a75867f82b refactor: convert articleview into plain code 2023-03-18 11:00:06 +08:00
Ren Tatsumoto fb6d4f9ccd
Let the user disable main window stealing focus when searching. (#387)
* add a checkbox that allows the user to disable main window being raised when search is triggered

* run clang-format on the edited lines

* partially revert clang-format
2023-03-17 09:54:45 +08:00
xiaoyifang 76fa9a806a change .clang-format style
ConstructorInitializerIndentWidth : 2
2023-03-17 09:51:06 +08:00
xiaoyifang ce40e66464
Update how to use .clang-format to format the code.md 2023-03-17 09:02:15 +08:00
Ren Tatsumoto 1a0af48a7a
Improve Anki support (#384)
* allow the user to configure word,text,sentence Anki fields

* if sentence field is not set, don't add it

* mark the target word bold, if possible

* Update how to connect with anki.md

* rename default field names
2023-03-16 19:55:47 +08:00
xiaoyifang c12c07a3a7 fix: typo 2023-03-16 15:56:26 +08:00
xiaoyifang a0211e258c
add code guildline when contributing code 2023-03-16 15:40:57 +08:00
xiaoyifang c012cc9140
add clang-format usage 2023-03-16 15:35:04 +08:00
xiaoyifang fa06c85d6d bump qt version to qt6.4.3 2023-03-16 14:17:13 +08:00
Xiao YiFang 91eefed48a fix:status bar when at the startup does not position correctly 2023-03-15 22:58:11 +08:00
Xiao YiFang 31c72dacdc fix: some mdx dictionary's description can be be displayed if using html 2023-03-15 21:34:11 +08:00
xiaoyifang 7242a53302 made some clang-format changes
BraceWrapping->AfterControlStatement:false
             ->BeforeCatch:true
2023-03-13 20:16:58 +08:00
Xiao YiFang 5b56790910 Merge remote-tracking branch 'gd/master' into staged 2023-03-11 14:22:05 +08:00
Xiao YiFang a54ee3e716 fix: convert string literal to Raw string to remove code smell 2023-03-11 14:10:02 +08:00
Xiao YiFang eb5ae99da9 fix: anchor #hashtag navigation failed to work 2023-03-11 14:10:02 +08:00
Xiao YiFang 61547dff03 feature: refactor the mainstatusbar 2023-03-11 11:04:07 +08:00
shenleban tongying 10a79372f8 fix: better QObject hierarchy
* set scanpopup's parent to null because it is a top level window.
* set macClipboard as a child of the mainWindow
2023-03-09 14:14:18 +08:00
shenleban tongying 9079e2125d fix: move enableScanningAction code after scanPopup's initialization 2023-03-07 17:46:52 +08:00
xiaoyifang afa77a8f31 fix: remove unused code 2023-03-07 17:46:37 +08:00
xiaoyifang 84798c56ea fix:check scanPopup existence 2023-03-07 10:09:18 +08:00
shenleban tongying 4f2c8d55aa refactor: port away from extlineedit
* the main feature of extlineedit.cc was having icons on left and right side which is already provided by QLineEdit::addAction after Qt5.2
2023-03-06 09:46:32 +08:00
xiaoyifang 9b7b64e174
Merge pull request #368 from shenlebantongying/qrcx_to_qrc
cleanup: Replace all usages of qrcx://localhost with qrc://
2023-03-06 07:33:21 +08:00
shenleban tongying 540dda26ed cleanup: Replace all usages of qrcx://localhost with qrc://
The replacement command:
git grep -l 'qrcx://localhost' | xargs sed -i 's/qrcx:\/\/localhost/qrc:\/\//g'

The qrcx:// URL scheme was introduced in 2009 or earlier - it is present
in the first commit in GoldenDict's git history. Back then GoldenDict
supported Qt versions earlier than 4.6, in which
QWebSecurityOrigin::addLocalScheme() was introduced. Adding the qrc URL
scheme as local obsoletes the qrcx URL scheme. GoldenDict does not
compile against Qt versions earlier than 4.6, so there is no reason to
use this custom URL scheme anymore.

Co-authored-by:  Igor Kushnir <igorkuo@gmail.com>
2023-03-05 15:20:05 -05:00
xiaoyifang 2404a5d341
Merge pull request #366 from shenlebantongying/staged
fix: enabled scanpopup at startup doesn't work
2023-03-04 16:58:38 +08:00
xiaoyifang e407a7b1ab
Merge pull request #364 from bershanskiy/darkreader
Add DarkReader.setFetchMethod()
2023-03-04 15:23:42 +08:00
shenleban tongying a0e32fdfa7 fix: enabled scanpopup at startup doesn't work
* also merge clipboard monitoring code with toolbar scanning action icon changing code together
2023-03-04 01:59:37 -05:00
xiaoyifang 7273f84682
Merge pull request #365 from xiaoyifang/fix/wiki-request
fix:wikipedia url request
2023-03-02 21:52:10 +08:00
Xiao YiFang 6151c914f5 fix:wikipedia url request 2023-03-02 21:23:35 +08:00
Anton Bershanskiy 68908c1d39 Add DarkReader.setFetchMethod() 2023-03-02 11:29:12 +00:00
xiaoyifang 5aa4102796 update Belarusian ts
changes from @antikruk at #362
2023-03-02 16:49:22 +08:00
Abs62 d424f25fb6 Set "https" scheme instead of "http" for some wiki resources 2023-03-02 00:46:00 +03:00
xiaoyifang 51864e7e62
Merge pull request #360 from shenlebantongying/staged
fix: set initial background as black for dark reader mode
2023-03-01 08:59:35 +08:00
shenlebantongying a674a5cab7 fix: set initial background as black for dark reader mode 2023-02-28 13:31:58 -05:00
xiaoyifang eb1206945b
Merge pull request #358 from xiaoyifang/fix/ubuntu-action
action: bump python
2023-02-26 19:57:14 +08:00
Xiao YiFang 656cd3734c action: bump python 2023-02-26 18:29:46 +08:00
xiaoyifang 27766d4e22
Merge pull request #356 from xiaoyifang/goldendict-master
upstream:save/restore scanpopup position
2023-02-26 15:37:46 +08:00
Xiao YiFang 346986a3cd fix: fix conflict when merge upstream changes 2023-02-26 09:26:58 +08:00
xiaoyifang e1324448c5
Delete codeql.yml 2023-02-24 15:52:24 +08:00
xiaoyifang 340814e0f6
Create codeql.yml 2023-02-24 14:56:29 +08:00
xiaoyifang f6096c1b01
Merge pull request #351 from shenlebantongying/staged
elimate makeScanPopup()
2023-02-24 09:49:41 +08:00
xiaoyifang b913a38e1f
fix: ensure #translateLine always have left border (#352)
Before:

![image](https://user-images.githubusercontent.com/20123683/220806071-709f0b2b-c693-49c5-8b5d-4609d18177dc.png)

After:


![image](https://user-images.githubusercontent.com/20123683/220806293-83cfb8da-286b-4a8f-aa1f-ab9533f4e8b5.png)
2023-02-23 17:44:35 +08:00
shenleban tongying b1802e254e fix: ensure #translateLine always have left border 2023-02-22 21:09:46 -05:00
shenleban tongying b3aac01f41 refactor: elimate makeScanPopup()
* Old code keep destory the scanpopup, then recreate it whenever the dict list or group list changed.
* New code keep a single instance of scanpopup, and only update necessary info.
2023-02-22 20:09:26 -05:00
xiaoyifang 67d5799708
refactor: convert scanflag.ui to plain code (#350)
The .ui file only contains a single widget. The overhead is unnecessary.

| Before: There is a weird top edge. | After |

|-----------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------|
|
![image](https://user-images.githubusercontent.com/20123683/220492330-13502c46-2f0b-4bc3-9462-0f426258dc97.png)
|
![image](https://user-images.githubusercontent.com/20123683/220492128-b77bc480-6a08-4ef2-88db-29aef753a3bd.png)
|

Slightly related to
https://github.com/xiaoyifang/goldendict/issues/349#issuecomment-1439224644,
we may use a similar flag later.
2023-02-22 10:03:01 +08:00
shenleban tongying 38956589a2 refactor: convert scanflag.ui to plain code 2023-02-21 19:56:12 -05:00
xiaoyifang a7c1589149
Merge pull request #348 from shenlebantongying/staged
Use alternative clipboard change monitor on macOS
2023-02-18 11:49:46 +08:00
shenleban tongying 497ecf3719 fix: use alternative clipboard change monitor on macOS
QClipboard cannot monitor data changes on mac unless an application is focused
2023-02-17 22:02:52 -05:00
xiaoyifang 737d4421f5
Merge pull request #347 from xiaoyifang/fix/local-file-dictionary
fix: file:/// local file dictionary support
2023-02-17 14:50:17 +08:00
xiaoyifang 84c6b79217 fix: local dictionary file:/// support 2023-02-16 16:11:27 +08:00
xiaoyifang c5b9e48e0e fix: local dictionary file:/// support 2023-02-16 15:58:44 +08:00